chore: fix lints and small bugs in shell scripts #139

theDoctor commented 2026年03月20日 14:04:22 +01:00

Took the newly added bash language server for a ride and "fixed" a couple of lints and a small bug.

Took the newly added bash language server for a ride and "fixed" a couple of lints and a small bug.

krig commented 2026年03月20日 14:17:26 +01:00

I tried running ./script/bundle-mac and got this:

 Updating git repository `https://github.com/zed-industries/cargo-bundle.git`
 Ignored package `cargo-bundle v0.6.1-zed (https://github.com/zed-industries/cargo-bundle.git?branch=zed-deploy#2be26699)` is already installed, use --force to override
cargo-about@0.8.2 is already installed.
Generating cargo licenses
+ fail_on_stderr cargo about generate --fail -c script/licenses/licenses.toml script/licenses/template.md.hbs
++ mktemp
+ tmpfile=/var/folders/9g/71df0lls2t3f0xk7c5ttt7qw0000gn/T/tmp.kuF3yt89e7
+ local tmpfile
+ cargo about generate --fail -c script/licenses/licenses.toml script/licenses/template.md.hbs
script/generate-licenses: line 12: tmpfile: unbound variable
+ local rc=0
script/generate-licenses: line 14: tmpfile: unbound variable

I tried running `./script/bundle-mac` and got this: ``` Updating git repository `https://github.com/zed-industries/cargo-bundle.git` Ignored package `cargo-bundle v0.6.1-zed (https://github.com/zed-industries/cargo-bundle.git?branch=zed-deploy#2be26699)` is already installed, use --force to override cargo-about@0.8.2 is already installed. Generating cargo licenses + fail_on_stderr cargo about generate --fail -c script/licenses/licenses.toml script/licenses/template.md.hbs ++ mktemp + tmpfile=/var/folders/9g/71df0lls2t3f0xk7c5ttt7qw0000gn/T/tmp.kuF3yt89e7 + local tmpfile + cargo about generate --fail -c script/licenses/licenses.toml script/licenses/template.md.hbs script/generate-licenses: line 12: tmpfile: unbound variable + local rc=0 script/generate-licenses: line 14: tmpfile: unbound variable ```

theDoctor commented 2026年03月20日 14:30:00 +01:00

Good catch, I fixed it.

Good catch, I fixed it.