feat: add XML language server lemminx #121

krig commented 2026年03月17日 13:10:27 +01:00

Looking at the repository it looks like there are binaries for Linux and Windows available too (guessing that they are x86_64 only), so maybe this check should only be for arch and not OS_NAME?

Looking at the repository it looks like there are binaries for Linux and Windows available too (guessing that they are x86_64 only), so maybe this check should only be for arch and not OS_NAME?

theDoctor commented 2026年03月17日 13:26:13 +01:00

The language server binary is not provided for aarch64 architectures on Linux or Windows. To account for this, the check is meant to raise an error, if an OS that isn't macOS with an architecture that isn't x86_64 tries to get the binary.

If checking only for arch, that would result in a false positive on macOS-aarch64.

I updated the error message to make this more clear.

The language server binary is not provided for aarch64 architectures on Linux or Windows. To account for this, the check is meant to raise an error, if an OS that isn't macOS with an architecture that isn't x86_64 tries to get the binary. If checking only for arch, that would result in a false positive on macOS-aarch64. I updated the error message to make this more clear.