Remove unused credentials code #110

tjk commented 2026年03月16日 05:35:52 +01:00

I started out by noticing that docs/linux.md references "OpenAI API keys" and removed that since it obviously no longer applies. Then I noticed "Gram login cookie" in the same sentence and realized there may still be some code for these removed features, and I found the read/write/delete_credentials functions for each platform that are unused in Gram. To finish it off, I found the keychain/credentials references, which I believe were also related to Zed persisting secrets unused by Gram.

I'm new to Gram and have never looked at Zed's code, so I apologize if I misunderstood something, or if you're planning to use some of these in the future in Gram.

cargo check still passes, so I'm fairly sure I didn't remove anything used right now.

I started out by noticing that `docs/linux.md` references "OpenAI API keys" and removed that since it obviously no longer applies. Then I noticed "Gram login cookie" in the same sentence and realized there may still be some code for these removed features, and I found the read/write/delete_credentials functions for each platform that are unused in Gram. To finish it off, I found the keychain/credentials references, which I believe were also related to Zed persisting secrets unused by Gram. I'm new to Gram and have never looked at Zed's code, so I apologize if I misunderstood something, or if you're planning to use some of these in the future in Gram. `cargo check` still passes, so I'm fairly sure I didn't remove anything used right now.

krig commented 2026年03月16日 05:50:15 +01:00

Thank you! How did I miss that reference to openai... 😄

Thank you! How did I miss that reference to openai... 😄