5
3
Fork
You've already forked libfx2
0

Add standalone url field to fx2 setup.py #4

Closed
artizirk wants to merge 1 commit from pypi-url into main
pull from: pypi-url
merge into: GlasgowEmbedded:main
GlasgowEmbedded:main
artizirk commented 2020年06月02日 22:40:17 +02:00 (Migrated from github.com)
Copy link

This should add a visible homepage link to pypi sidebar 1 on next
release upload.

This should add a visible homepage link to pypi sidebar [1] on next release upload. [1]:https://pypi.org/project/fx2/

Huh. Why don't these links already show up in sidebar?
Screenshot_20200602_204349

Huh. Why don't these links already show up in sidebar? ![Screenshot_20200602_204349](https://user-images.githubusercontent.com/54771/83567830-c36dc700-a511-11ea-8c0b-f3fce6e6ff53.png)
artizirk commented 2020年06月03日 09:41:56 +02:00 (Migrated from github.com)
Copy link

It could be some edge case with url metadata handling, twine also uses project_urls field and those show up fine. I will try to dig deeper to figure out whats going on.

It could be some edge case with url metadata handling, [twine](https://github.com/pypa/twine/blob/master/setup.cfg#L8-L13) also uses `project_urls` field and those show up fine. I will try to dig deeper to figure out whats going on.
artizirk commented 2020年06月03日 10:09:35 +02:00 (Migrated from github.com)
Copy link

So, I did some testing with testpypi and it looks like both, with and without the url field show all three project_urls links.

Also python3 setup.py check does complain about missing url meta-data

$ python3 setup.py check
running check
warning: Check: missing required meta-data: url

Package upload to testpypi was done with twine 2.0.0. I don't know it that has something to do with missing links.

Screenshot_2020年06月03日 fx2

Screenshot_2020年06月03日 fx2(1)

So, I did some testing with [testpypi](https://packaging.python.org/guides/using-testpypi/) and it looks like both, with and without the `url` field show all three `project_urls` links. Also `python3 setup.py check` does complain about missing `url` meta-data ``` $ python3 setup.py check running check warning: Check: missing required meta-data: url ``` Package upload to testpypi was done with twine 2.0.0. I don't know it that has something to do with missing links. ![Screenshot_2020年06月03日 fx2](https://user-images.githubusercontent.com/1923870/83611426-9d840900-a589-11ea-99f3-982be0c1690a.png) ![Screenshot_2020年06月03日 fx2(1)](https://user-images.githubusercontent.com/1923870/83611473-affe4280-a589-11ea-8ee4-ae60b691b12b.png)

Okay so the only thing I have to do here is to upload the package again with twine, right?

Okay so the only thing I have to do here is to upload the package again with twine, right?
artizirk commented 2020年06月05日 08:17:05 +02:00 (Migrated from github.com)
Copy link

I think so yes.

I think so yes.

I've uploaded with twine but there are still no project links anywhere.

I've uploaded with twine but there are still no project links anywhere.

The links are fixed now: https://pypi.org/project/fx2/

The links are fixed now: https://pypi.org/project/fx2/

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
GlasgowEmbedded/libfx2!4
Reference in a new issue
GlasgowEmbedded/libfx2
No description provided.
Delete branch "pypi-url"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?