5
3
Fork
You've already forked libfx2
0

Make it look for 'sdcc-sdcc' and 'sdcc-sdas8051' executables too #17

Closed
purdeaandrei wants to merge 1 commit from f_autodetect_sdcc_executable_names into main
pull from: f_autodetect_sdcc_executable_names
merge into: GlasgowEmbedded:main
GlasgowEmbedded:main
purdeaandrei commented 2024年08月01日 04:03:15 +02:00 (Migrated from github.com)
Copy link

This is the name of the executables on fedora (tested on fedora:latest docker container)

This is the name of the executables on fedora (tested on fedora:latest docker container)

I'm not really happy with the complexity this adds; I also don't particularly like the idea of maintaining a set of workarounds for individual distros. Why does Fedora do this anyway?

I'm not really happy with the complexity this adds; I also don't particularly like the idea of maintaining a set of workarounds for individual distros. Why does Fedora do this anyway?

I think a better approach would be to make sure we have the definitions of

SDCC = sdcc
SDAR = sdar
SDAS8051 = sdas8051

and then separate ones that include the common flags, something like RUN_SDCC = $(SDCC) ....

This way, people working around weird upstream decisions can easily override them, while leaving me free from the burden of working around these decisions.

I think a better approach would be to make sure we have the definitions of ``` SDCC = sdcc SDAR = sdar SDAS8051 = sdas8051 ``` and then separate ones that include the common flags, something like `RUN_SDCC = $(SDCC) ...`. This way, people working around weird upstream decisions can easily override them, while leaving me free from the burden of working around these decisions.
purdeaandrei commented 2024年08月01日 04:50:23 +02:00 (Migrated from github.com)
Copy link

I'm not really happy with the complexity this adds; I also don't particularly like the idea of maintaining a set of workarounds for individual distros. Why does Fedora do this anyway?

Looks like it's been like this since 2007.
Changelog:
image
And I also found a fedora readme:
image

Which I checked, indeed the real executables are in libexec, and bin only contains shell scripts that pass on to libexec.

Perhaps we can add a note to the glasgow firmware, to add /usr/libexec/sdcc to PATH, does that sound acceptable?

> I'm not really happy with the complexity this adds; I also don't particularly like the idea of maintaining a set of workarounds for individual distros. Why does Fedora do this anyway? Looks like it's been like this since 2007. Changelog: ![image](https://github.com/user-attachments/assets/66ac7400-7f01-4318-a105-edb7b1da9234) And I also found a fedora readme: ![image](https://github.com/user-attachments/assets/c63bae5e-6dfc-49c7-8529-c2fa86b121c6) Which I checked, indeed the real executables are in libexec, and bin only contains shell scripts that pass on to libexec. Perhaps we can add a note to the glasgow firmware, to add `/usr/libexec/sdcc` to PATH, does that sound acceptable?

Perhaps we can add a note to the glasgow firmware, to add /usr/libexec/sdcc to PATH, does that sound acceptable?

Yeah.

> Perhaps we can add a note to the glasgow firmware, to add `/usr/libexec/sdcc` to PATH, does that sound acceptable? Yeah.
purdeaandrei commented 2024年08月01日 04:53:51 +02:00 (Migrated from github.com)
Copy link

Alright, I'll close this PR.

Alright, I'll close this PR.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
GlasgowEmbedded/libfx2!17
Reference in a new issue
GlasgowEmbedded/libfx2
No description provided.
Delete branch "f_autodetect_sdcc_executable_names"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?