5
3
Fork
You've already forked libfx2
0

compatibility with sdcc 4.3.0: emit build/.d files through a separate command #15

Merged
carlossless merged 1 commit from sdcc-4.3.0-compatibility into main 2024年01月26日 17:11:05 +01:00
carlossless commented 2024年01月25日 18:23:14 +01:00 (Migrated from github.com)
Copy link

Implementing the two-pass solution mentioned here as the one originally implemented as part of #13 wasn't accepted.

I am unsure whether this should be a separate rule or part of the previously existing one, so please tell me whatever is more preferred here.

I've tested this on sdcc 4.2.0 and 4.3.0 and in both cases, compilation happens without error, and build/*.d files contain expected contents. Hopefully, I haven't missed something.

Related: https://github.com/whitequark/libfx2/issues/11#issuecomment-1910613239

Implementing the two-pass solution mentioned [here](https://sourceforge.net/p/sdcc/mailman/message/37851121/) as the one originally implemented as part of #13 wasn't accepted. I am unsure whether this should be a separate rule or part of the previously existing one, so please tell me whatever is more preferred here. I've tested this on sdcc 4.2.0 and 4.3.0 and in both cases, compilation happens without error, and build/*.d files contain expected contents. Hopefully, I haven't missed something. Related: https://github.com/whitequark/libfx2/issues/11#issuecomment-1910613239
whitequark left a comment
Copy link

Perfectly happy with this, thank you. Do you need a release after this is merged?

Perfectly happy with this, thank you. Do you need a release after this is merged?
carlossless commented 2024年01月25日 19:22:25 +01:00 (Migrated from github.com)
Copy link

Perfectly happy with this, thank you. Do you need a release after this is merged?

Awesome! Yeah, a release would be great for pushing forward https://github.com/NixOS/nixpkgs/pull/265651.

RE https://github.com/whitequark/libfx2/issues/11#issuecomment-1910640372: I also just tested this against sdcc v4.4.0-rc3 and didn't encounter any failures. CC @spth

> Perfectly happy with this, thank you. Do you need a release after this is merged? Awesome! Yeah, a release would be great for pushing forward https://github.com/NixOS/nixpkgs/pull/265651. RE https://github.com/whitequark/libfx2/issues/11#issuecomment-1910640372: I also just tested this against sdcc v4.4.0-rc3 and didn't encounter any failures. CC @spth

Version 0.13 released, thanks @carlossless!

Version 0.13 released, thanks @carlossless!
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
GlasgowEmbedded/libfx2!15
Reference in a new issue
GlasgowEmbedded/libfx2
No description provided.
Delete branch "sdcc-4.3.0-compatibility"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?