• Finland
  • Joined on 2022年05月25日
Erwinjitsu commented on issue The-World-Machine/PeerTube-GTK#102 2026年07月04日 17:56:40 +02:00
Check button to toggle button option

Alternatives to check button:

Erwinjitsu pushed to gtk4 at Erwinjitsu/PeerTube-GTK 2026年02月11日 19:22:49 +01:00
ad0c73af89 Box redone as template (yet remains unfitted)
Erwinjitsu pushed to gtk4 at Erwinjitsu/PeerTube-GTK 2026年02月03日 22:04:37 +01:00
df89951318 PublicationControl.c mostly* in GTK4
Erwinjitsu pushed to gtk4 at Erwinjitsu/PeerTube-GTK 2026年02月02日 09:26:56 +01:00
d8503cf00e Popup.c fixed to use GTK4 non-deprecated methods
Erwinjitsu pushed to gtk4 at Erwinjitsu/PeerTube-GTK 2026年02月01日 21:47:12 +01:00
18c44f7114 Remove oopsie files
Erwinjitsu pushed to gtk4 at Erwinjitsu/PeerTube-GTK 2026年02月01日 21:40:16 +01:00
cf585a7f3f [GTK4] Merge 'master'
43d471538a Replace GTK3 tray icon with libstray (#100)
5536a2f1f2 Simplify backwards/forwards menu, fix backwards order (#99)
Compare 3 commits »
Erwinjitsu approved The-World-Machine/PeerTube-GTK#100 2026年01月31日 20:09:10 +01:00
Replace GTK3 tray icon with libstray

Appears to be in order and confirmed it works on systems without system tray.

Erwinjitsu commented on pull request The-World-Machine/PeerTube-GTK#100 2026年01月31日 18:54:03 +01:00
Replace GTK3 tray icon with libstray

Isn't this same as taking MAX of Width and Height and then dividing ICON_BIG_SIZE with the bigger one. This way you cut away one cast to double.

Erwinjitsu suggested changes for The-World-Machine/PeerTube-GTK#100 2026年01月31日 18:54:03 +01:00
Replace GTK3 tray icon with libstray

Few things with one optional change.

Erwinjitsu commented on pull request The-World-Machine/PeerTube-GTK#100 2026年01月31日 18:54:02 +01:00
Replace GTK3 tray icon with libstray

Another point: pkg-config --cflags dbus-1 also lists some include paths. The reason why we don't need it there is because gtk has those included as well (though they do not link against dbus-1...

Erwinjitsu commented on pull request The-World-Machine/PeerTube-GTK#100 2026年01月31日 18:54:02 +01:00
Replace GTK3 tray icon with libstray

Upper case Y is perhaps what you want here.

Erwinjitsu commented on pull request The-World-Machine/PeerTube-GTK#100 2026年01月31日 18:54:02 +01:00
Replace GTK3 tray icon with libstray

Upper case X is perhaps what you want here.

Erwinjitsu commented on pull request The-World-Machine/PeerTube-GTK#100 2026年01月31日 13:11:31 +01:00
Replace GTK3 tray icon with libstray

dbus-1 has a pkg-config file, so you may move dbus-1 inside the ``

Erwinjitsu commented on pull request The-World-Machine/PeerTube-GTK#100 2026年01月31日 13:11:31 +01:00
Replace GTK3 tray icon with libstray

If these are global, add static to them to make them local to this file and make sure to prefix the names with "Tray"

Erwinjitsu suggested changes for The-World-Machine/PeerTube-GTK#100 2026年01月31日 13:11:31 +01:00
Replace GTK3 tray icon with libstray

Two things

Erwinjitsu approved The-World-Machine/PeerTube-GTK#99 2026年01月30日 17:26:14 +01:00
Simplify backwards/forwards menu, fix backwards order

SEEMS TO ME THIS IS FINE

Erwinjitsu approved The-World-Machine/PeerTube-GTK#99 2026年01月30日 17:21:59 +01:00
Simplify backwards/forwards menu, fix backwards order

Looks fine to me.

Erwinjitsu pushed to gtk4 at Erwinjitsu/PeerTube-GTK 2026年01月30日 16:51:14 +01:00
87b9ccdb65 List.c mostly in GTK4
Erwinjitsu pushed to gtk4 at Erwinjitsu/PeerTube-GTK 2026年01月30日 13:06:39 +01:00
acc6a7b4d8 First use of Cambalache