2
4
Fork
You've already forked libssc
8

Add optional gobject introspection and vapi generation #68

Merged
DylanVanAssche merged 3 commits from NekoCWD/libssc:vapi-wip into main 2025年03月04日 13:37:25 +01:00
Contributor
Copy link
No description provided.
NekoCWD changed title from (削除) Add option gobject introspection and vapi generation (削除ここまで) to Add optional gobject introspection and vapi generation 2025年03月02日 15:10:33 +01:00
DylanVanAssche left a comment
Copy link

Can you please have a look at my 2 comments? Looks great, mostly nitpicks.

Can you please have a look at my 2 comments? Looks great, mostly nitpicks.
@ -0,0 +1,2 @@
option('generate_gir',type:'feature',value:'enabled',description:'Generate GObject introspection for libssc')
option('generate_vapi',type:'feature',value:'enabled',description:'Generate vala bindings for libssc. GIR required')

Can't we auto-enable these options instead of having them enabled by default?
If gobject introspection and other dependencies are available, it gets enabled, otherwise not?

I'm no meson expert, so I might be interpreting this wrong.

Can't we auto-enable these options instead of having them enabled by default? If gobject introspection and other dependencies are available, it gets enabled, otherwise not? I'm no meson expert, so I might be interpreting this wrong.
Author
Contributor
Copy link

Sure, we can 👍

Sure, we can 👍
NekoCWD marked this conversation as resolved
src/meson.build Outdated
@ -88,1 +88,4 @@
)
ifget_option('generate_gir').disabled()andget_option('generate_vapi').enabled()
error('You need to enable GIR generation to generate vapi')

Maybe harmonize vapi and vala? The option has Generate vala bindings and here it says to generate vapi.

Maybe harmonize `vapi` and `vala`? The option has `Generate vala bindings` and here it says `to generate vapi`.
NekoCWD marked this conversation as resolved
src/meson.build Outdated
@ -89,0 +99,4 @@
namespace:ns,
symbol_prefix:'ssc',
nsversion:'0',
export_packages:'libssc-0',

Since 5e0c4bd2c3 the so version has been bumped to 1. Do we need to increase here something as well?

Since https://codeberg.org/DylanVanAssche/libssc/commit/5e0c4bd2c3ba1b2c1a6662ea54c68150c6e5a583 the so version has been bumped to 1. Do we need to increase here something as well?
NekoCWD marked this conversation as resolved
@ -89,0 +98,4 @@
namespace:ns,
symbol_prefix:'ssc',
nsversion:so_version,
export_packages:'libssc-0',

Do we need also here so_version? Not an expert, just wondering.

Do we need also here `so_version`? Not an expert, just wondering.
Author
Contributor
Copy link

That's package name (like Adw-1 for all adwaita versions)

That's package name (like Adw-1 for all adwaita versions)
DylanVanAssche marked this conversation as resolved
Sign in to join this conversation.
No reviewers
No labels
Bug
Feature
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
DylanVanAssche/libssc!68
Reference in a new issue
DylanVanAssche/libssc
No description provided.
Delete branch "NekoCWD/libssc:vapi-wip"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?