2
42
Fork
You've already forked Retiled
1

WIP: Appbar Drawer DX #563

Draft
DrewNaylor wants to merge 15 commits from drawer-dx into main
pull from: drawer-dx
merge into: DrewNaylor:main
DrewNaylor:main
DrewNaylor:rounded-tiles-with-wallpaper
DrewNaylor:allow-alternate-styles
DrewNaylor:rust-stuff
DrewNaylor:use-tiledmenu-tilesgrid
DrewNaylor:tilesgrid-integration
DrewNaylor:parallax-background-test

Replacement for the old appbar drawer which used QtQuick's "Drawer" item and caused scrolling problems due to interference with its drag up and down open and close gesture. This doesn't have a way to drag it open and closed as of writing but it's a lot less janky. Still need to reimplement the "tap outside the popup to close" thing and improve keyboard focus so it goes through the appbar drawer items (I was thinking it could auto-expand the appbar drawer when tabbing to the appbar drawer expand button but that would be too annoying maybe); I think the focus can be shown by highlighting the focused item with a rectangle outline of the user's accent color (I saw somewhere that Qt has a way to tell how something gained focus, whether by keyboard or mouse click or touchscreen tap and I want to use that but I lost it, maybe it's a QtWidgets thing).

Something I need to figure out is how to have the new appbar not overlay the app's page if the app doesn't want it to.

TODO:

  • fix the back button icon being in the wrong spot when expanded
  • make the appbar drawer's parent the appbar for each of the apps that use it.
  • clean up appbar and appbar-related comments that talk about the old drawer item to not be confusing
  • add the MouseArea that allows closing the appbar drawer by tapping or clicking outside it
  • try to get keyboard focus working with the drawer
  • if I can figure it out, get some sort of a drag-to-open gesture on the left and right sides
  • replace the Back button text with an icon like the ellipsis button so it can be aligned at the top
  • scroll the flickable in the drawer to the top when opening it

See also: #540.

Replacement for the old appbar drawer which used QtQuick's "Drawer" item and caused scrolling problems due to interference with its drag up and down open and close gesture. This doesn't have a way to drag it open and closed as of writing but it's a lot less janky. Still need to reimplement the "tap outside the popup to close" thing and improve keyboard focus so it goes through the appbar drawer items (I was thinking it could auto-expand the appbar drawer when tabbing to the appbar drawer expand button but that would be too annoying maybe); I think the focus can be shown by highlighting the focused item with a rectangle outline of the user's accent color (I saw somewhere that Qt has a way to tell how something gained focus, whether by keyboard or mouse click or touchscreen tap and I want to use that but I lost it, maybe it's a QtWidgets thing). Something I need to figure out is how to have the new appbar not overlay the app's page if the app doesn't want it to. TODO: - [ ] fix the back button icon being in the wrong spot when expanded - [ ] make the appbar drawer's parent the appbar for each of the apps that use it. - [ ] clean up appbar and appbar-related comments that talk about the old drawer item to not be confusing - [ ] add the MouseArea that allows closing the appbar drawer by tapping or clicking outside it - [ ] try to get keyboard focus working with the drawer - [ ] if I can figure it out, get some sort of a drag-to-open gesture on the left and right sides - [ ] replace the Back button text with an icon like the ellipsis button so it can be aligned at the top - [ ] scroll the flickable in the drawer to the top when opening it See also: #540.
again, but it doesn't work yet to open the pane.
I'm really happy about this. I need to add comments and stuff though and make it close properly.
I'm going to put the drawer in the appbar itself I think. That will be more work.
I tried fixing the problem with the appbar back button to have it be visible but it's just not showing up and I don't know why.
DrewNaylor changed title from (削除) Appbar Drawer DX (削除ここまで) to WIP: Appbar Drawer DX 2026年04月20日 14:42:13 +02:00
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin drawer-dx:drawer-dx
git switch drawer-dx

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff drawer-dx
git switch drawer-dx
git rebase main
git switch main
git merge --ff-only drawer-dx
git switch drawer-dx
git rebase main
git switch main
git merge --no-ff drawer-dx
git switch main
git merge --squash drawer-dx
git switch main
git merge --ff-only drawer-dx
git switch main
git merge drawer-dx
git push origin main
Sign in to join this conversation.
No reviewers
Labels
Clear labels
accessibility
Anything relating to Accessibility/Ease of Access.
app
Non-shell applications. Does not include RetiledStart even though it's a regular window because it's too close to being a shell component.
archived
This discussion, issue, or pr is archived and locked.
bug
Something isn't working
documentation
Improvements or additions to documentation, or this pr/issue is basically documentation until the next version is ready
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
known issue
overhaul
Massive changes, additions, or removals
performance
question
Further information is requested
regression
Bug that wasn't there before.
shell
Shell components, specifically things like the status bar and navbar. RetiledStart shouldn't count since it's an application window but I include it here.
still has cool ideas
Closed issues that might still have some cool ideas.
themes+styles
Theme-related issues.
todo
Reminder for something to do later.
wontfix
I'm not really feeling it.
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
DrewNaylor/Retiled!563
Reference in a new issue
DrewNaylor/Retiled
No description provided.
Delete branch "drawer-dx"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?