• Joined on 2023年05月09日
DanielGibson commented on issue forgejo/discussions#245 2024年11月25日 00:28:51 +01:00
Rethink themes implementation to allow for easier colorblind variants

This would be like choosing gitea-light for my light theme and forgejo-dark for my dark theme.

ah ok, I misunderstood, sorry!

I find it really essential for my website to switch themes...

DanielGibson commented on issue forgejo/discussions#245 2024年11月24日 21:58:46 +01:00
Rethink themes implementation to allow for easier colorblind variants

Allowing the user to set each theme independently of the other would remove the need for all -auto- themes, significantly reducing the number of options presented to the user.

The user...

DanielGibson pushed to improve-colorblind-themes at DanielGibson/forgejo 2024年11月24日 15:04:54 +01:00
4ec627c0b1 Improve colors used by colorblind-friendly forgejo themes
19bde653c1 Merge pull request 'Update module github.com/stretchr/testify to v1.10.0 (forgejo)' (#6058) from renovate/forgejo-github.com-stretchr-testify-1.x into forgejo
8f0de303f3 Update module github.com/stretchr/testify to v1.10.0
Compare 3 commits »
DanielGibson commented on pull request forgejo/forgejo#6059 2024年11月24日 14:47:44 +01:00
Improve colors used by colorblind-friendly forgejo themes

I added manual testing instructions

DanielGibson pushed to improve-colorblind-themes at DanielGibson/forgejo 2024年11月24日 05:54:51 +01:00
7f41d08d9d Improve colors used by colorblind-friendly forgejo themes
c1ba9d37ab Merge pull request 'fix: Do not delete global Oauth2 applications' (#6054) from fnetx/global-oauth-corruption into forgejo
1d5aee6ef8 fix: Do not delete global Oauth2 applications
665d5f7317 test: Global OAuth should not be deleted
9057100182 fix: Preview picture not visible on Markdown file (#5781)
Compare 5 commits »
DanielGibson commented on issue forgejo/forgejo#986 2024年11月24日 05:53:34 +01:00
[FEAT] Offer colorblind-friendly theme(s)

Pull Request with my modifications for these themes: #6059

DanielGibson commented on pull request forgejo/forgejo#1746 2024年11月24日 05:49:30 +01:00
Feat: Add colorblind theme variants

I created a PR for the "refine the existing colorblind friendly themes": #6059

A potential solution for the combinatoric explosion of themes could be to allow configuring a base theme and an...

DanielGibson created pull request forgejo/forgejo#6059 2024年11月24日 05:37:52 +01:00
Improve colors used by colorblind-friendly forgejo themes
DanielGibson pushed to improve-colorblind-themes at DanielGibson/forgejo 2024年11月24日 05:34:49 +01:00
695f030930 Improve colors used by colorblind-friendly forgejo themes
DanielGibson created branch improve-colorblind-themes in DanielGibson/forgejo 2024年11月24日 05:34:48 +01:00
DanielGibson commented on pull request forgejo/forgejo#1746 2024年11月23日 03:41:36 +01:00
Feat: Add colorblind theme variants

I was also thinking about making colorblind versions of the gitea themes (because I actually prefer gitea-light's button colors etc over the ones used by forgejo-light).

One thing that annoys...

DanielGibson created repository DanielGibson/forgejo 2024年11月23日 02:37:12 +01:00
DanielGibson commented on pull request forgejo/forgejo#1746 2024年11月23日 02:21:57 +01:00
Feat: Add colorblind theme variants

Apologies for the late reply - I got caught up in life and work.

no worries, we were still waiting for Tritans to turn up - though TBH I fear that's not gonna happen, so I plan to create a...

DanielGibson commented on pull request forgejo/forgejo#1746 2024年11月13日 18:59:11 +01:00
Feat: Add colorblind theme variants

As I made the blue in the dark theme more green in the Tritanopia theme, I thought it might make sense to do the same for the light Tritanopia theme. The screenshot below uses `--color-diff-added...

DanielGibson commented on pull request forgejo/forgejo#1746 2024年11月13日 01:28:02 +01:00
Feat: Add colorblind theme variants

Another try at dark, only changed the added row background to be a greener blue: #152846 instead of #18184f

:root {
 /* removed rows/words: same red as vanilla forgejo-dark */
 
...
DanielGibson commented on pull request forgejo/forgejo#1746 2024年11月13日 00:55:42 +01:00
Feat: Add colorblind theme variants

Yes! This new color is way better (for me at least).

Great! I updated my comment above (because it's linked in the Mastodon post) with a new screenshot and modified value in the CSS.

I'll...

DanielGibson commented on pull request forgejo/forgejo#1746 2024年11月13日 00:36:00 +01:00
Feat: Add colorblind theme variants

Can you post a picture from the simulator?

I just found out how to activate the developer settings on my phone and tested it myself. I agree that in that simulator your dark tritanopia theme...

DanielGibson commented on issue forgejo/forgejo#986 2024年11月13日 00:09:05 +01:00
[FEAT] Offer colorblind-friendly theme(s)

I think branding the condition as "blindness" does it a disservice. Think of it more like a deficiency.

True, though for some it is a color blindness (-opia vs -omaly). However...

DanielGibson commented on pull request forgejo/forgejo#1746 2024年11月13日 00:01:27 +01:00
Feat: Add colorblind theme variants

If we trust the Android simulated color space then it is a bit worse for tritanopia, especially the blue background color

Interesting - shouldn't a brighter blue be more discernible from a...

DanielGibson commented on pull request forgejo/forgejo#1746 2024年11月12日 23:32:19 +01:00
Feat: Add colorblind theme variants

@DanielGibson would you be interested in maintaining the themes in Forgejo? It would be fine for me if you tweak them so you can work with them well, potentially also listening to other users...