3
4
Fork
You've already forked validns
5

feat: render full NSEC3 rdata in verbose output #136

Merged
jelu merged 4 commits from tobez/validns:feat-nsec3-human into main 2026年07月06日 13:30:51 +02:00
Collaborator
Copy link

nsec3_human() rendered only the hash algorithm, flags, iterations, and
salt, silently dropping the next hashed owner and the type bitmap, so -v
output for NSEC3 records was incomplete and could not round-trip back to the
same wire format.

This renders the next hashed owner (base32hex via the existing encoder) and
the type list, reusing a type-bitmap renderer extracted from nsec_human()
so NSEC and NSEC3 share one implementation.

`nsec3_human()` rendered only the hash algorithm, flags, iterations, and salt, silently dropping the next hashed owner and the type bitmap, so `-v` output for NSEC3 records was incomplete and could not round-trip back to the same wire format. This renders the next hashed owner (base32hex via the existing encoder) and the type list, reusing a type-bitmap renderer extracted from `nsec_human()` so NSEC and NSEC3 share one implementation.
fix: drop dead store flagged by scan-build in nsec/nsec3 human render
All checks were successful
builds.sr.ht/freebsd Job completed
builds.sr.ht/openbsd Job completed
test / debian (pull_request) Successful in 31s
test / ubuntu (pull_request) Successful in 32s
test / centos (pull_request) Successful in 50s
test / scan-build (pull_request) Successful in 1m7s
dbd1dfc9ab
Owner
Copy link

#build

#build
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
DNS-OARC/validns!136
Reference in a new issue
DNS-OARC/validns
No description provided.
Delete branch "tobez/validns:feat-nsec3-human"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?