Vendor linenoise sources #47

jgart commented 2025年12月17日 22:27:50 +01:00

Hi @martinwguy

This PR adds in the vendored sources for linenoise taken from here:

https://github.com/antirez/linenoise

I've added some documentation about this as well.

I've added a small amount of build system logic in order to simplify packaging for distro maintainers who prefer to use their system installed linenoise library.

What do you think?

If all looks good I can merge to main or simplify as you prefer.

Hi @martinwguy This PR adds in the vendored sources for `linenoise` taken from here: https://github.com/antirez/linenoise I've added some documentation about this as well. I've added a small amount of build system logic in order to simplify packaging for distro maintainers who prefer to use their system installed linenoise library. What do you think? If all looks good I can merge to `main` or simplify as you prefer.

martinwguy commented 2025年12月18日 16:21:58 +01:00

rlwrap is interesting but Professor Turner's direction was
to incorporate linenoise directly so let's do that.

Please go ahead. I'll make a new release as and when.

Blessings & thanks for caring

M

`rlwrap` is interesting but Professor Turner's direction was to incorporate linenoise directly so let's do that. Please go ahead. I'll make a new release as and when. Blessings & thanks for caring M

jgart commented 2025年12月18日 20:25:50 +01:00

@martinwguy wrote in #47 (comment):

rlwrap is interesting but Professor Turner's direction was to incorporate linenoise directly so let's do that.

Hi, ok, sounds good. That makes sense. 🎉

Please go ahead. I'll make a new release as and when.

Give me a day or two to review a few things and I'll proceed with merging these build system changes.

Blessings & thanks for caring

Thank you for reviewing and for being encouraging and welcoming.

@martinwguy wrote in https://codeberg.org/DATurner/miranda/pulls/47#issuecomment-9034860: > `rlwrap` is interesting but Professor Turner's direction was to incorporate linenoise directly so let's do that. Hi, ok, sounds good. That makes sense. 🎉 > Please go ahead. I'll make a new release as and when. Give me a day or two to review a few things and I'll proceed with merging these build system changes. > Blessings & thanks for caring Thank you for reviewing and for being encouraging and welcoming.

martinwguy commented 2025年12月19日 17:40:04 +01:00

My only other thought is how it might interfere with programs that read stdin,
like a visual editor for example, presumably wanting one character at a time.
isatty(0) maybe (like for --hush) and only for the interactive command line.
That said it seems to run normally in "cooked mode" with [Delete] and so on
but if one does "stty cbreak; mira" and say $- it does get one character at a time.

My only other thought is how it might interfere with programs that read stdin, like a visual editor for example, presumably wanting one character at a time. isatty(0) maybe (like for --hush) and only for the interactive command line. That said it seems to run normally in "cooked mode" with [Delete] and so on but if one does "stty cbreak; mira" and say $- it does get one character at a time.

martinwguy commented 2026年02月18日 04:56:25 +01:00

@jgart Please forgive me, I've been forgetting this for ages, always taken with sox_ng.

Save me some time: can you make a branch with the changes you suggest?
I can see about making another release if all goes well.

Scusa!

M

@jgart Please forgive me, I've been forgetting this for ages, always taken with sox_ng. Save me some time: can you make a branch with the changes you suggest? I can see about making another release if all goes well. Scusa! M

jgart commented 2026年02月18日 07:44:30 +01:00

@martinwguy Hi, I've been pulled away to other work as well recently.

Give me another week or so and I'll take another look. Thanks for your message.

@martinwguy Hi, I've been pulled away to other work as well recently. Give me another week or so and I'll take another look. Thanks for your message.

This pull request has changes conflicting with the target branch.