2
11
Fork
You've already forked os-nvr
3

Use parts, not segments, as the watchdog activity source #312

Merged
Curid merged 3 commits from byteit101/os-nvr:master into master 2024年09月11日 19:57:12 +02:00
Contributor
Copy link

This allows the watchdog to work with low i-frame intervals. A better fix for #311

This allows the watchdog to work with low i-frame intervals. A better fix for #311
Use parts, not segments, as the watchdog activity source
Some checks failed
ci/woodpecker/pr/woodpecker Pipeline failed
ebf0c8422f
Reformat code
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
2827b63cee
Curid left a comment
Copy link

sorry, forgot to click submit on this review yesterday

sorry, forgot to click submit on this review yesterday
@ -54,7 +54,7 @@ func onInputProcessStart(ctx context.Context, i *monitor.InputProcess, _ *[]stri
}
Owner
Copy link

The defaultInterval can probably be reduced to 10 seconds now.

The `defaultInterval` can probably be reduced to 10 seconds now.
Curid marked this conversation as resolved
@ -223,6 +223,10 @@ func (m *Muxer) AudioTrack() *gortsplib.TrackMPEG4Audio {
func(m*Muxer)WaitForSegFinalized(){
m.playlist.waitForSegFinalized()
}
// WaitForPartFinalized blocks until a new segment has been finalized.
Owner
Copy link

*part

*part
Curid marked this conversation as resolved
@ -224,6 +224,11 @@ func (m *Muxer) WaitForSegFinalized() {
m.playlist.waitForSegFinalized()
}
// WaitForPartFinalized blocks until a new segment has been finalized.
Owner
Copy link

*part

*part
Curid marked this conversation as resolved
Review feedback: typo and reduce timeout for watchdog
Some checks failed
ci/woodpecker/pr/woodpecker Pipeline was successful
ci/woodpecker/pull_request_closed/woodpecker Pipeline failed
284ff8fdc5
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Curid/os-nvr!312
Reference in a new issue
Curid/os-nvr
No description provided.
Delete branch "byteit101/os-nvr:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?