• Joined on 2023年06月13日
CoderKat commented on issue Kbin/kbin-core#199 2023年06月15日 03:24:18 +02:00
Links to magazines with the exclamation mark syntax (!<magazine>@<domain>) are broken

You know what, maybe the comments are sending HTML rather than markdown? Or maybe something preprocesses something from !Utah@kbin.social to, say, [!Utah@kbin.social](/c/Utah@kbin.social)?...

CoderKat commented on issue Kbin/kbin-core#199 2023年06月15日 03:05:06 +02:00
Links to magazines with the exclamation mark syntax (!<magazine>@<domain>) are broken

Huh, that's interesting. I coincidentally noticed a different place that used this syntax with different results. This might be context dependent.

CoderKat commented on issue Kbin/kbin-core#199 2023年06月15日 02:36:07 +02:00
Links to magazines with the exclamation mark syntax (!<magazine>@<domain>) are broken

src\Markdown\CommonMark\ExternalLinkRenderer.php is likely what we're hitting. It reads right to me. The foreach (['@', '!', '#'] as $tag) ends up clearing all attributes. For the example...

CoderKat created repository CoderKat/kbin-core 2023年06月15日 01:57:37 +02:00
CoderKat opened issue Kbin/kbin-core#199 2023年06月15日 01:56:47 +02:00
Links to magazines with the exclamation mark syntax (!<magazine>@<domain>) are broken
CoderKat commented on pull request Kbin/kbin-core#75 2023年06月13日 07:26:07 +02:00
Use SQL parameters to prevent SQL injections in SearchRepository.php

Oof, noticed this coincidentally while looking for #47. This has potential to be very bad. I did a very cursory skim. There's quite a few places that aren't using proper SQL parameterization. Most...

CoderKat opened issue Kbin/kbin-core#127 2023年06月13日 05:12:51 +02:00
It should be possible to turn off notifications on a per thread/post/comment basis
CoderKat opened issue Kbin/kbin-core#126 2023年06月13日 05:09:37 +02:00
The notifications page should have the thread title on each notification
CoderKat opened issue Kbin/kbin-core#124 2023年06月13日 04:59:01 +02:00
Footer should include a link to report an issue
CoderKat opened issue Kbin/kbin-core#122 2023年06月13日 04:51:02 +02:00
Magazine names (e.g., "m/foo") should automatically linkify