WIP: Add gzip compression #302

video-prize-ranch commented 2024年03月30日 02:47:24 +01:00

Fixes #223

Responses are compressed with gzip and cached.

Fixes #223 Responses are compressed with gzip and cached.

momar commented 2024年04月02日 00:26:57 +02:00

Thank you for the contribution, I've marked it as "WIP" due to #301 breaking most of the changes, and also because I think that this will still need some discussion specifically on caching of compressed contents.

This is as of now uncovers an existing bug that's unfortunately a DoS vector, as the whole file is loaded at once into memory without a size limit, instead of streaming its contents. #301 will change quite some things that are touched in this PR, including that DoS issue, and then streamed Gzip and caching Gzip-compressed responses and thus saving CPU for often accessed resources should become a lot easier to implement.

Thank you for the contribution, I've marked it as "WIP" due to #301 breaking most of the changes, and also because I think that this will still need some discussion specifically on caching of compressed contents. This is as of now uncovers an existing bug that's unfortunately a DoS vector, as the whole file is loaded at once into memory without a size limit, instead of streaming its contents. #301 will change quite some things that are touched in this PR, including that DoS issue, and then streamed Gzip and caching Gzip-compressed responses and thus saving CPU for often accessed resources should become a lot easier to implement.

This pull request has changes conflicting with the target branch.