Codeberg/Documentation
43
151
Fork
You've already forked Documentation
129

Contributor FAQ #92

Merged
lhinderberger merged 8 commits from :contributor-faq into master 2020年10月16日 17:17:39 +02:00
Contributor
Copy link

This is my draft of the contributor FAQ for Codeberg Documentation, ready for review.

I'm looking forward to your comments and additions :)

Closes #69 #80 and possibly #52

This is my draft of the contributor FAQ for Codeberg Documentation, ready for review. I'm looking forward to your comments and additions :) Closes #69 #80 and possibly #52
Contributor
Copy link

I will try to have a look this week.
But you'll have to explain me how to add comments like you did for my PRs!

I will try to have a look this week. But you'll have to explain me how to add comments like you did for my PRs!
@ -0,0 +59,4 @@
<a name="file-naming-conventions">
### How should files be named?
Please adhere to [Kebap-Case](https://en.wikipedia.org/wiki/Letter_case#Special_case_styles) naming rules for any files in Codeberg Documentation.
Contributor
Copy link

Typo: Kebap-Case --> Kebab-Case

Typo: Kebap-Case --> Kebab-Case
Contributor
Copy link

Also might want to change the link to https://en.wikipedia.org/wiki/Kebab_case in case it gets its own article in the future.

Also might want to change the link to https://en.wikipedia.org/wiki/Kebab_case in case it gets its own article in the future.
Author
Contributor
Copy link

Thanks, good catch! I fixed it :)

Thanks, good catch! I fixed it :)
lhinderberger marked this conversation as resolved
@ -0,0 +77,4 @@
and PNG formats (webP and JPEG for photographs), they should be in a large enough resolution so that text is clearly
readable and their filenames should follow Codeberg Documentation's [naming conventions](#file-naming-conventions).
Please put screenshots under `assets/images/[section]/[article]/...` where `[section]` and `[article]` are the kebap-cased names of the section or your article, respectively.
Contributor
Copy link

Same here (kebab-case).

Same here (kebab-case).
lhinderberger marked this conversation as resolved
Contributor
Copy link

Perhaps screenshot requests for occasional contributors could also be documented as part of #75.

Edit: and Knut too :)

Perhaps screenshot requests for occasional contributors could also be documented as part of #75. Edit: and Knut too :)
Author
Contributor
Copy link

@n - Will do, as soon as #75 is ready 😉

Depending on how quick #75 can be resolved, it might be worth putting that change in another PR though.

@n - Will do, as soon as #75 is ready :wink: Depending on how quick #75 can be resolved, it might be worth putting that change in another PR though.
ivan-paleo left a comment
Contributor
Copy link

Great article; I have only few very minor comments!

Great article; I have only few very minor comments!
@ -0,0 +13,4 @@
To contribute to Codeberg Documentation, the first thing you should do (if you haven't already done it) is to create your own fork of the [Codeberg/Documentation repository](https://codeberg.org/Codeberg/Documentation).
Then, for each major contribution that you want to make (e.g. for each new article), create a new branch, make your contributions and finally make a Pull Request to the Codeberg/Documentation repository. You can find the source code to all articles in the `content` directory of Codeberg
Documentation's source tree.
Contributor
Copy link

Is there a line break here (there shouldn't be one)?

Is there a line break here (there shouldn't be one)?
Author
Contributor
Copy link

Where exactly do you mean?

Where exactly do you mean?
Contributor
Copy link

between "Codeberg" and "Documentation" (lines 15-16)

between "Codeberg" and "Documentation" (lines 15-16)
Author
Contributor
Copy link

Good catch! I fixed it. By the way, simple line breaks like these have no effect on Markdown rendering, as far as I can tell. So that's why it was easy to miss.

Good catch! I fixed it. By the way, simple line breaks like these have no effect on Markdown rendering, as far as I can tell. So that's why it was easy to miss.
lhinderberger marked this conversation as resolved
@ -0,0 +42,4 @@
Every section and article has a unique `key`. If `parent` is set to the `key` of another section, the current article will become a child of that other section.
The other fields are `title` and `order`, where `title` is merely a display name and determines the menu entry label as well as the article's heading but has no other "technical" semantics and `order` is a number that can be used to enforce a specific order of articles (which is good for step-by-step guides such as Getting Started for example).
Contributor
Copy link

That sentence is very long. I suggest to split it into two or even three sentences.

That sentence is very long. I suggest to split it into two or even three sentences.
Author
Contributor
Copy link

I've now split it up into a list.

I've now split it up into a list.
lhinderberger marked this conversation as resolved
@ -0,0 +51,4 @@
> Please do not repeat the article's title as a first-level heading in Markdown. It will added automatically when generating the final site.
### Can I preview my article?
Yes, but currently only if you're working with a local clone of the repository. In that case, simply follow the instructions in the `README.md` file to set up and run a local preview.
Contributor
Copy link

Would it make sense to add a link to the README.md file?

Would it make sense to add a link to the README.md file?
Author
Contributor
Copy link

Yes :) -> Done

Yes :) -> Done
lhinderberger marked this conversation as resolved
Author
Contributor
Copy link

Thank you @ivan-paleo for your comments - I have modified everything accordingly!

What do you all think, are we ready to merge? :)

Thank you @ivan-paleo for your comments - I have modified everything accordingly! What do you all think, are we ready to merge? :)
lhinderberger changed title from (削除) Contributor FAQ (削除ここまで) to WIP: Contributor FAQ 2020年10月11日 13:18:11 +02:00
lhinderberger changed title from (削除) WIP: Contributor FAQ (削除ここまで) to Contributor FAQ 2020年10月11日 13:51:28 +02:00
Author
Contributor
Copy link

Okay, I've added instructions about example repositories and screenshots using the "knut" account/organization. Please have a look if everything's correct and feel free to merge :)

Okay, I've added instructions about example repositories and screenshots using the "knut" account/organization. Please have a look if everything's correct and feel free to merge :)
Contributor
Copy link

Okay, I've added instructions about example repositories and screenshots using the "knut" account/organization. Please have a look if everything's correct and feel free to merge :)

It looks all good to me.

> Okay, I've added instructions about example repositories and screenshots using the "knut" account/organization. Please have a look if everything's correct and feel free to merge :) It looks all good to me.
Author
Contributor
Copy link

Hey @n, are the "knut" instructions okay and can this be merged? :)

Hey @n, are the "knut" instructions okay and can this be merged? :)
n left a comment
Contributor
Copy link

Looks good to me except for a small error :)

Looks good to me except for a small error :)
@ -0,0 +72,4 @@
- For changes that are critical, e.g. ones that might legally affect Codeberg e.V., the chairperson of Codeberg e.V. will need to approve of the changes as well
### Where to create example repositories?
Please create example repositories for the Documentation in the `knut` organization on `codeberg-test.org`.
Contributor
Copy link

This should be on Codeberg production, right?

This should be on Codeberg production, right?
Author
Contributor
Copy link

Absolutely right! Thanks for spotting this 👍

Absolutely right! Thanks for spotting this 👍
lhinderberger marked this conversation as resolved
Author
Contributor
Copy link

With the last error resolved, this is now ready to merge, which I will do right away, along with #82 :)

With the last error resolved, this is now ready to merge, which I will do right away, along with #82 :)
lhinderberger deleted branch contributor-faq 2020年10月16日 17:17:49 +02:00
n approved these changes 2020年10月16日 18:55:36 +02:00
Sign in to join this conversation.
No reviewers
n
Labels
Clear labels
Codeberg Pages

Issues affecting Codeberg Pages
Documentation Usability

Issues related to using and reading docs.codeberg.org
Forgejo
Good First Issue! 👋
Kind: Bug
Kind: Documentation
Kind: Enhancement
Kind: Feature
Kind: Question
Kind: Security
Licensing
Part: Generator

This is related to the generation of the documentation, not to the content itself
Priority: High

The priority is high
Priority: Low

The priority is low
Priority: Medium

The priority is medium
Reviewed: Confirmed

Something has been confirmed
Reviewed: Duplicate

Something exists already
Reviewed: Invalid

Something was marked as invalid
Reviewed: Wontfix

Something won't be fixed
Status: Blocked
Status: Help wanted

Contributions are welcome!
Status: In progress

Work is in progress
Status: Needs feedback

Feedback is needed
Status: Ready for Review

Work is completed
Status: Review

Review is in progress / Reviewers wanted
Status: Stale
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Codeberg/Documentation!92
Reference in a new issue
Codeberg/Documentation
No description provided.
Delete branch ":contributor-faq"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?