Codeberg/Design
Archived
23
51
Fork
You've already forked Design
4

LibreJS compliance (#33) #35

Merged
momar merged 5 commits from librejs into master 2021年07月29日 20:51:16 +02:00
Collaborator
Copy link

This PR adds LibreJS compliance to Codeberg Design.

  • For design-kit, I updated build.js
  • For components, I update the package.json to add the identifiers after building.
This PR adds LibreJS compliance to Codeberg Design. - For design-kit, I updated build.js - For components, I update the package.json to add the identifiers after building.
n requested review from momar 2021年07月26日 09:43:36 +02:00
@ -54,2 +55,4 @@
let codebergJS = halfmoonLicenseStart + fs.readFileSync(path.join(__dirname, "node_modules/halfmoon/js/halfmoon.min.js")).toString() + LicenseEnd + "\n\n";
for (const f of fs.readdirSync(path.join(__dirname, "script")).sort()) {
codebergCSS += "/* Codeberg Design: " + f + " */\n" + fs.readFileSync(path.join(__dirname, "script", f)) + "\n";

Can we use the sed command from above as JavaScript here arounjd the for loop instead? Also, this needs to be codebergJS here, that was a mistake by myself, if you're at it this can be fixed as well.

Can we use the `sed` command from above as JavaScript here arounjd the for loop instead? Also, this needs to be `codebergJS` here, that was a mistake by myself, if you're at it this can be fixed as well.
Author
Collaborator

Can we use the sed command from above as JavaScript here arounjd the for loop instead?

I used the sed command in the for codeberg-components.js. I didn't see any build script in it's directory where I could add the identifier, but maybe you could point me to where I should.

Also, this needs to be codebergJS here, that was a mistake by myself, if you're at it this can be fixed as well.

Fixed!

> Can we use the sed command from above as JavaScript here arounjd the for loop instead? I used the `sed` command in the for `codeberg-components.js`. I didn't see any build script in it's directory where I could add the identifier, but maybe you could point me to where I should. > Also, this needs to be codebergJS here, that was a mistake by myself, if you're at it this can be fixed as well. Fixed!
Owner
Copy link

Thank you! I'd prefer to not have bash commands for stuff that can be easily done in JS here, but looks good other than that.

Thank you! I'd prefer to not have bash commands for stuff that can be easily done in JS here, but looks good other than that.
Author
Collaborator
Copy link

@momar I also added the CC0 identifier to design-kit in 38e040777a, so I hope that's all good on review.

@momar I also added the CC0 identifier to design-kit in 38e040777a, so I hope that's all good on review.
Owner
Copy link

Alright, I hate package-lock.json files - I've regenerated them completely as I can't possibly review them, so this is approved now.

Alright, I hate package-lock.json files - I've regenerated them completely as I can't possibly review them, so this is approved now.
n deleted branch librejs 2021年07月30日 06:55:46 +02:00
Commenting is not possible because the repository is archived.
No reviewers
Labels
Clear labels
Kind: Breaking
Kind: Bug
Kind: Documentation
Kind: Enhancement
Kind: Feature
Kind: Maintenance
Kind: Public Relations

Design relevant outside of Codeberg
Kind: Question
Kind: Security
Kind: Testing
Kind: Web Design
Part: Color Palette
Part: Design Kit

Codeberg Design Kit
Part: Fonts
Part: Logo
Part: Navbar

Codeberg's navigation bar
Part: Themes

Gitea themes
Priority: Critical

The priority is critical
Priority: High

The priority is high
Priority: Low

The priority is low
Priority: Medium

The priority is medium
Reviewed: Confirmed

Something has been confirmed
Reviewed: Duplicate

Something exists already
Reviewed: Invalid

Something was marked as invalid
Reviewed: Wontfix

Something won't be fixed
Status: Blocked
Status: Completed

Work is complete
Status: Help wanted
Status: In progress

Work is in progress
Status: Needs feedback

Feedback is needed
Status: Stale
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
Codeberg/Design!35
Reference in a new issue
Codeberg/Design
No description provided.
Delete branch "librejs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?