Codeberg/Community
54
325
Fork
You've already forked Community
12

Improving mail translation templates #163

Closed
opened 2020年03月26日 21:53:41 +01:00 by fnetX · 5 comments
Owner
Copy link

Hey everyone,

the verification mail lacks translation. Some parts of it are in German.

Subject: (削除) Bestätige deine E-Mail-Adresse (削除ここまで)

Message:

Hi fnetX,

Please click the following link to verify your email address within (削除) 3 Stunden (削除ここまで):

https://codeberg.org/user/activate_email?code=foo&email=bar

Not working? Try copying and pasting it to your browser.

Welcome to Codeberg.org!

Hey everyone, the verification mail lacks translation. Some parts of it are in German. Subject: ~~Bestätige deine E-Mail-Adresse~~ Message: > Hi fnetX, > > Please click the following link to verify your email address within ~~3 Stunden~~: > > https://codeberg.org/user/activate_email?code=foo&email=bar > > Not working? Try copying and pasting it to your browser. > > Welcome to Codeberg.org! >
Author
Owner
Copy link

... or is it actually translated but the rest of it lives in the custom (untranslated) email template?

That's what I assume when I look at https://codeberg.org/Codeberg/build-deploy-gitea/src/branch/master/local_patches/template_changes.diff but nevertheless this behaviour seems quite strange ...

Update: Okay, excuse the mess ... indeed, it's correctly translated into German but rest of the mail template is not. I'm okay with that, but I'll leave this issue open for discussion. May be someone wants to make the necessary changes in order to have a full translation?

... or is it actually translated but the rest of it lives in the custom (untranslated) email template? That's what I assume when I look at https://codeberg.org/Codeberg/build-deploy-gitea/src/branch/master/local_patches/template_changes.diff but nevertheless this behaviour seems quite strange ... Update: Okay, excuse the mess ... indeed, it's *correctly* translated into German but rest of the mail template is not. I'm okay with that, but I'll leave this issue open for discussion. May be someone wants to make the necessary changes in order to have a full translation?
Member
Copy link

Good catch, thank you! Pull request to templates welcome!

Good catch, thank you! Pull request to templates welcome!
Author
Owner
Copy link

I can't exactly see how to translate those complete templates ... I think separating the part before and after the variables would only cause some issues with certain languages where syntax is different, right?

I can't exactly see how to translate those complete templates ... I think separating the part before and after the variables would only cause some issues with certain languages where syntax is different, right?
Member
Copy link

mh, yes, probably

mh, yes, probably
fnetX changed title from (削除) Missing translation on mail verification (削除ここまで) to Improving mail translation templates 2021年02月26日 09:03:52 +01:00

should be fixed - feel free to reopen if not

should be fixed - feel free to reopen if not
Sign in to join this conversation.
No Branch/Tag specified
main
No results found.
Labels
Clear labels
accessibility

Reduces accessibility and is thus a "bug" for certain user groups on Codeberg.
bug

Something is not working the way it should. Does not concern outages.
bug
infrastructure

Errors evidently caused by infrastructure malfunctions or outages
Codeberg

This issue involves Codeberg's downstream modifications and settings and/or Codeberg's structures.
contributions welcome

Please join the discussion and consider contributing a PR!
docs

No bug, but an improvement to the docs or UI description will help
duplicate

This issue or pull request already exists
enhancement

New feature
infrastructure

Involves changes to the server setups, use `bug/infrastructure` for infrastructure-related user errors.
legal

An issue directly involving legal compliance
licence / ToS

involving questions about the ToS, especially licencing compliance
please chill
we are volunteers

Please consider editing your posts and remember that there is a human on the other side. We get that you are frustrated, but it's harder for us to help you this way.
public relations

Things related to Codeberg's external communication
question

More information is needed
question
user support

This issue contains a clearly stated problem. However, it is not clear whether we have to fix anything on Codeberg's end, but we're helping them fix it and/or find the cause.
s/Forgejo

Related to Forgejo. Please also check Forgejo's issue tracker.
s/Forgejo/migration

Migration related issues in Forgejo
s/Pages

Issues related to the Codeberg Pages feature
s/Weblate

Issue is related to the Weblate instance at https://translate.codeberg.org
s/Woodpecker

Woodpecker CI related issue
security

involves improvements to the sites security
service

Add a new service to the Codeberg ecosystem (instead of implementing into Gitea)
upstream

An open issue or pull request to an upstream repository to fix this issue (partially or completely) exists (i.e. Gitea, Forgejo, etc.)
wontfix

Codeberg's current set of contributors are not planning to spend time on delegating this issue.
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Depends on
Reference
Codeberg/Community#163
Reference in a new issue
Codeberg/Community
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?