Clickin on pull request cause 500 internal server error #1517

notanamber commented 2024年03月26日 09:07:37 +01:00

Comment

Hello,

when i click on the pull request in my repository i receive an internal server error.
The page can be found at

https://codeberg.org/notanamber/nerd_tree/pulls

The specific link is this:

notanamber/nerd_tree#2

Have a good work

### Comment Hello, when i click on the pull request in my repository i receive an internal server error. The page can be found at https://codeberg.org/notanamber/nerd_tree/pulls The specific link is this: https://codeberg.org/notanamber/nerd_tree/pulls/2 Have a good work

glts commented 2024年03月26日 10:25:42 +01:00

If it is a migrated pull request, might be the same as this: #1472.

If it is a migrated pull request, might be the same as this: #1472.

notanamber commented 2024年03月26日 11:39:07 +01:00

Hello,

the pull request was made directly on codeberg, but the repository is a mirror of another gitea repository.
Maybe is this the problem?

Thanks

Hello, the pull request was made directly on codeberg, but the repository is a mirror of another gitea repository. Maybe is this the problem? Thanks

n0toose commented 2024年03月26日 13:00:09 +01:00

: the pull request was made directly on codeberg, but the repository is a mirror of another gitea repository.

Hi, "another Gitea repository"? How are you mirroring the repository?

: the pull request was made directly on codeberg, but the repository is a mirror of another gitea repository. Hi, "another Gitea repository"? How are you mirroring the repository?

fnetX commented 2024年03月26日 14:01:17 +01:00

GetRefCommitID, object does not exist [id: refs/pull/2/head, rel_path: ]

the typical thing, this started to happen quite often from my subjective perspective.

~~~ GetRefCommitID, object does not exist [id: refs/pull/2/head, rel_path: ] ~~~ the typical thing, this started to happen quite often from my subjective perspective.

Gusted commented 2024年03月26日 17:08:41 +01:00

I strangely cannot find how this pull request was made. The expected web route and api route come up empty handed in the logs. I've fixed the issue manually for the time being, nothing points to anything abnormal (database models of this PR looks correct and nothing seems to have been done to this PR) other than the origin of the creation of this PR cannot be found, at least by me.

I strangely cannot find how this pull request was made. The expected web route and api route come up empty handed in the logs. I've fixed the issue manually for the time being, nothing points to anything abnormal (database models of this PR looks correct and nothing seems to have been done to this PR) other than the origin of the creation of this PR cannot be found, at least by me.

fnetX commented 2024年03月26日 18:54:28 +01:00

@crystal recently said:

When I had that problem it was caused by another instance push mirroring to Codeberg. I removed the push mirror and made a CI pipeline push all the refs and tags from the source repo instead. The push mirror uses the --mirror option in git, which is bad because it deletes refs that exist in the target repo and not in the source repo. This obviously includes the refs that keep track of PR HEADs

I believe this is related?!

the repository is a mirror of another gitea repository.
Maybe is this the problem?

I think it is. However, mirrors are a common feature and should probably not break our repos? How can we approach this problem?

@crystal recently said: > When I had that problem it was caused by another instance push mirroring to Codeberg. I removed the push mirror and made a CI pipeline push all the refs and tags from the source repo instead. The push mirror uses the --mirror option in git, which is bad because it deletes refs that exist in the target repo and not in the source repo. This obviously includes the refs that keep track of PR HEADs I believe this is related?! > the repository is a mirror of another gitea repository. Maybe is this the problem? I think it is. However, mirrors are a common feature and should probably **not** break our repos? How can we approach this problem?

Gusted commented 2024年03月26日 20:49:40 +01:00

It seems to be related as notanamber/nerd_tree#2 is once again resulting in 500 error.

It seems to be related as https://codeberg.org/notanamber/nerd_tree/pulls/2 is once again resulting in 500 error.

fnetX commented 2024年03月26日 22:46:31 +01:00

@notanamber We would like to better understand your use case of mirroring into a repository that accepts pull request. Obviously, you cannot merge the pull requests anyway, because the mirror would overwrite the changes. Modifying a mirror does not really work, because it obviously assumes the other side to be the source of truth.

How is your workflow with regards to these pull requests?

@notanamber We would like to better understand your use case of mirroring into a repository that accepts pull request. Obviously, you cannot merge the pull requests anyway, because the mirror would overwrite the changes. Modifying a mirror does not really work, because it obviously assumes the other side to be the source of truth. How is your workflow with regards to these pull requests?

notanamber commented 2024年03月27日 10:33:48 +01:00

@notanamber We would like to better understand your use case of mirroring into a repository that accepts pull request. Obviously, you cannot merge the pull requests anyway, because the mirror would overwrite the changes. Modifying a mirror does not really work, because it obviously assumes the other side to be the source of truth.

How is your workflow with regards to these pull requests?

The primary repository is here:

https://gitea.it/notanamber/nerd_tree

i setup a token here with all permission and the i setup the options for the mirroring, i attach my panel.
As I told you the pull request coming from codeberg repository.

In your opinion do it is better to remove the repository at gitea.it and use directly those in codeberg?
Thanks

> @notanamber We would like to better understand your use case of mirroring into a repository that accepts pull request. Obviously, you cannot merge the pull requests anyway, because the mirror would overwrite the changes. Modifying a mirror does not really work, because it obviously assumes the other side to be the source of truth. > > How is your workflow with regards to these pull requests? The primary repository is here: https://gitea.it/notanamber/nerd_tree i setup a token here with all permission and the i setup the options for the mirroring, i attach my panel. As I told you the pull request coming from codeberg repository. In your opinion do it is better to remove the repository at gitea.it and use directly those in codeberg? Thanks

fnetX commented 2024年03月27日 13:34:34 +01:00

This depends on your usecase. What will you do if there was a pull request here on Codeberg (assuming it wouldn't break). Would you merge it? Because in this case, the next mirror run from gitea.it would undo the change again.

I think mirrors are only used for one-directional syncing. You have "one source of truth", and you cannot do modifications in the other places unfortunately.

This depends on your usecase. What will you do if there was a pull request here on Codeberg (assuming it wouldn't break). Would you merge it? Because in this case, the next mirror run from gitea.it would undo the change again. I think mirrors are only used for one-directional syncing. You have "one source of truth", and you cannot do modifications in the other places unfortunately.

notanamber commented 2024年03月28日 09:23:53 +01:00

In the meantime, thank you for your explanations, I think I understand the problem.
I would like to merge only pull requests from codeberg and make the repository on codeberg the primary one.

Do you know if it is possible to make the repository on codeberg independent of the one on gitea.it?
Have a good day

In the meantime, thank you for your explanations, I think I understand the problem. I would like to merge only pull requests from codeberg and make the repository on codeberg the primary one. Do you know if it is possible to make the repository on codeberg independent of the one on gitea.it? Have a good day

fnetX commented 2024年03月28日 12:34:54 +01:00

I think you don't have to do anything on Codeberg's side, but you have to stop the mirror on gitea.it (or remove the credentials on Codeberg if you don't have access to it for some reason). I think this should be enough.

We are trying to think about a solution for accidentally overwriting the pull request information, though.

I think you don't have to do anything on Codeberg's side, but you have to stop the mirror on gitea.it (or remove the credentials on Codeberg if you don't have access to it for some reason). I think this should be enough. We are trying to think about a solution for accidentally overwriting the pull request information, though.

notanamber commented 2024年03月28日 13:47:25 +01:00

Thanks for the help, i will try it

Thanks for the help, i will try it

mro commented 2024年06月18日 15:02:50 +02:00

I have the same usecase.

May I elaborate on the motivation? I want https://indieweb.org/POSSE and welcome 3rd party contributions at the same time. I am aware that I have to merge the pull request into the mirror source.

The pull request page 500ing makes this harder.

I have the same usecase. May I elaborate on the motivation? I want https://indieweb.org/POSSE and welcome 3rd party contributions at the same time. I am aware that I have to merge the pull request into the mirror source. The pull request page 500ing makes this harder.