500 error when accessing pull request migrated from GitLab #1472

glts commented 2024年02月06日 08:58:03 +01:00

Comment

I’ve just tried to migrate a repository from GitLab, but get a 500 error when I try to view the one migrated pull request.

https://codeberg.org/glts/indymilterbroken/pulls/ – shows the one PR

glts/indymilterbroken#1 – 500 error

There does not seem to be anything unusual about the original pull request.

Is there a way for me to fix this on my end? Can you help me fix it? Thank you.

### Comment I’ve just tried to migrate a repository from GitLab, but get a 500 error when I try to view the one migrated pull request. https://codeberg.org/glts/indymilterbroken/pulls/ – shows the one PR https://codeberg.org/glts/indymilterbroken/pulls/1 – 500 error There does not seem to be anything unusual about the [original pull request](https://gitlab.com/glts/indymilter/-/merge_requests/1). Is there a way for me to fix this on my end? Can you help me fix it? Thank you.

fnetX commented 2024年02月06日 18:39:52 +01:00

GetRefCommitID, object does not exist [id: refs/pull/1/head, rel_path: ]

~~~ GetRefCommitID, object does not exist [id: refs/pull/1/head, rel_path: ] ~~~

Gusted commented 2024年02月12日 22:15:06 +01:00

Okay I was able to reproduce this locally. I'm not sure how to fix this yet (or what went wrong), but it boils down that when Forgejo clones the repository, it doesn't contain the PR's commit (as seen here) and therefor Forgejo is not able to point the refs/pull/1/head to any commit that is associated with the pull request. It's not a transient error and not really anything that can be fixed on your end for the time being, other than migrating the repository again but without migrating the merge requests.

Okay I was able to reproduce this locally. I'm not sure how to fix this yet (or what went wrong), but it boils down that when Forgejo clones the repository, it doesn't contain the [PR's commit](https://gitlab.com/glts/indymilter/-/commit/16bbe5cb42b26af74897f166c6ddb45be3fce110) (as [seen here](https://codeberg.org/glts/indymilterbroken/commit/16bbe5cb42b26af74897f166c6ddb45be3fce110)) and therefor Forgejo is not able to point the `refs/pull/1/head` to any commit that is associated with the pull request. It's not a transient error and not really anything that can be fixed on your end for the time being, other than migrating the repository again but without migrating the merge requests.

Gusted commented 2024年02月12日 23:07:11 +01:00

Okay this is confusing, I was able to figure out why Forgejo wasn't fetching the references. Forgejo doesn't receive enough information by the Gitlab API to fill in the details about the head and base repository.

CloneURL is incorrect, as WebURL in this case is https://gitlab.com/glts/indymilter/-/merge_requests/1 but the clone URL should be https://gitlab.com/daviessm/indymilter.git (but we don't know what the repository is of the PR). RepoName of Head is set to the repository name of where the PR is made against, not where it's from. OwnerName of Base is set to the author of the PR and not the owner of the repository where the PR is made against. Which leads to the issue that Forgejo cannot figure out if this PR is from a forked repository (in both cases the string is daviessm/indymilter) and if this was fixed, the CloneURL is still incorrect. Also for some reason the references of closed PRs aren't gathered which is an issue that also should be fixed. I wasn't able to confirm this, but it seems like the reference fetching itself also needs to be adjusted as Gitlab doesn't follow what Github does (for Github this works correctly).

Okay this is confusing, I was able to figure out why Forgejo wasn't fetching the references. Forgejo doesn't receive enough information by [the Gitlab API](https://docs.gitlab.com/ee/api/merge_requests.html#get-single-mr) to fill in the details about [the head and base repository](https://codeberg.org/forgejo/forgejo/src/commit/c6a89b490d93c776996c3318f911baa027f274fc/services/migrations/gitlab.go#L646-L658). `CloneURL` is incorrect, as `WebURL` in this case is `https://gitlab.com/glts/indymilter/-/merge_requests/1` but the clone URL should be `https://gitlab.com/daviessm/indymilter.git` (but we don't know what the repository is of the PR). `RepoName` of `Head` is set to the repository name of where the PR is made against, not where it's from. `OwnerName` of `Base` is set to the author of the PR and not the owner of the repository where the PR is made against. Which leads to the issue that Forgejo cannot figure out if this PR is [from a forked repository](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/modules/migration/pullrequest.go#L46-L49) (in both cases the string is `daviessm/indymilter`) and if this was fixed, the `CloneURL` is still incorrect. Also for some reason the references of [closed PRs aren't gathered](https://codeberg.org/forgejo/forgejo/src/commit/c6a89b490d93c776996c3318f911baa027f274fc/services/migrations/gitea_uploader.go#L586) which is an issue that also should be fixed. I wasn't able to confirm this, but it seems like the [reference fetching itself](https://codeberg.org/forgejo/forgejo/src/commit/c6a89b490d93c776996c3318f911baa027f274fc/services/migrations/gitea_uploader.go#L639-L642) also needs to be adjusted as Gitlab doesn't follow what Github does (for Github this works correctly).