:McTom234_renovate-landingpage into codeberg-1.17 Fresh design for the landing/about page.
Includes responsive behavior for all display sizes.
(削除) Misses some icons and a background-image. (削除ここまで)
should we wait to rebase this pull onto codeberg-1.17 ?
e283686bfe
to 8950c5212b
PR is rebased onto codeberg-1.17
8950c5212b
to 6cbc37a4a6
What is the name of the mountain you used?
What is the name of the mountain you used?
Ask @mray
What is the name of the mountain you used?
"Mount Shasta" CA, USA
diff --git a/webpack.config.js b/webpack.config.js
index bc16f18b7..76117c76e 100644
--- a/webpack.config.js
+++ b/webpack.config.js
@@ -54,7 +54,7 @@ export default {
fileURLToPath(new URL('web_src/less/index.less', import.meta.url)),
],
homepage: [
- resolve(__dirname, 'web_src/less/homepage.less')
+ fileURLToPath(new URL('web_src/less/homepage.less', import.meta.url)),
],
swagger: [
fileURLToPath(new URL('web_src/js/standalone/swagger.js', import.meta.url)),
?
@ -25,1 +46,4 @@
</div>
<div class="header-background-image"
style="background-image: url('../public/img/svg/codeberg-landingpage-mountain-background-crop.svg')"
- style="background-image: url('../public/img/svg/codeberg-landingpage-mountain-background-crop.svg')"
+ style="background-image: url('../assets/img/svg/codeberg-landingpage-mountain-background-crop.svg')"
Please also apply to the other URLs.
Are you looking for some feedback on the language/grammar used? I can see some spots where it could be better/minor errors, but don't know if it's placeholders for now or not.
@CapableWeb I just pushed the commits that were intended to fix links and we revisited the texts. Please re-check now, feedback is very welcome.
@ -26,0 +59,4 @@
<div>
<h3>NON-PROFIT</h3>
<p>
Codeberg is not run by a company, but in the hands of their users – via the non-profit organization Codeberg
but in the hands of their users
Probably want it to be:
but in the hands of its users
@fnetX seems all/most issues I spotted before already been fixed :) Excited to see a new landing page 🎉
Fixes #20080
The code introduced by #18185 gets the error from response after it was processed by goth. That is incorrect, as goth (and golang.org/x/oauth) doesn't really care about the error, and it sends a token request with an empty authorization code to the server anyway, which always results in a `oauth2: cannot fetch token: 400 Bad Request` error from goth. It means that unless the "state" parameter is omitted from the error response (which is required to be present, according to [RFC 6749, Section 4.1.2.1](https://datatracker.ietf.org/doc/html/rfc6749#section-4.1.2.1)) or the page is reloaded (makes the session invalid), a 500 Internal Server Error page will be displayed. This fixes it by handling the error before the request is passed to goth.
Backport #20127 Store the file uuid(which is returned by Gitea in the upload file response) onto the file object, so it can be used for the remove feature to specify this file. Fix #20115
- Backport #20142 - Firefox on Windows will unconditionally show scrollbars when you specify `overflow: scroll`. This is bad behavior, as you don't always need the scrollbar. Changing the scroll value to auto fixes this issue and only shows the scrollbar when necessary. - Resolves #20139
lgtm from my side :)
through I will wait for the once who are in care of this pull ;)
@ -37,0 +87,4 @@
<div class="home-section-about-title">
<p>PROJECTS</p>
<p>USERS</p>
<p>MEMBERS</p>
For the normal user the meaning of user and member is almost the same. I think it should be specified that it means the amount of members that codeberg e.v. has.
e.V. Member?
Backing Members?
Legal Members?
Or show some tooltip on hover, maybe with some ?-icon?
e.V. Member?
Indicates it's a member of the non-profit.
Backing Members?
Codeberg is a kickstarter huh?
Legal Members?
Very vague.
For reference the design issues regarding the landing page can be found here: https://codeberg.org/Codeberg/Design/issues?q=&type=all&state=open&labels=6013&milestone=0&assignee=0
This is good to go online in my eyes now.
No due date set.
No dependencies set.
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?