30
201
Fork
You've already forked forgejo
40

fix(ui): Remove invalid download count tracker from package view #144

Closed
sarge wants to merge 1 commit from sarge/forgejo:hide-incorrect-package-download-count into codeberg-15
pull from: sarge/forgejo:hide-incorrect-package-download-count
merge into: Codeberg-Infrastructure:codeberg-15
Codeberg-Infrastructure:codeberg-15
Codeberg-Infrastructure:codeberg-16
Codeberg-Infrastructure:codeberg-14
Codeberg-Infrastructure:codeberg-13-moderation
Codeberg-Infrastructure:codeberg-13
Codeberg-Infrastructure:codeberg-12
Codeberg-Infrastructure:codeberg-11
Codeberg-Infrastructure:codeberg-12-moderation
Codeberg-Infrastructure:codeberg-10
Codeberg-Infrastructure:codeberg-9
Codeberg-Infrastructure:codeberg-8
Codeberg-Infrastructure:codeberg-7
Codeberg-Infrastructure:codeberg-7-sha256-speedup
Codeberg-Infrastructure:codeberg-1.21
Codeberg-Infrastructure:codeberg-7-non-org-users
Codeberg-Infrastructure:codeberg-1.20
Codeberg-Infrastructure:codeberg-1.19
Codeberg-Infrastructure:testing-1.19
Codeberg-Infrastructure:codeberg-1.18
First-time contributor
Copy link

The reported download counts for packages are not representative due to downloads being served by cache or other server. Hide from view.

Checklist

The contributor guide contains information that will be helpful to first time contributors. All work and communication must conform to Forgejo's AI Agreement. There also are a few conditions for merging Pull Requests in Forgejo repositories. You are also welcome to join the Forgejo development chatroom.

Documentation

  • I created a pull request to the documentation to explain to Forgejo users how to use this change.
  • I did not document these changes and I do not expect someone else to do it.

Release notes

  • This change will be noticed by a Forgejo user or admin (feature, bug fix, performance, etc.). I suggest to include a release note for this change.
  • This change is not visible to a Forgejo user or admin (refactor, dependency upgrade, etc.). I think there is no need to add a release note for this change.
The reported download counts for packages are not representative due to downloads being served by cache or other server. Hide from view. ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. All work and communication must conform to Forgejo's [AI Agreement](https://codeberg.org/forgejo/governance/src/branch/main/AIAgreement.md). There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [x] This change will be noticed by a Forgejo user or admin (feature, bug fix, performance, etc.). I suggest to include a release note for this change. - [ ] This change is not visible to a Forgejo user or admin (refactor, dependency upgrade, etc.). I think there is no need to add a release note for this change.
sarge changed title from (削除) ui: Remove invalid download count tracker from package view (削除ここまで) to fix(ui): Remove invalid download count tracker from package view 2026年06月18日 00:12:29 +02:00

Hi, Sorry but this lacks a lot of context. Could you explain the issue you're facing?

Hi, Sorry but this lacks a lot of context. Could you explain the issue you're facing?
Contributor
Copy link

Pretty sure the context is low download counters in packages like this.

I can say that other packages can even have too high download counts due to weird ways automated deployments work and crawlers. But it should be up to user to take them into consideration or disregard.

Some creators publish videos on multiple platforms. Does this mean that YouTube should hide view counters site-wide?

Pretty sure the context is low download counters in [packages like this](https://codeberg.org/konform-browser/-/packages/alpine/konform-browser/140.12.0_p101-r1). I can say that [other packages](https://codeberg.org/forgejo/-/packages/container/forgejo/15.0.2-rootless) can even have too high download counts due to weird ways automated deployments work and crawlers. But it should be up to user to take them into consideration or disregard. Some creators publish videos on multiple platforms. Does this mean that YouTube should hide view counters site-wide?
Author
First-time contributor
Copy link

That's where I noticed it, yes.

For example, have downloaded https://codeberg.org/konform-browser/-/packages/debian/konform-browser/140.12.0esr-101 on three machines but days later the counter is still at 0. This makes for poor UX and might cause confusion like "did I actually get the download I intended?"

In the example I would assume the optics also act to deter potential users and contributors ("0 downloads? not even tested?") and discourage developers ("literally nobody downloads this, is there any point?").

What value is having this element visible currently providing?

Does this mean that YouTube should hide view counters site-wide?

Just to be clear, with "cache" I am referring to internal Codeberg infra and not external mirrors etc. Not sure how Youtube view counters are relevant here and besides I don't think it's a healthy reference for Codeberg UX...

That's where I noticed it, yes. For example, have downloaded https://codeberg.org/konform-browser/-/packages/debian/konform-browser/140.12.0esr-101 on three machines but days later the counter is still at `0`. This makes for poor UX and might cause confusion like "did I actually get the download I intended?" In the example I would assume the optics also act to deter potential users and contributors ("0 downloads? not even tested?") and discourage developers ("literally nobody downloads this, is there any point?"). What value is having this element visible currently providing? > Does this mean that YouTube should hide view counters site-wide? Just to be clear, with "cache" I am referring to internal Codeberg infra and not external mirrors etc. Not sure how Youtube view counters are relevant here and besides I don't think it's a healthy reference for Codeberg UX...
Contributor
Copy link

It seems to be a bug if counters do not increase and it should be fixed instead in Forgejo. Maybe it's specific to alpine packages?

About too high counters I don't care. A download is a download if it comes from CI or whatever. Of course, it is not the number of users.

It seems to be a bug if counters do not increase and it should be fixed instead in Forgejo. Maybe it's specific to alpine packages? About too high counters I don't care. A download is a download if it comes from CI or whatever. Of course, it is not the number of users.
Author
First-time contributor
Copy link

I can say that other packages can even have too high download counts due to weird ways automated deployments work and crawlers.

Haven't looked into it but I wouldn't be surprised if in particular the Container package type could also overcount due to how some clients schedule their HTTP requests.

It seems to be a bug if counters do not increase and it should be fixed instead in Forgejo. Maybe it's specific to alpine packages?

The example I linked is debian. The assumption here is that Forgejo is working as it should but these requests simply never reach the Codeberg Forgejo instance and are being served from some other internal resource.

> I can say that other packages can even have too high download counts due to weird ways automated deployments work and crawlers. Haven't looked into it but I wouldn't be surprised if in particular the `Container` package type could also overcount due to how some clients schedule their HTTP requests. > It seems to be a bug if counters do not increase and it should be fixed instead in Forgejo. Maybe it's specific to alpine packages? The example I linked is debian. The assumption here is that Forgejo is working as it should but these requests simply never reach the Codeberg Forgejo instance and are being served from some other internal resource.

I've looked at the situation, it should be resolved with Codeberg-Infrastructure/scripted-configuration@e9c5415268. I don't think patching this counter away is necessary or helpful now.

I've looked at the situation, it should be resolved with https://codeberg.org/Codeberg-Infrastructure/scripted-configuration/commit/e9c54152687e318afb77e6e19010b66a46273871. I don't think patching this counter away is necessary or helpful now.
Gusted closed this pull request 2026年06月30日 00:24:17 +02:00
Author
First-time contributor
Copy link

Thanks for looking into it.

Working counter > No counter > Broken counter.

I guess this still leaves existing packages with incorrect counters and hiding it would address that but maybe that's not a priority.

Thanks for looking into it. Working counter > No counter > Broken counter. I guess this still leaves existing packages with incorrect counters and hiding it would address that but maybe that's not a priority.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Codeberg-Infrastructure/forgejo!144
Reference in a new issue
Codeberg-Infrastructure/forgejo
No description provided.
Delete branch "sarge/forgejo:hide-incorrect-package-download-count"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?