13
13
Fork
You've already forked code-search
0

feat(dev): add script to generate Hound config #17

Merged
yoctozepto merged 1 commit from radek-dev-gen-hound-config into main 2023年11月04日 14:55:42 +01:00

Closes #12.

Additionally, fixes the issue introduced by Forgejo's double-apply
of #15 (extra cadvisor entry in docker-compose).

Closes #12. Additionally, fixes the issue introduced by Forgejo's double-apply of #15 (extra cadvisor entry in docker-compose).
Closes #3.
Additionally, fixes the issue introduced by Forgejo's double-apply
of #15 (extra cadvisor entry in docker-compose).
yoctozepto force-pushed radek-dev-gen-hound-config from 548cdc8e38 to 91ad5fd367 2023年10月29日 21:44:04 +01:00 Compare
@ -40,24 +40,6 @@ services:
networks:
- forgejo
cadvisor:

Is removing cadvisor in this PR intentional? Why have we added it before?

Is removing cadvisor in this PR intentional? Why have we added it before?
Author
Owner
Copy link

I am deleting the magically-added duplicate which breaks docker compose. See #15 and the referenced bug in Forgejo.

I am deleting the magically-added duplicate which breaks docker compose. See #15 and the referenced bug in Forgejo.
fourstepper marked this conversation as resolved
@ -0,0 +28,4 @@
if __name__ == "__main__":
main()

Based on what condition will this config generator be run? How does that interact with the fact that Hound will most likely run in a container? Will a config change trigger a replacement of the entire container?

Based on what condition will this config generator be run? How does that interact with the fact that Hound will most likely run in a container? Will a config change trigger a replacement of the entire container?
Author
Owner
Copy link
  1. On demand by you or me. Likely once ever.
  2. It does not care.
  3. No. The container would have to be restarted to pick up the changes.
1) On demand by you or me. Likely once ever. 2) It does not care. 3) No. The container would have to be restarted to pick up the changes.

Ok, thanks

Ok, thanks
fourstepper marked this conversation as resolved
yoctozepto deleted branch radek-dev-gen-hound-config 2023年11月04日 14:55:42 +01:00
Sign in to join this conversation.
No reviewers
Labels
Clear labels
Kind/Breaking

Breaking change that won't be backward compatible
Kind/Bug

Something is not working
Kind/Documentation

Documentation changes
Kind/Enhancement

Improve existing functionality
Kind/Feature

New functionality
Kind/Security

This is security issue
Kind/Testing

Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Codeberg-Infrastructure/code-search!17
Reference in a new issue
Codeberg-Infrastructure/code-search
No description provided.
Delete branch "radek-dev-gen-hound-config"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?