13
13
Fork
You've already forked code-search
0

feat(dev): add docker-compose, gickup devel example #1

Merged
yoctozepto merged 1 commit from devel_init into main 2023年09月06日 19:44:49 +02:00
No description provided.

Great start! Thank you.

General comments: feat(search) sounds like it would be all over the place in the code-search repo. :D For this it would be more appropriate to have something like feat(dev).

Also, I would put the /devel into /dev/forgejo because it sets up forgejo and I will also try out Hound as an independent service (also /dev instead of /devel because it's shorter and shorter is sweeter and I like sweet things; kidding aside, if something can be explained in fewer word/characters, then that's the way to go).

Great start! Thank you. General comments: feat(search) sounds like it would be all over the place in the code-search repo. :D For this it would be more appropriate to have something like feat(dev). Also, I would put the /devel into /dev/forgejo because it sets up forgejo and I will also try out Hound as an independent service (also /dev instead of /devel because it's shorter and shorter is sweeter and I like sweet things; kidding aside, if something can be explained in fewer word/characters, then that's the way to go).
devel/.env Outdated
@ -0,0 +1,6 @@
# GLOBAL
REPO_INDEXER_ENABLED=true
# bleve

These could use some link to docs and/or a short summary what they do (i.e., what is bleve?).

These could use some link to docs and/or a short summary what they do (i.e., what is bleve?).
fourstepper marked this conversation as resolved
devel/README.md Outdated
@ -0,0 +2,4 @@
## Prerequisites
- `bash`

To be precise, there is nothing bash-specific so this could be omitted and/or replaced by a generic "shell" (without any kind of quotes/apostrophes).

To be precise, there is nothing bash-specific so this could be omitted and/or replaced by a generic "shell" (without any kind of quotes/apostrophes).
Author
Owner
Copy link

The gickup.sh script has /usr/bin/env bash signature, that’s why it’s here.. I should prolly change they

The gickup.sh script has /usr/bin/env bash signature, that’s why it’s here.. I should prolly change they

Yeah, I commented there as well.

Yeah, I commented there as well.
fourstepper marked this conversation as resolved
@ -0,0 +10,4 @@
restart:unless-stopped
container_name:prometheus
ports:
- '9090:9090'

Some arrays are indented and some are not (like this one). I prefer indented because they look nicer to me.

Some arrays are indented and some are not (like this one). I prefer indented because they look nicer to me.
Author
Owner
Copy link

Idk, do we have some information about a standard regarding this? For example prettier prefers to indent, however the Kubernetes community generally not

Idk, do we have some information about a standard regarding this? For example `prettier` prefers to indent, however the Kubernetes community generally not

There is no standard. In k8s it's also a mix of the two when one reads enough of the docs. But yes, there the non-indented variant is more prevalent. I would simply follow prettier as its popularity is crushing (I'm also biased because it does what I prefer).

There is no standard. In k8s it's also a mix of the two when one reads enough of the docs. But yes, there the non-indented variant is more prevalent. I would simply follow prettier as its popularity is crushing (I'm also biased because it does what I prefer).
Author
Owner
Copy link

Ok, let's do it

Ok, let's do it
fourstepper marked this conversation as resolved
@ -0,0 +1,3 @@
#!/usr/bin/env bash

s/bash/sh

s/bash/sh
fourstepper marked this conversation as resolved
@ -0,0 +1,8 @@
scrape_configs:

arrays could be indented in this file as well

arrays could be indented in this file as well
fourstepper marked this conversation as resolved
Author
Owner
Copy link

Great start! Thank you.

General comments: feat(search) sounds like it would be all over the place in the code-search repo. :D For this it would be more appropriate to have something like feat(dev).

Also, I would put the /devel into /dev/forgejo because it sets up forgejo and I will also try out Hound as an independent service (also /dev instead of /devel because it's shorter and shorter is sweeter and I like sweet things; kidding aside, if something can be explained in fewer word/characters, then that's the way to go).

Makes sense - the idea here is that we will Control each use case from within the .env file - i will just move /devel to /dev, sounds good?

> Great start! Thank you. > > General comments: feat(search) sounds like it would be all over the place in the code-search repo. :D For this it would be more appropriate to have something like feat(dev). > > Also, I would put the /devel into /dev/forgejo because it sets up forgejo and I will also try out Hound as an independent service (also /dev instead of /devel because it's shorter and shorter is sweeter and I like sweet things; kidding aside, if something can be explained in fewer word/characters, then that's the way to go). Makes sense - the idea here is that we will Control each use case from within the .env file - i will just move /devel to /dev, sounds good?

Great start! Thank you.

General comments: feat(search) sounds like it would be all over the place in the code-search repo. :D For this it would be more appropriate to have something like feat(dev).

Also, I would put the /devel into /dev/forgejo because it sets up forgejo and I will also try out Hound as an independent service (also /dev instead of /devel because it's shorter and shorter is sweeter and I like sweet things; kidding aside, if something can be explained in fewer word/characters, then that's the way to go).

Makes sense - the idea here is that we will Control each use case from within the .env file - i will just move /devel to /dev, sounds good?

Ok, although some alternatives may not depend on Forgejo (at least for now). The inline comments are more important, let's say, so let's not spend too much time discussing paths. :D

> > Great start! Thank you. > > > > General comments: feat(search) sounds like it would be all over the place in the code-search repo. :D For this it would be more appropriate to have something like feat(dev). > > > > Also, I would put the /devel into /dev/forgejo because it sets up forgejo and I will also try out Hound as an independent service (also /dev instead of /devel because it's shorter and shorter is sweeter and I like sweet things; kidding aside, if something can be explained in fewer word/characters, then that's the way to go). > > Makes sense - the idea here is that we will Control each use case from within the .env file - i will just move /devel to /dev, sounds good? Ok, although some alternatives may not depend on Forgejo (at least for now). The inline comments are more important, let's say, so let's not spend too much time discussing paths. :D
fourstepper changed title from (削除) feat(search): add docker-compose, gickup devel example (削除ここまで) to feat(dev): add docker-compose, gickup devel example 2023年09月06日 19:40:16 +02:00

/approve

/approve
yoctozepto deleted branch devel_init 2023年09月06日 19:44:49 +02:00
Sign in to join this conversation.
No reviewers
Labels
Clear labels
Kind/Breaking

Breaking change that won't be backward compatible
Kind/Bug

Something is not working
Kind/Documentation

Documentation changes
Kind/Enhancement

Improve existing functionality
Kind/Feature

New functionality
Kind/Security

This is security issue
Kind/Testing

Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Codeberg-Infrastructure/code-search!1
Reference in a new issue
Codeberg-Infrastructure/code-search
No description provided.
Delete branch "devel_init"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?