11
26
Fork
You've already forked build-deploy-forgejo
25

WIP: createVM: Sanitization #45

Closed
kreyren wants to merge 1 commit from shell-refactor into master
pull from: shell-refactor
merge into: Codeberg-Infrastructure:master
Codeberg-Infrastructure:codeberg-15
Codeberg-Infrastructure:renovate/gopkg.in-ini.v1-1.x
Codeberg-Infrastructure:codeberg-14
Codeberg-Infrastructure:codeberg-13
Codeberg-Infrastructure:codeberg-12
Codeberg-Infrastructure:codeberg-11
Codeberg-Infrastructure:pat-s-patch-1
Codeberg-Infrastructure:codeberg-10
Codeberg-Infrastructure:codeberg-9
Codeberg-Infrastructure:codeberg-8
Codeberg-Infrastructure:codeberg-7
Codeberg-Infrastructure:codeberg-1.21
Codeberg-Infrastructure:logo-cleanup
Codeberg-Infrastructure:codeberg-1.20
Codeberg-Infrastructure:codeberg-1.19
Codeberg-Infrastructure:codeberg-1.18
Codeberg-Infrastructure:codeberg-1.17
Codeberg-Infrastructure:configure-mcaptcha
Codeberg-Infrastructure:testing-1.17
Codeberg-Infrastructure:codeberg-1.16
Codeberg-Infrastructure:codeberg-1.15
Codeberg-Infrastructure:codeberg-1.14
Contributor
Copy link

TODO

  • (Won't resolve) Figure out how to deploy shellcheck CI on codeberg so that it's less likely for 3rd party to break the script
  • Expecting to run i.e https://github.com/Kreymacs/Kreymacs/blob/master/.github/workflows/shell.yml
  • Blocked by Codeberg/Community#78
  • Can be implemented through the current POST/GET calls that gitea has to call sourcehut build.
  • Research the way that this is implemented as docker seems to make more sense in terms of system resources
    • More info requested
  • Decide whether Makefile is not a better implementation for this
    • More info requested
  • Research if we really need to interact with ssh-keygen
    • Required for the qemu called from libvirt to have ssh access.

WIP to reimplement the createVM script to be sane to use

Signed-off-by: Jacob Hrbek kreyren@rixotstudio.cz

### TODO - [X] (Won't resolve) Figure out how to deploy shellcheck CI on codeberg so that it's less likely for 3rd party to break the script - Expecting to run i.e https://github.com/Kreymacs/Kreymacs/blob/master/.github/workflows/shell.yml - Blocked by https://codeberg.org/Codeberg/Community/issues/78 - Can be implemented through the current POST/GET calls that gitea has to call sourcehut build. - [ ] Research the way that this is implemented as docker seems to make more sense in terms of system resources - More info requested - [ ] Decide whether `Makefile` is not a better implementation for this - More info requested - [X] Research if we really need to interact with `ssh-keygen` - Required for the qemu called from libvirt to have ssh access. --- WIP to reimplement the createVM script to be sane to use Signed-off-by: Jacob Hrbek <kreyren@rixotstudio.cz>
kreyren stopped working 2020年09月18日 10:32:39 +02:00
5min 28s
Author
Contributor
Copy link

@hw requesting more informations:

Why is this creating a VM environment? Is this actually how codeberg is deployed or is this just for testing purposes?

I would think that docker would be a better alternative for the testing in terms of system compatibility and system resources no?

EDIT: it's not, found the answer in makefile

@hw requesting more informations: Why is this creating a VM environment? Is this actually how codeberg is deployed or is this just for testing purposes? I would think that docker would be a better alternative for the testing in terms of system compatibility and system resources no? EDIT: it's not, found the answer in makefile
fnetX closed this pull request 2021年08月30日 14:49:02 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Total time spent: 9 minutes 28 seconds
kreyren
9 minutes 28 seconds
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Codeberg-Infrastructure/build-deploy-forgejo!45
Reference in a new issue
Codeberg-Infrastructure/build-deploy-forgejo
No description provided.
Delete branch "shell-refactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?