Make the remote user header a configuration #3

pscn commented 2021年08月27日 10:24:56 +02:00

Hi,

I had the same issue as #2. Instead of changing REMOTE_USER to HTTP_REMOTE_USER (authelia uses this) in the code I thought it might be a good idea to provide it as configuration.

Had to rename the class from auth_plugin_AuthRemoteUser to auth_plugin_authremoteuser to get $this->getConf to work (that took some time to figure out).

Thanks for the plugin btw :)

Kind regards,
Peter

Hi, I had the same issue as #2. Instead of changing REMOTE_USER to HTTP_REMOTE_USER (authelia uses this) in the code I thought it might be a good idea to provide it as configuration. Had to rename the class from auth_plugin_AuthRemoteUser to auth_plugin_authremoteuser to get $this->getConf to work (that took some time to figure out). Thanks for the plugin btw :) Kind regards, Peter

Charly commented 2021年08月30日 14:15:45 +02:00

Good idea!

But I would prefer some changes:

1. Variable name serverVarNameOfAuthSystem and configuration server_var_name_of_auth_system is less specific regarding possible other values because they don't refer to anything containing REMOTE_USER.
2. In line with this, localized string should be "Server's variable name for authenticated users according to your authentication system".

That is:

1. auth.php, lines 73–76:

   $serverVarNameOfAuthSystem = $this->getConf('server_var_name_of_auth_system');
   if (!empty($_SERVER[$serverVarNameOfAuthSystem])) {
   	$remoteUser = $this->cleanUser($_SERVER[$serverVarNameOfAuthSystem]);
   

2. conf/default.php, line 3:

   $conf['server_var_name_of_auth_system'] = 'REMOTE_USER';
   

3. conf/metadata.php, line 3:

   $meta['server_var_name_of_auth_system'] = array('string');
   

4. lang/en/settings.php, line 3:

   $lang['server_var_name_of_auth_system'] = 'Server\'s variable name for authenticated users according to your authentication system';
   

Do you agree?

Good idea! But I would prefer some changes: 1. Variable name `serverVarNameOfAuthSystem` and configuration `server_var_name_of_auth_system` is less specific regarding possible other values because they don't refer to anything containing REMOTE_USER. 2. In line with this, localized string should be _"Server's variable name for authenticated users according to your authentication system"_. That is: 1. `auth.php`, lines 73–76: ```php $serverVarNameOfAuthSystem = $this->getConf('server_var_name_of_auth_system'); if (!empty($_SERVER[$serverVarNameOfAuthSystem])) { $remoteUser = $this->cleanUser($_SERVER[$serverVarNameOfAuthSystem]); ``` 2. `conf/default.php`, line 3: ```php $conf['server_var_name_of_auth_system'] = 'REMOTE_USER'; ``` 3. `conf/metadata.php`, line 3: ```php $meta['server_var_name_of_auth_system'] = array('string'); ``` 4. `lang/en/settings.php`, line 3: ```php $lang['server_var_name_of_auth_system'] = 'Server\'s variable name for authenticated users according to your authentication system'; ``` Do you agree?

pscn commented 2021年08月30日 15:03:03 +02:00

Perfect :)

Will you do the changes or should I update the pull request?

Perfect :) Will you do the changes or should I update the pull request?

pscn commented 2021年08月30日 17:34:09 +02:00

Awesome! Thank you :)

Awesome! Thank you :)