1
1
Fork
You've already forked ecformat
0

Do not collect ConfigFile instances #52

Manually merged
BaumiCoder merged 1 commit from bugfix/Too-many-open-files-via-ConfigFile into main 2026年06月04日 18:53:13 +02:00

Bug fix for #38 and #8

User perspective

Fixes a problem with too many open files when process all relevant .editorconfig files for the status command or for the handling of spelling_language in the check command.

Developer perspective

Collecting the ConfigFile instances from ConfigFiles::open in a vector means that all these instances of file handles are open at the same time! This can lead to too many open file handles for the process / system.
A "Too many open files" already occurs on my local machine (not in the CI) when running the tests

files::tests::get_target_files::test_get_target_files_bool_options
files::tests::get_editorconfig_files::test_get_editorconfig_files_bool_options

(However, only if I run all tests and not if I run them separately.)

This problem was introduced with commit 5263ffc.

Bug fix for #38 and #8 ### User perspective Fixes a problem with too many open files when process all relevant `.editorconfig` files for the `status` command or for the handling of `spelling_language` in the `check` command. ### Developer perspective Collecting the ConfigFile instances from ConfigFiles::open in a vector means that all these instances of file handles are open at the same time! This can lead to too many open file handles for the process / system. A "Too many open files" already occurs on my local machine (not in the CI) when running the tests ``` files::tests::get_target_files::test_get_target_files_bool_options files::tests::get_editorconfig_files::test_get_editorconfig_files_bool_options ``` (However, only if I run all tests and not if I run them separately.) This problem was introduced with commit 5263ffc.
Do not collect ConfigFile instances
All checks were successful
/ changes (pull_request) Successful in 52s
/ lint_reuse (pull_request) Successful in 1m13s
/ lint_codespell (pull_request) Successful in 1m7s
/ lint_ecformat (pull_request) Successful in 9m15s
/ test (pull_request) Successful in 5m22s
/ lint_cargo_deny (advisories) (pull_request) Has been skipped
/ lint_cargo_deny (bans licenses sources) (pull_request) Has been skipped
/ lint_clippy (pull_request) Successful in 3m34s
/ lint_rustfmt (pull_request) Successful in 1m58s
/ lint_taplo (pull_request) Has been skipped
/ lint_yamllint (pull_request) Has been skipped
/ lint_cargo_udeps (pull_request) Successful in 22m57s
/ lint_docs_rs (pull_request) Successful in 4m25s
6f84debe23
 
Collecting the ConfigFile instances from ConfigFiles::open in a vector
means that all this instances of file handles are open at the same time!
This can lead to too many open file handles for the process / system.
A "Too many open files" already occurs on my local machine
(not in the CI) when running the tests
files::tests::get_target_files::test_get_target_files_bool_options
files::tests::get_editorconfig_files::test_get_editorconfig_files_bool_options
(However, only if I run all tests and not if I run them separately.)
BaumiCoder manually merged commit 3058d3f1a2 into main 2026年06月04日 18:53:13 +02:00
Sign in to join this conversation.
No reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
EditorConfig
0.17.2
 Issues to support version 0.17.2 of the EditorConfig specification
Kind
Bug
 Something is not working
Kind
Chore
 Some tasks maintainig tasks
Kind
Documentation
 Documentation changes
Kind
Enhancement
 Improve existing functionality
Kind
Feature
 New functionality
Kind
Testing
 Issue or pull request related to testing
Packaging
About packaging the project for some platform
Priority
Critical
 The priority is critical
Priority
High
 The priority is high
Priority
Low
 The priority is low
Priority
Medium
 The priority is medium
Reviewed
Confirmed
 Issue has been confirmed
Reviewed
Duplicate
 This issue or pull request already exists
Reviewed
Invalid
 Invalid issue
Reviewed
Won't Fix
 This issue won't be fixed
Status
Abandoned
 Somebody has started to work on this but abandoned work
Status
Blocked
 Something is blocking this issue or pull request
Status
Need More Info
 Feedback is required to reproduce issue or to continue work
WIP
Work in progress (Assignee is working on this issue)
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
BaumiCoder/ecformat!52
Reference in a new issue
BaumiCoder/ecformat
No description provided.
Delete branch "bugfix/Too-many-open-files-via-ConfigFile"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?