1
1
Fork
You've already forked ecformat
0

Handle unparsable values of spelling_language for validation #51

Manually merged
BaumiCoder merged 3 commits from bugfix/spelling_language-unparsable-values into main 2026年06月04日 18:11:02 +02:00

Addition for #8

User perspective

Some values for spelling_language cannot be parsed and therefore also no validation of the LanguageTag can be performed. This Pull Request adds that in such cases the validation (as part of the check command) also detects an invalid value.

Developer perspective

See commit messages for some details.

Addition for #8 ### User perspective Some values for `spelling_language` cannot be parsed and therefore also no validation of the `LanguageTag` can be performed. This Pull Request adds that in such cases the validation (as part of the `check` command) also detects an invalid value. ### Developer perspective See commit messages for some details. 
Some errors are not even parsable. Therefore, no LanguageTag can be
created for them and this implies not validation on it can be performed.
Use the RawValue to construct a separate error type in such cases.
With that values such as "en_US" (instead of "en-US") can be detected
as faulty.
Build config handlers only onces
Some checks failed
/ changes (pull_request) Successful in 53s
/ lint_reuse (pull_request) Successful in 1m13s
/ lint_codespell (pull_request) Successful in 1m7s
/ lint_ecformat (pull_request) Successful in 9m22s
/ test (pull_request) Successful in 4m31s
/ lint_cargo_deny (advisories) (pull_request) Has been skipped
/ lint_cargo_deny (bans licenses sources) (pull_request) Has been skipped
/ lint_clippy (pull_request) Successful in 3m32s
/ lint_rustfmt (pull_request) Successful in 1m54s
/ lint_taplo (pull_request) Has been skipped
/ lint_yamllint (pull_request) Has been skipped
/ lint_docs_rs (pull_request) Has been cancelled
/ lint_cargo_udeps (pull_request) Has been cancelled
108af10668
 
As they are now independent of the considered files,
they can be build only onces and if the list is empty
(i.e., the property is disabled) no processing of configs is necessary.
Improve test assertion
All checks were successful
/ changes (pull_request) Successful in 53s
/ lint_reuse (pull_request) Successful in 1m13s
/ lint_codespell (pull_request) Successful in 1m6s
/ lint_ecformat (pull_request) Successful in 2m0s
/ test (pull_request) Successful in 4m32s
/ lint_cargo_deny (advisories) (pull_request) Has been skipped
/ lint_cargo_deny (bans licenses sources) (pull_request) Has been skipped
/ lint_clippy (pull_request) Successful in 3m40s
/ lint_rustfmt (pull_request) Successful in 1m46s
/ lint_taplo (pull_request) Has been skipped
/ lint_yamllint (pull_request) Has been skipped
/ lint_cargo_udeps (pull_request) Successful in 22m48s
/ lint_docs_rs (pull_request) Successful in 4m26s
1fa6e44d44
BaumiCoder manually merged commit 0108e01c5e into main 2026年06月04日 18:11:02 +02:00
Sign in to join this conversation.
No reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
EditorConfig
0.17.2
 Issues to support version 0.17.2 of the EditorConfig specification
Kind
Bug
 Something is not working
Kind
Chore
 Some tasks maintainig tasks
Kind
Documentation
 Documentation changes
Kind
Enhancement
 Improve existing functionality
Kind
Feature
 New functionality
Kind
Testing
 Issue or pull request related to testing
Packaging
About packaging the project for some platform
Priority
Critical
 The priority is critical
Priority
High
 The priority is high
Priority
Low
 The priority is low
Priority
Medium
 The priority is medium
Reviewed
Confirmed
 Issue has been confirmed
Reviewed
Duplicate
 This issue or pull request already exists
Reviewed
Invalid
 Invalid issue
Reviewed
Won't Fix
 This issue won't be fixed
Status
Abandoned
 Somebody has started to work on this but abandoned work
Status
Blocked
 Something is blocking this issue or pull request
Status
Need More Info
 Feedback is required to reproduce issue or to continue work
WIP
Work in progress (Assignee is working on this issue)
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
BaumiCoder/ecformat!51
Reference in a new issue
BaumiCoder/ecformat
No description provided.
Delete branch "bugfix/spelling_language-unparsable-values"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?