1
1
Fork
You've already forked ecformat
0

Fix CI change detection #41

Manually merged
BaumiCoder merged 0 commits from bugfix/CI-change-detection into main 2026年05月08日 07:26:10 +02:00

User perspective

Only internal changes in the project, so there are not changed from the user perspective.

Developer perspective

The CI did not run all Action as it did not detect correctly what kind of files changed in a Pull Request (PR). To test this the first commit of this PR makes some improvements in the doc comments of some test code. In its CI run, the paths-filter filter has rust = false although .rs files have changed. Updating the Action did not fix the problem (see f7b4122fa6) and the CI only run due to the changes in the lint.yaml itself (which was missing for the test.yaml a90f8f8a91 and e9a1714c22).

After adjusting the filter patterns with ed24f9f30f, the CI run detected correctly rust = true. Therefore, always use the prefix **/ for file extension filters. For example **/*.rs instead of *.rs.

### User perspective Only internal changes in the project, so there are not changed from the user perspective. ### Developer perspective The CI did not run all Action as it did not detect correctly what kind of files changed in a Pull Request (PR). To test this the first commit of this PR makes some improvements in the doc comments of some test code. In its [CI run](https://codeberg.org/BaumiCoder/ecformat/actions/runs/169/jobs/0/attempt/1), the `paths-filter` filter has `rust = false` although `.rs` files have changed. Updating the Action did not fix the problem (see f7b4122fa66e7443a29ffb66834512c0ebdcb6de) and the CI only run due to the changes in the `lint.yaml` itself (which was missing for the `test.yaml` a90f8f8a91e47d40940b471d74d8f65985f455c5 and e9a1714c22c5039fd1c4f4e3ae7b711c3f722aaa). After adjusting the filter patterns with ed24f9f30f008cb88b902a95433ebf65c0a8161e, the [CI run](https://codeberg.org/BaumiCoder/ecformat/actions/runs/173/jobs/0/attempt/1) detected correctly `rust = true`. Therefore, always use the prefix `**/` for file extension filters. For example `**/*.rs` instead of `*.rs`.
Documentation: Fix some doc comments
All checks were successful
/ changes (pull_request) Successful in 50s
/ lint_reuse (pull_request) Successful in 1m9s
/ lint_codespell (pull_request) Successful in 1m3s
/ lint_ecformat (pull_request) Successful in 9m30s
/ test (pull_request) Successful in 58s
/ lint_cargo_deny (advisories) (pull_request) Has been skipped
/ lint_cargo_deny (bans licenses sources) (pull_request) Has been skipped
/ lint_clippy (pull_request) Has been skipped
/ lint_rustfmt (pull_request) Has been skipped
/ lint_taplo (pull_request) Has been skipped
/ lint_yamllint (pull_request) Has been skipped
/ lint_cargo_udeps (pull_request) Has been skipped
/ lint_docs_rs (pull_request) Has been skipped
090b6db2ae
 
Some links to functions fixed and
use them to reduce duplication in the doc comments.
CI: Upgrade Action dorny/paths-filter@v4
All checks were successful
/ changes (pull_request) Successful in 55s
/ lint_reuse (pull_request) Successful in 1m13s
/ lint_codespell (pull_request) Successful in 1m6s
/ lint_ecformat (pull_request) Successful in 2m1s
/ test (pull_request) Successful in 59s
/ lint_cargo_deny (advisories) (pull_request) Successful in 2m54s
/ lint_cargo_deny (bans licenses sources) (pull_request) Successful in 2m28s
/ lint_clippy (pull_request) Successful in 3m25s
/ lint_rustfmt (pull_request) Successful in 1m54s
/ lint_taplo (pull_request) Successful in 1m57s
/ lint_yamllint (pull_request) Successful in 1m7s
/ lint_cargo_udeps (pull_request) Successful in 22m36s
/ lint_docs_rs (pull_request) Successful in 4m17s
f7b4122fa6
 
The '**/' seems to be necessary to cover all files. Otherwise, it seems
that only the files in the repo root are considered.
Example from the Action project:
f3ceefdc7e/README.md (L517)
CI: Run tests if their CI config changed
All checks were successful
/ changes (pull_request) Successful in 53s
/ lint_reuse (pull_request) Successful in 1m12s
/ lint_codespell (pull_request) Successful in 1m6s
/ lint_ecformat (pull_request) Successful in 2m0s
/ test (pull_request) Successful in 59s
/ lint_cargo_deny (advisories) (pull_request) Successful in 2m27s
/ lint_cargo_deny (bans licenses sources) (pull_request) Successful in 2m24s
/ lint_clippy (pull_request) Successful in 3m25s
/ lint_rustfmt (pull_request) Successful in 1m41s
/ lint_taplo (pull_request) Successful in 1m56s
/ lint_yamllint (pull_request) Successful in 1m6s
/ lint_cargo_udeps (pull_request) Successful in 3m52s
/ lint_docs_rs (pull_request) Successful in 2m31s
a90f8f8a91
 
To avoid that changes in the test.yaml itself breaks the CI Action to
run the tests if there are not changes in the project itself.
Keep it as separate filter to see in the log which filter triggered.
CI: Fix names of filter conditions
All checks were successful
/ changes (pull_request) Successful in 52s
/ lint_reuse (pull_request) Successful in 1m11s
/ lint_codespell (pull_request) Successful in 1m5s
/ lint_ecformat (pull_request) Successful in 1m58s
/ test (pull_request) Successful in 58s
/ lint_cargo_deny (advisories) (pull_request) Has been skipped
/ lint_cargo_deny (bans licenses sources) (pull_request) Has been skipped
/ lint_clippy (pull_request) Has been skipped
/ lint_rustfmt (pull_request) Has been skipped
/ lint_taplo (pull_request) Has been skipped
/ lint_yamllint (pull_request) Has been skipped
/ lint_cargo_udeps (pull_request) Has been skipped
/ lint_docs_rs (pull_request) Has been skipped
e9a1714c22
 
"needs" is for output of previous jobs and not for the output of the
previous steps inside a job.
BaumiCoder manually merged commit f0d59bc39d into main 2026年05月08日 07:26:10 +02:00
Sign in to join this conversation.
No reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
EditorConfig
0.17.2
 Issues to support version 0.17.2 of the EditorConfig specification
Kind
Bug
 Something is not working
Kind
Chore
 Some tasks maintainig tasks
Kind
Documentation
 Documentation changes
Kind
Enhancement
 Improve existing functionality
Kind
Feature
 New functionality
Kind
Testing
 Issue or pull request related to testing
Packaging
About packaging the project for some platform
Priority
Critical
 The priority is critical
Priority
High
 The priority is high
Priority
Low
 The priority is low
Priority
Medium
 The priority is medium
Reviewed
Confirmed
 Issue has been confirmed
Reviewed
Duplicate
 This issue or pull request already exists
Reviewed
Invalid
 Invalid issue
Reviewed
Won't Fix
 This issue won't be fixed
Status
Abandoned
 Somebody has started to work on this but abandoned work
Status
Blocked
 Something is blocking this issue or pull request
Status
Need More Info
 Feedback is required to reproduce issue or to continue work
WIP
Work in progress (Assignee is working on this issue)
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
BaumiCoder/ecformat!41
Reference in a new issue
BaumiCoder/ecformat
No description provided.
Delete branch "bugfix/CI-change-detection"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?