1
1
Fork
You've already forked ecformat
0

Make CI and pre-commit more reproducable #35

Manually merged
BaumiCoder merged 8 commits from chore/33-Make-CI-and-pre-commit-more-reproducable into main 2026年02月21日 15:53:32 +01:00

Resolves #33

User perspective

No changes for users of ecformat (only changes in the development process of the project)

Developer perspective

  • cargo-deny is now executed differently. The detection of security issues is reported in the CI but does not lead to failings of the following CI jobs. Furthermore, the pre-commit hook does not report security issues anymore. These avoid sudden fails due to new security issues in the database.
  • All jobs, which has not a fixed image from an action, now use a image with a fixed (Ubuntu) version. This should avoid problems, like the one fixed with 448e8b550a, in the future.
  • All linters are executed in the CI, if the lint.yaml has changed. This makes sure that they are executed if the config is e.g., the image or linter versions are updated.
Resolves #33 ### User perspective No changes for users of ecformat (only changes in the development process of the project) ### Developer perspective - cargo-deny is now executed differently. The detection of security issues is reported in the CI but does not lead to failings of the following CI jobs. Furthermore, the pre-commit hook does not report security issues anymore. These avoid sudden fails due to new security issues in the database. - All jobs, which has not a fixed image from an action, now use a image with a fixed (Ubuntu) version. This should avoid problems, like the one fixed with 448e8b550a0eb64c748215044f85a7505f9d27e1, in the future. - All linters are executed in the CI, if the `lint.yaml` has changed. This makes sure that they are executed if the config is e.g., the image or linter versions are updated. 
To avoid breaking changes introduced by new Ubuntu LTS versions
This makes the CI / pre-commit more reproducable.
The CI has the "outcome" "failure" but still continues
as the "conclusion" is "success".
For the pre-commit there seems to be no way
to "fail but success" in some way.
Therefore, pre-commit does not performe the security check anymore.
That is also trigger for the offical Pre-commit hook
CI: Set a fixed Ubuntu version for default imags
Some checks failed
lint.yaml / CI: Set a fixed Ubuntu version for default imags (pull_request) Failing after 0s
/ test (pull_request) Successful in 1m2s
7db235384a
 
To avoid breaking changes introduced by new Ubuntu LTS versions
at least for jobs which do not use an Action
CI: Attempt to fix unmarshall error
All checks were successful
/ changes (pull_request) Successful in 50s
/ lint_reuse (pull_request) Successful in 1m9s
/ lint_codespell (pull_request) Successful in 1m5s
/ lint_ecformat (pull_request) Successful in 8m36s
/ test (pull_request) Successful in 57s
/ lint_cargo_deny (advisories) (pull_request) Has been skipped
/ lint_cargo_deny (bans licenses sources) (pull_request) Has been skipped
/ lint_clippy (pull_request) Has been skipped
/ lint_rustfmt (pull_request) Has been skipped
/ lint_taplo (pull_request) Has been skipped
/ lint_yamllint (pull_request) Successful in 1m4s
/ lint_cargo_udeps (pull_request) Has been skipped
/ lint_docs_rs (pull_request) Has been skipped
5d93d13d82
 
Error with current lint.yaml is
invalid jobs: yaml: unmarshal errors: line 70:
cannot unmarshal !!str `${{ mat...` into bool
CI: Run all linters if the CI config has changed
All checks were successful
/ changes (pull_request) Successful in 52s
/ lint_reuse (pull_request) Successful in 1m10s
/ lint_codespell (pull_request) Successful in 1m3s
/ lint_ecformat (pull_request) Successful in 2m49s
/ test (pull_request) Successful in 57s
/ lint_cargo_deny (advisories) (pull_request) Successful in 4m32s
/ lint_cargo_deny (bans licenses sources) (pull_request) Successful in 2m23s
/ lint_clippy (pull_request) Successful in 3m57s
/ lint_rustfmt (pull_request) Successful in 2m1s
/ lint_taplo (pull_request) Successful in 2m4s
/ lint_yamllint (pull_request) Successful in 1m18s
/ lint_cargo_udeps (pull_request) Successful in 22m59s
/ lint_docs_rs (pull_request) Successful in 4m35s
d174477992
CI: Set a fixed version for default image (taplo)
All checks were successful
/ changes (pull_request) Successful in 50s
/ lint_reuse (pull_request) Successful in 1m8s
/ lint_codespell (pull_request) Successful in 1m2s
/ lint_ecformat (pull_request) Successful in 2m59s
/ test (pull_request) Successful in 55s
/ lint_cargo_deny (advisories) (pull_request) Successful in 3m5s
/ lint_cargo_deny (bans licenses sources) (pull_request) Successful in 2m22s
/ lint_clippy (pull_request) Successful in 2m58s
/ lint_rustfmt (pull_request) Successful in 1m51s
/ lint_taplo (pull_request) Successful in 1m49s
/ lint_yamllint (pull_request) Successful in 1m4s
/ lint_cargo_udeps (pull_request) Successful in 4m24s
/ lint_docs_rs (pull_request) Successful in 3m2s
f6e20ec728
 
To avoid breaking changes introduced by new Ubuntu LTS versions
as the Action itself defines not image
BaumiCoder changed title from (削除) WIP: Make CI and pre-commit more reproducable (削除ここまで) to Make CI and pre-commit more reproducable 2026年02月21日 15:26:16 +01:00
BaumiCoder manually merged commit a6bde3a48d into main 2026年02月21日 15:53:32 +01:00
Sign in to join this conversation.
No reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
EditorConfig
0.17.2
 Issues to support version 0.17.2 of the EditorConfig specification
Kind
Bug
 Something is not working
Kind
Chore
 Some tasks maintainig tasks
Kind
Documentation
 Documentation changes
Kind
Enhancement
 Improve existing functionality
Kind
Feature
 New functionality
Kind
Testing
 Issue or pull request related to testing
Packaging
About packaging the project for some platform
Priority
Critical
 The priority is critical
Priority
High
 The priority is high
Priority
Low
 The priority is low
Priority
Medium
 The priority is medium
Reviewed
Confirmed
 Issue has been confirmed
Reviewed
Duplicate
 This issue or pull request already exists
Reviewed
Invalid
 Invalid issue
Reviewed
Won't Fix
 This issue won't be fixed
Status
Abandoned
 Somebody has started to work on this but abandoned work
Status
Blocked
 Something is blocking this issue or pull request
Status
Need More Info
 Feedback is required to reproduce issue or to continue work
WIP
Work in progress (Assignee is working on this issue)
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
BaumiCoder/ecformat!35
Reference in a new issue
BaumiCoder/ecformat
No description provided.
Delete branch "chore/33-Make-CI-and-pre-commit-more-reproducable"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?