lunatrium/codeberg-cli:main into main Implements #169,
uses the already used crate webbrowser for actually opening the website.
also is able to open the wiki subrepository (eg. codeberg.org/knut/foobar.wiki.git)
berg repo open
This is my first pull request. Could you please give me some kind of feedback?
Thank you for your contribution! This looks really clean ✨ Will merge once you give me the go that you don't want to do any further changes!
@ -0,0 +28,4 @@
.unwrap_or(
ctx.owner_repo()
.map(|OwnerRepo{repo,owner}|(owner,repo))?,
);
I would suggest using
let(owner,repo)=ctx.args.owner_and_repo.as_ref().and_then(|s|parse_owner_and_repo(s).ok()).or_else(||{ctx.owner_repo().map(|OwnerRepo{repo,owner}|(owner,repo)).ok()}).context("Couldn't determine owner and repo")?;here instead.
let(owner,repo)=ctx.args.owner_and_repo.as_ref().and_then(|s|parse_owner_and_repo(s).ok()).or_else(||{ctx.owner_repo().ok().map(|OwnerRepo{repo,owner}|(owner,repo))}).context("Couldn't determine owner and repo")?;Thanks.
Should I rebase/squash the change to a single commit or should I make a new commit?
You're welcome!
You don't have to squash, I'll do that when merging. So a new commit is fine. Rebasing this on main would be useful though, so I can merge asap before new conflicts appear!
95c046abe0
to 2d2efcfe3d
refactored code so it matches with the lastest upstream changes eg. b2d662581e, 833d5e73cf.
Thank you for your help, from my side you can merge this now.
LGTM! Thank you a lot for the contribution! 💚
No due date set.
No dependencies set.
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?