Added openai compatible v1 completions and ollama api key compatibility (#73) #74

qyrhal commented 2026年06月03日 06:20:57 +02:00

Added:
- v1 completions (OpenAI compatible) and testing connection
- Add API key handling for Ollama and v1 completions if required

Added: - v1 completions (OpenAI compatible) and testing connection - Add API key handling for Ollama and v1 completions if required

ArkHost commented 2026年06月03日 14:33:16 +02:00

Hello,

Thanks a lot! The v1 completions + optional Ollama key is really useful, and the new stream_completions / test_completions look good.

But I think the branch got messed up in a rebase. A lot of the added code is duplicated and right now it would not compile. Can you rebase clean on current main and remove the doubles? The two that break the build:

• ai.rs, ai_request ollama arm: stream_openai(...) gets key_opt twice. It takes only one key, so it should be just one key_opt.
• ai.rs, test_connection openai_compatible arm: it calls both test_completions(...).await and test_openai(...).await one after the other, which doesn't parse. Only test_completions should stay.

Same duplication is also in the commands.rs match blocks and a bit in SettingsPanel.svelte. Please also check types.rs for a doubled field.

If you do cargo build + pnpm build after the rebase it should be clean. Then I merge happy. Thanks again!

Hello, Thanks a lot! The v1 completions + optional Ollama key is really useful, and the new stream_completions / test_completions look good. But I think the branch got messed up in a rebase. A lot of the added code is duplicated and right now it would not compile. Can you rebase clean on current main and remove the doubles? The two that break the build: - ai.rs, ai_request ollama arm: stream_openai(...) gets key_opt twice. It takes only one key, so it should be just one key_opt. - ai.rs, test_connection openai_compatible arm: it calls both test_completions(...).await and test_openai(...).await one after the other, which doesn't parse. Only test_completions should stay. Same duplication is also in the commands.rs match blocks and a bit in SettingsPanel.svelte. Please also check types.rs for a doubled field. If you do cargo build + pnpm build after the rebase it should be clean. Then I merge happy. Thanks again!

qyrhal commented 2026年06月03日 15:44:38 +02:00

Apologies,

I didnt realise the merge conflict earlier was resolved improper.
This new fix should of fixed it now, it has compiled.

Apologies, I didnt realise the merge conflict earlier was resolved improper. This new fix should of fixed it now, it has compiled.