Archived
1
0
Fork
You've already forked PowerGrid
0

Vehicle: Include Travel Distance in Calculations, Refactoring & Bug Fixes #66

Merged
lukasseb merged 2 commits from tschuldigung into main 2025年06月15日 17:37:04 +02:00
lukasseb commented 2025年06月15日 14:55:26 +02:00 (Migrated from github.com)
Copy link

Wollte eig nur die Methode get_range() implementieren und beim accepten der best_offer nutzen.
Dann aber Einheiten Chaos (Verbrauch ist in kWh/100km) am besten bei Verwendung durch 100 teilen.
Nun gibt es 3 Sorten von Offer die wir bekommen.

  • Offers die out of range sind.
  • Ofers mit zu wenig energy zum voll laden, da schauen wir auf größten amount
  • Offers mit genug energy zum voll laden, da schauen wir auf geringste kosten (preis*energy)

Habe wahrscheinlich noch was vergessen.

Jaa ist sehr viel geworden, aber eyy ich schreib Kommentare

Wollte eig nur die Methode get_range() implementieren und beim accepten der best_offer nutzen. Dann aber Einheiten Chaos (Verbrauch ist in kWh/100km) am besten bei Verwendung durch 100 teilen. Nun gibt es 3 Sorten von Offer die wir bekommen. - Offers die out of range sind. - Ofers mit zu wenig energy zum voll laden, da schauen wir auf größten amount - Offers mit genug energy zum voll laden, da schauen wir auf geringste kosten (preis*energy) Habe wahrscheinlich noch was vergessen. Jaa ist sehr viel geworden, aber eyy ich schreib Kommentare
num2 (Migrated from github.com) reviewed 2025年06月15日 14:55:26 +02:00
AnnsAnn left a comment

Very epic otherwise 🐸👍

Very epic otherwise 🐸👍

Why did you remove the arguments and add a HTML Tag?

Why did you remove the arguments and add a HTML Tag?

Should be fine for this context, nice catch

Should be fine for this context, nice catch
@ -1,20 +1,37 @@
usecrate::ChargerHandler;

Is that even true though, the id is the charger id not a unique id for a specific id or am I misremembering this

Is that even true though, the id is the charger id not a unique id for a specific id or am I misremembering this
@ -10,3 +17,3 @@
price: f64,
price: f64,// TODO: should be used??
was_accepted: bool,
}

same here

same here
@ -4,0 +4,4 @@
// do not change these values
pubconstTICK_AS_SEC: usize =TICK_AS_MIN*60;// our tick in seconds
pubconstTICK_AS_HOUR: f64 =TICK_AS_MINasf64/60.0;// our tick in hours

I get what you were doing here but are any values besides TICK_AS_SEC ever used?

I get what you were doing here but are any values besides TICK_AS_SEC ever used?
lukasseb (Migrated from github.com) reviewed 2025年06月15日 16:36:17 +02:00
lukasseb (Migrated from github.com) commented 2025年06月15日 16:36:17 +02:00


for the view when hover over function
argument is 2 lines below, just my comment style
sorry for changing

<br> for the view when hover over function argument is 2 lines below, just my comment style sorry for changing
lukasseb (Migrated from github.com) reviewed 2025年06月15日 16:41:51 +02:00
@ -1,20 +1,37 @@
usecrate::ChargerHandler;
lukasseb (Migrated from github.com) commented 2025年06月15日 16:41:50 +02:00

changed it to vehicle name now

changed it to vehicle name now
lukasseb (Migrated from github.com) reviewed 2025年06月15日 16:42:08 +02:00
@ -10,3 +17,3 @@
price: f64,
price: f64,// TODO: should be used??
was_accepted: bool,
}
lukasseb (Migrated from github.com) commented 2025年06月15日 16:42:07 +02:00

changed to vehicle_name

changed to vehicle_name
lukasseb (Migrated from github.com) reviewed 2025年06月15日 16:44:48 +02:00
@ -4,0 +4,4 @@
// do not change these values
pubconstTICK_AS_SEC: usize =TICK_AS_MIN*60;// our tick in seconds
pubconstTICK_AS_HOUR: f64 =TICK_AS_MINasf64/60.0;// our tick in hours
lukasseb (Migrated from github.com) commented 2025年06月15日 16:44:47 +02:00

for example PHASE_AS_HOUR for driving.
Maybe more for later

for example PHASE_AS_HOUR for driving. Maybe more for later
Commenting is not possible because the repository is archived.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AnnsAnn/PowerGrid!66
Reference in a new issue
AnnsAnn/PowerGrid
No description provided.
Delete branch "tschuldigung"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?