9
66
Fork
You've already forked Bolt
11

Fix trailing comma in release-msvc preset cacheVariables #54

Open
charlieleith wants to merge 1 commit from charlieleith/Bolt:fix/presets-trailing-comma into master
pull from: charlieleith/Bolt:fix/presets-trailing-comma
merge into: Adamcake:master
Adamcake:master
Adamcake:zigify
First-time contributor
Copy link

Strict JSON parsers (including the one used by cmake 4.x) reject trailing commas with Missing '}' or object member name and refuse to read CMakePresets.json at all, which breaks every preset — not just the MSVC one containing the comma.

One-character fix; Windows-only config, but the JSON parse failure is cross-platform. No functional change.

Strict JSON parsers (including the one used by cmake 4.x) reject trailing commas with `Missing '}' or object member name` and refuse to read `CMakePresets.json` at all, which breaks every preset — not just the MSVC one containing the comma. One-character fix; Windows-only config, but the JSON parse failure is cross-platform. No functional change.
Strict JSON parsers (including the one used by cmake 4.x) reject
trailing commas with "Missing '}' or object member name" and refuse
to read CMakePresets.json at all, breaking all presets — not just
the MSVC one that contained the comma.
One-character fix; Windows-only config, but the JSON parse failure
is cross-platform.
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u fix/presets-trailing-comma:charlieleith-fix/presets-trailing-comma
git switch charlieleith-fix/presets-trailing-comma

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff charlieleith-fix/presets-trailing-comma
git switch charlieleith-fix/presets-trailing-comma
git rebase master
git switch master
git merge --ff-only charlieleith-fix/presets-trailing-comma
git switch charlieleith-fix/presets-trailing-comma
git rebase master
git switch master
git merge --no-ff charlieleith-fix/presets-trailing-comma
git switch master
git merge --squash charlieleith-fix/presets-trailing-comma
git switch master
git merge --ff-only charlieleith-fix/presets-trailing-comma
git switch master
git merge charlieleith-fix/presets-trailing-comma
git push origin master
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Adamcake/Bolt!54
Reference in a new issue
Adamcake/Bolt
No description provided.
Delete branch "charlieleith/Bolt:fix/presets-trailing-comma"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?