Ran clang-tidy -fix for all the cxx/hxx files in src and app. #20

smithcol11 commented 2026年01月14日 05:18:37 +01:00

Apologies in advance for the monster PR here. It consists entirely of clang-tidy fixes; avoiding any functional change.

After all the auto fixes were applied, I spent some time doing a few more linter suggestions. The goal was to fix items that didn't change functionality.

• Change a few reinterpret casts
• Give function declarations named variables
• More liberally use const references
• Cleanup some pointer arithmetic (although there are more to fix)
• Change some typedefs and defines to their cpp counterparts
• Replace deprecated macros
• Narrowing (there are more though)
• More I am forgetting

There are still plenty clang tidy warnings, but some require delicate refactors, type changes, and more cpp idomatic code.

As a result of touching many lines, I thought it fitting to also give the .clang-format some reasonable rules. I gave it rules similar to the .editorconfig. Then I allowed the formatter to modify only lines that I touched. It may be worth doing a larger format over the whole codebase, but I didn't want to own all of those changes. I think some checkin rules or git action can do that without changing the line owner.

Final note, I did not test this on Windows but didn't see any lines that would have effected a Win build. Worth checking for sure.

Let me know what you think, cheers.

Apologies in advance for the monster PR here. It consists entirely of `clang-tidy` fixes; avoiding any functional change. After all the auto fixes were applied, I spent some time doing a few more linter suggestions. The goal was to fix items that didn't change functionality. - Change a few reinterpret casts - Give function declarations named variables - More liberally use const references - Cleanup some pointer arithmetic (although there are more to fix) - Change some typedefs and defines to their cpp counterparts - Replace deprecated macros - Narrowing (there are more though) - More I am forgetting There are still plenty clang tidy warnings, but some require delicate refactors, type changes, and more cpp idomatic code. As a result of touching many lines, I thought it fitting to also give the `.clang-format` some reasonable rules. I gave it rules similar to the `.editorconfig`. Then I allowed the formatter to modify only lines that I touched. It may be worth doing a larger format over the whole codebase, but I didn't want to own all of those changes. I think some checkin rules or git action can do that without changing the line owner. **Final note, I did not test this on Windows but didn't see any lines that would have effected a Win build. Worth checking for sure.** Let me know what you think, cheers.

Adamcake commented 2026年01月19日 16:51:23 +01:00

There are some instances of spaces being replaced by tabs, but only for the lines of code that were actually changed by clang.

Come to think of it, is there a way for it to actively replace tabs with 4x spaces?

There are some instances of spaces being replaced by tabs, but only for the lines of code that were actually changed by clang. Come to think of it, is there a way for it to actively replace tabs with 4x spaces?

Adamcake commented 2026年01月19日 16:53:19 +01:00

Not sure why it has replaced all instances of std::endl with '\n'. This wouldn't be a correct change on Windows, although I don't think there are any cases in this PR where it the incorrectness would actually affect anything.

Not sure why it has replaced all instances of `std::endl` with `'\n'`. This wouldn't be a correct change on Windows, although I don't think there are any cases in this PR where it the incorrectness would actually affect anything.

Adamcake commented 2026年01月19日 17:00:23 +01:00

PointerAlignment=Left please. I know it's divisive, but it's how I write pointers and it's also how CEF writes them.

[PointerAlignment=Left](https://clang.llvm.org/docs/ClangFormatStyleOptions.html#pointeralignment) please. I know it's divisive, but it's how I write pointers and it's also how CEF writes them.

smithcol11 commented 2026年01月19日 18:04:35 +01:00

Hey, thanks for taking a look. Addressing your comments:

1. Yeah your editor config mentioned tabs, so I had clang-format do all indentation in tabs. This can be changed to spaces if you would like?
2. Perhaps it is a performance thing? My understanding of std::endl vs \n is that the endl will flush the buffer, which isn't always necessary (but is that performance even a concern here; we could remove that rule from clang-tidy). A second thing to note, '\n' should be fine on Windows; I think it is cross platform safe and gets converted to the the proper end line sequence for the target.
3. Sure I will change that. I actually agree with you and prefer the left aligned pointer. I didn't want to make too many assumptions / bloat the format file unless it was something you really wanted; I will add that.

Hey, thanks for taking a look. Addressing your comments: 1. Yeah your editor config mentioned tabs, so I had clang-format do all indentation in tabs. This can be changed to spaces if you would like? 2. Perhaps it is a performance thing? My understanding of std::endl vs \n is that the endl will flush the buffer, which isn't always necessary (but is that performance even a concern here; we could remove that rule from clang-tidy). A second thing to note, '\n' should be fine on Windows; I think it is cross platform safe and gets converted to the the proper end line sequence for the target. 3. Sure I will change that. I actually agree with you and prefer the left aligned pointer. I didn't want to make too many assumptions / bloat the format file unless it was something you really wanted; I will add that.

smithcol11 commented 2026年01月24日 17:42:21 +01:00

@Adamcake I changed the clang-format style to be Chromium based, with the modifications to tabs and pointer alignment.
Then I reset back one commit and redid the formatting on just my changes.

Let me know what you think, cheers.

@Adamcake I changed the clang-format style to be Chromium based, with the modifications to tabs and pointer alignment. Then I reset back one commit and redid the formatting on just my changes. Let me know what you think, cheers.

smithcol11 commented 2026年06月04日 18:26:01 +02:00

@Adamcake Wanted to follow up with this. I noticed since opening this, some clang-tidy checks have been added, and the formatting is still disabled. If you aren't interested in the auto formats and lint fixes I made, let me know and I can close this!

@Adamcake Wanted to follow up with this. I noticed since opening this, some clang-tidy checks have been added, and the formatting is still disabled. If you aren't interested in the auto formats and lint fixes I made, let me know and I can close this!

This pull request has changes conflicting with the target branch.