1lab/mikan
13
52
Fork
You've already forked mikan
9

Pragmas like INLINE and NOT_PROJECTION_LIKE can apply to definitions outside the current module #90

Closed
opened 2026年05月08日 15:47:51 +02:00 by amyliao · 0 comments

The code for checking the pragmas and actually making the change is here:

Function{} -> markStatic x

There is an isLocal in Mikan.TypeChecking.Monad.Signature which can be used to check if the name is... local, to the current top-level module. So all of those pragmas should emit a UselessPragma vs. have an effect depending on whether isLocal qn. And when that's done we can kill modifyGlobalDefinition.

The code for checking the pragmas and actually making the change is here: https://codeberg.org/1lab/mikan/src/commit/ba434684cacbd17a3ef1916302ed51b79e35d4fb/src/full/Mikan/TypeChecking/Rules/Decl.hs#L789 There is an `isLocal` in `Mikan.TypeChecking.Monad.Signature` which can be used to check if the name is... local, to the current top-level module. So all of those pragmas should emit a `UselessPragma` vs. have an effect depending on whether `isLocal qn`. And when that's done we can kill `modifyGlobalDefinition`.
Sign in to join this conversation.
No Branch/Tag specified
main
aliao/occurs-opt
aliao/rec-con
fix-license
aliao/oopsie
aliao/strengthen-iapply
No results found.
Labels
Clear labels
1 - scope
language
 Backwards-compatible changes to the surface language, such as adding new features.
1 - scope
language change
 Breaking changes to a documented part of the surface language. These should be documented and specifically called out in the changelog.
1 - scope
performance
 Semantics-preserving performance work.
1 - scope
task
 Changes that are not apparent to the user, e.g. developer documentation and refactors, which do not need to be documented.
A: dead-code
Dead code elimination and --save-metas.
A: errors
Reporting of error and warning messages.
A: highlighting
Highlighting during interaction & literate compilation
A: imports
Handling of imports and interface file de/serialization.
A: infra
Iinfrastructure (e.g. CI, developer documentation, the build system, or the repository itself)
A: instance
Instance declarations, arguments, and resolution
A: lhs
LHS checking, coverage checking, and clause compilation
A: modules
Declaration and instantiation of parametrised modules.
A: parallel
Parallel typechecking.
A: positivity
Positivity checking
A: printing
Pretty-printing, display forms, and the wording of diagnostic messages
A: records
Record declarations, record expressions and copattern matching
A: scoping
Scope checking (ConcreteToAbstract)
A: termination
Termination checking
0 - type
bug
 Issues describing an incorrect behaviour in the project, typos in the documentation, etc.
0 - type
discussion
 An issue raised to gather opinions on a proposed change, or a suggested language change.
0 - type
question
 An issue raised to ask a question.
9 - status
duplicate
 This issue or pull request already exists.
9 - status
info needed
 More information is needed from the submitter to decide how to proceed with the issue report.
9 - status
invalid
 The issue report or pull request does not describe an actual bug, or does otherwise does not meet the contributing guidelines.
good first issue
Interested in contributing? Get started here.
upstream
Related to an upstream repository, already reported there
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
1lab/mikan#90
Reference in a new issue
1lab/mikan
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?