Message 220514 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	taleinat
Recipients	Saimadhav.Heblikar, jesstess, taleinat, terry.reedy
Date	2014年06月13日.23:51:17
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1402703477.65.0.583535388786.issue21696@psf.upfronthosting.co.za>

Content
I've done a thorough review of the tests. The overall structure and tests are fine, but I found quite a few issues that should be addressed. Saimadhav, considering these are some of the first tests you've written, please know that I am impressed! I have many comments because I believe our tests should be excellent and I'm a bit pedantic. However I've seen many people write poorer test suites after despite having considerable experience. So keep up the good work, learn from our feedback and everything will be great!

Content

I've done a thorough review of the tests. The overall structure and tests are fine, but I found quite a few issues that should be addressed.
Saimadhav, considering these are some of the first tests you've written, please know that I am impressed! I have many comments because I believe our tests should be excellent and I'm a bit pedantic. However I've seen many people write poorer test suites after despite having considerable experience. So keep up the good work, learn from our feedback and everything will be great!

History
Date	User	Action	Args
2014年06月13日 23:51:17	taleinat	set	recipients: + taleinat, terry.reedy, jesstess, Saimadhav.Heblikar
2014年06月13日 23:51:17	taleinat	set	messageid: <1402703477.65.0.583535388786.issue21696@psf.upfronthosting.co.za>
2014年06月13日 23:51:17	taleinat	link	issue21696 messages
2014年06月13日 23:51:17	taleinat	create

homepage