This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2014年06月08日 20:11 by terry.reedy, last changed 2022年04月11日 14:58 by admin.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| test-configuration.diff | Saimadhav.Heblikar, 2014年06月11日 14:08 | review | ||
| test-configuration-v2.diff | Saimadhav.Heblikar, 2014年06月15日 05:54 | Update patch as per Rietveld comments. | review | |
| Messages (6) | |||
|---|---|---|---|
| msg220053 - (view) | Author: Terry J. Reedy (terry.reedy) * (Python committer) | Date: 2014年06月08日 20:11 | |
Spinoff of #12274 and a dependency thereof: new test_configurations.py should statically test that configparser, called from idlelib.configHandler, can process all the configuration.def files without error. |
|||
| msg220225 - (view) | Author: Terry J. Reedy (terry.reedy) * (Python committer) | Date: 2014年06月11日 01:48 | |
The format paragraph entry in main.def is being moved to extensions.def, so don't test for it in main.def. |
|||
| msg220271 - (view) | Author: Saimadhav Heblikar (Saimadhav.Heblikar) * | Date: 2014年06月11日 14:08 | |
Attaching a patch to test the default configuration files. config-keys.def will be added once the issues related to it[1] are resolved. In this patch, test that the configHandler module can successfully extract the values. For places where numeric values are expected, ensure that the values are correct. For strings, it only ensures that the values are reasonably correct. ---- [1] https://mail.python.org/pipermail/idle-dev/2014-June/003431.html |
|||
| msg220514 - (view) | Author: Tal Einat (taleinat) * (Python committer) | Date: 2014年06月13日 23:51 | |
I've done a thorough review of the tests. The overall structure and tests are fine, but I found quite a few issues that should be addressed. Saimadhav, considering these are some of the first tests you've written, please know that I am impressed! I have many comments because I believe our tests should be excellent and I'm a bit pedantic. However I've seen many people write poorer test suites after despite having considerable experience. So keep up the good work, learn from our feedback and everything will be great! |
|||
| msg228258 - (view) | Author: Terry J. Reedy (terry.reedy) * (Python committer) | Date: 2014年10月02日 20:57 | |
I closed #12274, but it might be consulted before closing this. |
|||
| msg360837 - (view) | Author: Terry J. Reedy (terry.reedy) * (Python committer) | Date: 2020年01月28日 04:10 | |
The issue is obsolete with respect to the minimal test implied by the opening message. At least two tests (added since this was written) read the .def files.
Some of the proposed tests are, now at least, redundant For boolean tests like
self.assertIn(get('editor-on-startup', 'bool'), (True, False))
a non-boolean value results in a Warning (treated like error), the assert, and remaining tests are skipped, and IDLD hangs. Stripping strings should not be needed.
Some of the tests should be part of a startup check of default *and* user options. Values should also be checked when changed (they mostly are).
Since new options have been added, some tests are missing.
I would like to have a 3-layer option map that can be used for both runtime change and the test suite.
|
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:58:04 | admin | set | github: 65895 |
| 2020年01月28日 04:10:53 | terry.reedy | set | messages: + msg360837 |
| 2019年03月20日 16:43:50 | terry.reedy | set | components:
+ IDLE versions: + Python 3.7, Python 3.8, - Python 2.7, Python 3.4, Python 3.5 |
| 2017年09月28日 07:00:41 | taleinat | set | nosy:
- taleinat |
| 2014年10月02日 20:57:16 | terry.reedy | set | messages: + msg228258 |
| 2014年10月02日 20:56:09 | terry.reedy | unlink | issue12274 dependencies |
| 2014年06月15日 05:54:54 | Saimadhav.Heblikar | set | files: + test-configuration-v2.diff |
| 2014年06月13日 23:51:17 | taleinat | set | nosy:
+ taleinat messages: + msg220514 |
| 2014年06月11日 17:55:22 | terry.reedy | set | title: Idle: test syntax of configuration files -> Idle: test configuration files |
| 2014年06月11日 14:08:33 | Saimadhav.Heblikar | set | files:
+ test-configuration.diff keywords: + patch messages: + msg220271 |
| 2014年06月11日 01:48:22 | terry.reedy | set | nosy:
+ jesstess messages: + msg220225 |
| 2014年06月08日 20:17:25 | terry.reedy | link | issue12274 dependencies |
| 2014年06月08日 20:11:35 | terry.reedy | create | |