This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2017年06月26日 22:38 by terry.reedy, last changed 2022年04月11日 14:58 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 2606 | merged | terry.reedy, 2017年07月06日 19:45 | |
| PR 2613 | merged | terry.reedy, 2017年07月07日 03:04 | |
| PR 2046 | cheryl.sabella, 2017年08月27日 06:04 | ||
| PR 3222 | closed | cheryl.sabella, 2017年08月27日 21:33 | |
| PR 3238 | cheryl.sabella, 2017年09月11日 02:40 | ||
| PR 3592 | merged | cheryl.sabella, 2017年09月14日 23:29 | |
| PR 18218 | merged | miss-islington, 2020年01月27日 22:16 | |
| PR 18219 | merged | miss-islington, 2020年01月27日 22:18 | |
| Messages (18) | |||
|---|---|---|---|
| msg296963 - (view) | Author: Terry J. Reedy (terry.reedy) * (Python committer) | Date: 2017年06月26日 22:38 | |
A complete test of the GUI will simulate user interaction with every widget and then query Changes() to see that the proper changes orders have been recorded. This issue depends on #30779, factor out Changes class. |
|||
| msg297016 - (view) | Author: Terry J. Reedy (terry.reedy) * (Python committer) | Date: 2017年06月27日 06:54 | |
Tests should be tested on MacOS before being pushed. A possible issue is including constants that are different on different systems. See #28572 |
|||
| msg297247 - (view) | Author: Louie Lu (louielu) * | Date: 2017年06月29日 03:18 | |
I'm trying to add the test on configdialog, currently working on KeysTest. |
|||
| msg297250 - (view) | Author: Terry J. Reedy (terry.reedy) * (Python committer) | Date: 2017年06月29日 03:35 | |
Proceed as you want. Keep in mind that the interface to the changes structure will be changed by #30779. The testing logic should not be, however. |
|||
| msg297838 - (view) | Author: Terry J. Reedy (terry.reedy) * (Python committer) | Date: 2017年07月06日 19:46 | |
PR to fix type in moduleTearDown. |
|||
| msg297852 - (view) | Author: Terry J. Reedy (terry.reedy) * (Python committer) | Date: 2017年07月07日 02:19 | |
New changeset 25a4206c243e3b1fa6f5b1c72a11b409b007694d by terryjreedy in branch 'master': bpo-30780: Fix error in idlelib.test_idle.test_configdialog (#2606) https://github.com/python/cpython/commit/25a4206c243e3b1fa6f5b1c72a11b409b007694d |
|||
| msg297853 - (view) | Author: Terry J. Reedy (terry.reedy) * (Python committer) | Date: 2017年07月07日 02:46 | |
I posted PR 2612 for #30779 and expect to merge it tomorrow after sleep and final review. It includes passing revisions of existing configdialog tests. A PR dependent on 2612 could be posted before I do the merge. Follow the model of using xyzpage names in asserts and tests would survive the refactoring of ConfigChanges discussed as a possibility on #30779. I want to move forward on this, but not duplicate your work, so please post work done and immediate plans. |
|||
| msg297855 - (view) | Author: Terry J. Reedy (terry.reedy) * (Python committer) | Date: 2017年07月07日 03:16 | |
New changeset df0f99329843c10701ffaefbd3948ac698c12220 by terryjreedy in branch '3.6': [3.6] bpo-30780: Fix error in idlelib.test_idle.test_configdialog (GH-2606) (#2613) https://github.com/python/cpython/commit/df0f99329843c10701ffaefbd3948ac698c12220 |
|||
| msg300906 - (view) | Author: Terry J. Reedy (terry.reedy) * (Python committer) | Date: 2017年08月26日 20:15 | |
This issue is almost done. There are just a few things missed by the closed dependencies. |
|||
| msg300922 - (view) | Author: Terry J. Reedy (terry.reedy) * (Python committer) | Date: 2017年08月27日 19:29 | |
#31001 and #31002 have notes on what not tested in HighPage and KeysPage. |
|||
| msg301037 - (view) | Author: Cheryl Sabella (cheryl.sabella) * (Python committer) | Date: 2017年08月30日 22:30 | |
I've started working on the missing tests for HighPage and KeysPage and also test for the functions and buttons in ConfigDialog. That led to PR3238 because the 'help' button wasn't working. Anyway, I found the following on http://effbot.org/tkinterbook/tkinter-events-and-bindings.htm: "An easier solution is to prevent Tkinter from propagating the event to other handlers; just return the string "break" from your event handler: def ignore(event): return "break" text.bind("<Return>", ignore) or text.bind("<Return>", lambda e: "break")" So, it seems that the 'Double-Button-1' and 'B1-Motion' bindings are to prevent those events from propagating outside of the widget. Although, I didn't notice a difference when I commented them out, so maybe they don't have a higher level binding. |
|||
| msg301849 - (view) | Author: Terry J. Reedy (terry.reedy) * (Python committer) | Date: 2017年09月11日 02:46 | |
I just pushed the extension conversion patch. The tests we did already were greatly helpful, and some tests not done or inadequate hindered. I am now looking to polish configdialog before 3.6.3. If you have anything worth a new issue and PR, I will be ready to review. |
|||
| msg302171 - (view) | Author: Cheryl Sabella (cheryl.sabella) * (Python committer) | Date: 2017年09月14日 13:50 | |
Sorry I don't have any tests yet. I've added a few, but it's taking me forever to figure out the bindings for testing the `Double-Button-1` and `B1-Motion`. I actually have a test for `Double-Button-1` now, but still working on `B1-Motion`. |
|||
| msg302225 - (view) | Author: Cheryl Sabella (cheryl.sabella) * (Python committer) | Date: 2017年09月14日 23:42 | |
I've submitted a PR for the tests that I added to complete coverage for Keys and Highlights and to add some GUI tests for the buttons. It's not everything that I wanted to do, but it ended up being more substantial than I realized. Here's the issue I was having with testing `Double-Button-1` and `B1-Motion`. After the first ButtonPress and ButtonRelease, the second (or later) event-generate always looked like it was a double click (it probably was really a triple click or higher, depending how many times I tried it). I tried everything I could think of or find online, but I couldn't find how to reset the counts to start over and make it think it was a just `ButtonPress` and not a `Double-Button`. This was OK for the testing on `Double-Button`, but it was causing the `B1-Motion` not to work because it was not seeing each 'movement' as a press/move/release, but rather a double-button/move/release. It was OK because the Double also invokes the Press callback, however, since the Double event was bound to `break`, it didn't allow the text to be selected. (The difference between `Double` and `B1-Motion` is that Double selects a word and B1-Motion selects where the mouse moves). I played with it in IDLE and I could reset the Press by doing an event-generate on a different (x, y), but that didn't work in the test. I tried a delay and it still didn't fix it. Anyway, I've learned a lot about mouse binding while working on this, but without a solution, I cheated and just did ButtonPress on a different (x, y) for the second test. Sorry about the rambling, but I'd love to know the trick to resetting the number of button presses in a test. |
|||
| msg307206 - (view) | Author: Terry J. Reedy (terry.reedy) * (Python committer) | Date: 2017年11月29日 03:43 | |
Review of overview: PR-2706 and PR-2613 fixed one line in test_configdialog for this issue. PR-2046, #30617 and PR-3238, #30781 are merged cross-references. PR-3222 was closed in favor of PR-3220, #31287, merged. PR-3592 completes highlights and keys coverage and needs my review after getting lost in the flurry of PRs. Dependency #31414 has merged PRs. I should review, close, or indicate what is left to do. Other dependencies are closed and I believe this should be after handling above 2 items. |
|||
| msg360810 - (view) | Author: Terry J. Reedy (terry.reedy) * (Python committer) | Date: 2020年01月27日 22:16 | |
New changeset dd023ad1619b6f1ab313986e8953eea32c18f50c by Terry Jan Reedy (Cheryl Sabella) in branch 'master': bpo-30780: Add IDLE configdialog tests (#3592) https://github.com/python/cpython/commit/dd023ad1619b6f1ab313986e8953eea32c18f50c |
|||
| msg360815 - (view) | Author: miss-islington (miss-islington) | Date: 2020年01月27日 22:31 | |
New changeset 5aefee6f989821c5dc36d10a9cfd083d7aa737a5 by Miss Islington (bot) in branch '3.7': bpo-30780: Add IDLE configdialog tests (GH-3592) https://github.com/python/cpython/commit/5aefee6f989821c5dc36d10a9cfd083d7aa737a5 |
|||
| msg360816 - (view) | Author: miss-islington (miss-islington) | Date: 2020年01月27日 22:35 | |
New changeset 7b57b15bd83879ee35f8758a84a7857a9968c145 by Miss Islington (bot) in branch '3.8': bpo-30780: Add IDLE configdialog tests (GH-3592) https://github.com/python/cpython/commit/7b57b15bd83879ee35f8758a84a7857a9968c145 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:58:48 | admin | set | github: 74963 |
| 2020年01月27日 23:38:45 | terry.reedy | set | status: open -> closed stage: patch review -> resolved resolution: fixed versions: + Python 3.8, Python 3.9, - Python 3.6 |
| 2020年01月27日 22:35:12 | miss-islington | set | messages: + msg360816 |
| 2020年01月27日 22:31:40 | miss-islington | set | nosy:
+ miss-islington messages: + msg360815 |
| 2020年01月27日 22:18:00 | miss-islington | set | pull_requests: + pull_request17599 |
| 2020年01月27日 22:16:12 | miss-islington | set | pull_requests: + pull_request17598 |
| 2020年01月27日 22:16:03 | terry.reedy | set | messages: + msg360810 |
| 2017年11月29日 03:43:48 | terry.reedy | set | messages: + msg307206 |
| 2017年09月14日 23:42:41 | cheryl.sabella | set | messages: + msg302225 |
| 2017年09月14日 23:29:57 | cheryl.sabella | set | pull_requests: + pull_request3583 |
| 2017年09月14日 13:50:25 | cheryl.sabella | set | messages: + msg302171 |
| 2017年09月11日 03:18:11 | terry.reedy | set | dependencies: + IDLE: Entry tests should delete before insert. |
| 2017年09月11日 02:46:26 | terry.reedy | set | messages: + msg301849 |
| 2017年09月11日 02:40:00 | cheryl.sabella | set | keywords:
+ patch stage: test needed -> patch review pull_requests: + pull_request3480 |
| 2017年09月02日 03:38:08 | terry.reedy | unlink | issue27099 dependencies |
| 2017年08月30日 22:30:11 | cheryl.sabella | set | messages: + msg301037 |
| 2017年08月27日 21:33:41 | cheryl.sabella | set | pull_requests: + pull_request3264 |
| 2017年08月27日 19:29:08 | terry.reedy | set | messages: + msg300922 |
| 2017年08月27日 19:26:31 | terry.reedy | set | nosy:
+ cheryl.sabella dependencies: + IDLE configdialog tests: don't modify tkinter.messagebox. |
| 2017年08月27日 06:04:40 | cheryl.sabella | set | pull_requests: + pull_request3255 |
| 2017年08月26日 20:15:49 | terry.reedy | set | messages: + msg300906 |
| 2017年08月26日 20:14:28 | terry.reedy | unlink | issue30781 dependencies |
| 2017年07月24日 08:05:37 | terry.reedy | set | dependencies: + IDLE: Add tests for configdialog highlight tab, IDLE: Add tests for configdialog keys tab, IDLE: Add tests for help sources on configdialog general tab |
| 2017年07月22日 19:34:38 | terry.reedy | set | dependencies: + IDLE: Document, fix, and complete configdialog font tests |
| 2017年07月21日 03:17:13 | terry.reedy | set | dependencies: + IDLE: Test config dialog font bold button and sample change |
| 2017年07月10日 19:15:04 | terry.reedy | unlink | issue30851 dependencies |
| 2017年07月10日 18:47:55 | terry.reedy | set | dependencies: + IDLE: configdialog/fonts: change font when select by key up/down |
| 2017年07月07日 03:16:33 | terry.reedy | set | messages: + msg297855 |
| 2017年07月07日 03:04:41 | terry.reedy | set | pull_requests: + pull_request2678 |
| 2017年07月07日 02:46:49 | terry.reedy | set | messages: + msg297853 |
| 2017年07月07日 02:19:15 | terry.reedy | set | messages: + msg297852 |
| 2017年07月06日 19:46:44 | terry.reedy | set | messages: + msg297838 |
| 2017年07月06日 19:45:57 | terry.reedy | set | pull_requests: + pull_request2673 |
| 2017年07月05日 01:26:11 | terry.reedy | link | issue30851 dependencies |
| 2017年06月30日 22:38:18 | terry.reedy | link | issue27099 dependencies |
| 2017年06月29日 03:35:36 | terry.reedy | set | messages: + msg297250 |
| 2017年06月29日 03:18:05 | louielu | set | nosy:
+ louielu messages: + msg297247 |
| 2017年06月27日 06:54:35 | terry.reedy | set | messages: + msg297016 |
| 2017年06月27日 00:46:41 | terry.reedy | link | issue30728 dependencies |
| 2017年06月26日 22:47:38 | terry.reedy | link | issue30781 dependencies |
| 2017年06月26日 22:39:41 | terry.reedy | set | assignee: terry.reedy dependencies: + IDLE: configdialog -- factor out Changes class components: + IDLE |
| 2017年06月26日 22:38:31 | terry.reedy | create | |