This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2016年08月30日 15:44 by nnnnnn, last changed 2022年04月11日 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| spelling3.patch | nnnnnn, 2016年08月30日 15:52 | review | ||
| Messages (10) | |||
|---|---|---|---|
| msg273942 - (view) | Author: Raymond Hettinger (rhettinger) * (Python committer) | Date: 2016年08月30日 17:46 | |
Thanks for the patch. Some of these were a bit embarrassing. Removed the Lib/test/decimaltestdata because this is from an external source (not our code) that is periodically refreshed. I had to hand edit some of the changes to test_asyncio because the patch was breaking those tests for some reason. I had some hesitancy about changing function or variable names in real code and had to spend time looking at each in detail but they all seem legitimate. |
|||
| msg273944 - (view) | Author: Roundup Robot (python-dev) (Python triager) | Date: 2016年08月30日 17:48 | |
New changeset 75d6d5d9b674 by Raymond Hettinger in branch 'default': Issue #27895: Spelling fixes (Contributed by Ville Skyttä). https://hg.python.org/cpython/rev/75d6d5d9b674 |
|||
| msg273945 - (view) | Author: Raymond Hettinger (rhettinger) * (Python committer) | Date: 2016年08月30日 17:50 | |
FYI, the patch did not apply cleanly to Python 3.5 so this was applied to 3.6 only. If someone feels this is important to them, they are welcome to backport the applicable parts of the patch. |
|||
| msg273961 - (view) | Author: Roundup Robot (python-dev) (Python triager) | Date: 2016年08月30日 19:57 | |
New changeset 89ce78ce1bfa by Raymond Hettinger in branch 'default': Issue #27895: Strengthen the dict reader tests. https://hg.python.org/cpython/rev/89ce78ce1bfa |
|||
| msg273972 - (view) | Author: (nnnnnn) * | Date: 2016年08月30日 21:42 | |
Right, I noticed the asyncio test breakage as well, that was one of the reasons I attached a couple of versions of the patch. spelling3 was not supposed to contain the breaking changes any more, maybe you worked on an earlier one? Anyway, thanks. |
|||
| msg273997 - (view) | Author: Martin Panter (martin.panter) * (Python committer) | Date: 2016年08月31日 04:15 | |
Be careful with user-visible changes to the code, like the _encoded_EMTPY attribute (Issue 27630). I wouldn’t backport that. |
|||
| msg274002 - (view) | Author: (nnnnnn) * | Date: 2016年08月31日 06:43 | |
@rhettinger, the test_asyncio thing I mentioned is now taken care of in #27907. |
|||
| msg274014 - (view) | Author: R. David Murray (r.david.murray) * (Python committer) | Date: 2016年08月31日 10:41 | |
Good point, Martin, but I'd actually be OK with backporting that particular one. It is relatively new, and I doubt anyone is using it. Sorry for dropping the ball on the other issue. |
|||
| msg274915 - (view) | Author: Roundup Robot (python-dev) (Python triager) | Date: 2016年09月07日 23:42 | |
New changeset ff3df2b1ac7f by Martin Panter in branch '3.5': Issue #27895: Spelling fixes (Contributed by Ville Skyttä). https://hg.python.org/cpython/rev/ff3df2b1ac7f |
|||
| msg274968 - (view) | Author: Roundup Robot (python-dev) (Python triager) | Date: 2016年09月08日 05:42 | |
New changeset 9a68ab141c33 by Martin Panter in branch '2.7': Issue #27895: Spelling fixes (Contributed by Ville Skyttä). https://hg.python.org/cpython/rev/9a68ab141c33 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:58:35 | admin | set | github: 72082 |
| 2016年09月08日 05:50:21 | martin.panter | set | versions: + Python 2.7, Python 3.5 |
| 2016年09月08日 05:42:52 | python-dev | set | messages: + msg274968 |
| 2016年09月07日 23:42:51 | python-dev | set | messages: + msg274915 |
| 2016年08月31日 10:41:57 | r.david.murray | set | nosy:
+ r.david.murray messages: + msg274014 |
| 2016年08月31日 06:43:04 | nnnnnn | set | messages: + msg274002 |
| 2016年08月31日 06:13:05 | SilentGhost | set | stage: resolved |
| 2016年08月31日 04:15:30 | martin.panter | set | nosy:
+ martin.panter messages: + msg273997 versions: + Python 3.6 |
| 2016年08月30日 21:42:47 | nnnnnn | set | messages: + msg273972 |
| 2016年08月30日 19:57:34 | python-dev | set | messages: + msg273961 |
| 2016年08月30日 17:50:54 | rhettinger | set | status: open -> closed resolution: fixed messages: + msg273945 |
| 2016年08月30日 17:48:06 | python-dev | set | nosy:
+ python-dev messages: + msg273944 |
| 2016年08月30日 17:46:00 | rhettinger | set | messages: + msg273942 |
| 2016年08月30日 16:42:36 | rhettinger | set | assignee: docs@python -> rhettinger nosy: + rhettinger |
| 2016年08月30日 15:52:16 | nnnnnn | set | files: - spelling2.patch |
| 2016年08月30日 15:52:00 | nnnnnn | set | files: + spelling3.patch |
| 2016年08月30日 15:49:58 | nnnnnn | set | files: + spelling2.patch |
| 2016年08月30日 15:49:19 | nnnnnn | set | files: - spelling.patch |
| 2016年08月30日 15:44:26 | nnnnnn | create | |