homepage

test_strptime fails on an android emulator running an x86 system image at API level 21.
See the attached test_output.txt file.

What is the output of following code?
import datetime
for i in range(1, 10):
 print(datetime.date(1905, 1, i).strftime('%Y %U %w %G %V %u'))

root@generic_x86:/data/local/tmp # python
Python 3.6.0a0 (default:f4c6dab59cd8+, May 3 2016, 21:59:47) 
[GCC 4.9 20140827 (prerelease)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import datetime
>>> for i in range(1, 10):
... print(datetime.date(1905, 1, i).strftime('%Y %U %w %G %V %u'))
... 
1905 01 0 1904 53 7
1905 01 1 1905 01 1
1905 01 2 1905 01 2
1905 01 3 1905 01 3
1905 01 4 1905 01 4
1905 01 5 1905 01 5
1905 01 6 1905 01 6
1905 02 0 1905 01 7
1905 02 1 1905 02 1
>>>

Thanks. And what is the output of following code?
for i in range(25, 32):
 print(datetime.date(1904, 12, i).strftime('%Y %U %w %G %V %u'))

>>> for i in range(25, 32):
... print(datetime.date(1904, 12, i).strftime('%Y %U %w %G %V %u'))
... 
1904 52 0 1904 51 7
1904 52 1 1904 52 1
1904 52 2 1904 52 2
1904 52 3 1904 52 3
1904 52 4 1904 52 4
1904 52 5 1904 52 5
1904 52 6 1904 52 6
>>>

Thus there is a gap between 1904年12月31日 and 1905年1月1日. This is a bug in strftime() on Android.

GNU libc says:
 ‘%V’
 The ISO 8601:1988 week number as a decimal number (range ‘01’
 through ‘53’). ISO weeks start with Monday and end with
 Sunday. Week ‘01’ of a year is the first week which has the
 majority of its days in that year; this is equivalent to the
 week containing the year’s first Thursday, and it is also
 equivalent to the week containing January 4. Week ‘01’ of a
 year can contain days from the previous year. The week before
 week ‘01’ of a year is the last week (‘52’ or ‘53’) of the
 previous year even if it contains days from the new year.
 This format was first standardized by POSIX.2-1992 and by
 ISO C99.
So on 1905年1月1日, %V should be 52 instead of 53 as printed by android; is this the only bug ?
A pretty good test to find such a mistake.

There is other bug at the last week of a year:
import datetime
for i in range(25, 32):
 print(datetime.date(1906, 12, i).strftime('%Y %U %w %G %V %u'))
for i in range(1, 10):
 print(datetime.date(1907, 1, i).strftime('%Y %U %w %G %V %u'))

Here is the result of running on android:
<script>
import datetime
for y in (1904, 1906, 2008, 1917):
 for i in range(25, 32):
 print(datetime.date(y, 12, i).strftime('%Y %U %w %G %V %u'))
 print()
 for i in range(1, 10):
 print(datetime.date(y + 1, 1, i).strftime('%Y %U %w %G %V %u'))
 print('=====================')
<script>
root@generic_x86:/data/local/tmp # python strftime.py
1904 52 0 1904 51 7
1904 52 1 1904 52 1
1904 52 2 1904 52 2
1904 52 3 1904 52 3
1904 52 4 1904 52 4
1904 52 5 1904 52 5
1904 52 6 1904 52 6
1905 01 0 1904 53 7
1905 01 1 1905 01 1
1905 01 2 1905 01 2
1905 01 3 1905 01 3
1905 01 4 1905 01 4
1905 01 5 1905 01 5
1905 01 6 1905 01 6
1905 02 0 1905 01 7
1905 02 1 1905 02 1
=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ
1906 51 2 1906 52 2
1906 51 3 1906 52 3
1906 51 4 1906 52 4
1906 51 5 1906 52 5
1906 51 6 1906 52 6
1906 52 0 1906 52 7
1906 52 1 1907 53 1
1907 00 2 1907 01 2
1907 00 3 1907 01 3
1907 00 4 1907 01 4
1907 00 5 1907 01 5
1907 00 6 1907 01 6
1907 01 0 1907 01 7
1907 01 1 1907 02 1
1907 01 2 1907 02 2
1907 01 3 1907 02 3
=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ
2008 51 4 2008 52 4
2008 51 5 2008 52 5
2008 51 6 2008 52 6
2008 52 0 2008 52 7
2008 52 1 2009 53 1
2008 52 2 2009 53 2
2008 52 3 2009 53 3
2009 00 4 2009 01 4
2009 00 5 2009 01 5
2009 00 6 2009 01 6
2009 01 0 2009 01 7
2009 01 1 2009 02 1
2009 01 2 2009 02 2
2009 01 3 2009 02 3
2009 01 4 2009 02 4
2009 01 5 2009 02 5
=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ=わ
1917 51 2 1917 52 2
1917 51 3 1917 52 3
1917 51 4 1917 52 4
1917 51 5 1917 52 5
1917 51 6 1917 52 6
1917 52 0 1917 52 7
1917 52 1 1918 53 1
1918 00 2 1918 01 2
1918 00 3 1918 01 3
1918 00 4 1918 01 4
1918 00 5 1918 01 5
1918 00 6 1918 01 6
1918 01 0 1918 01 7
1918 01 1 1918 02 1
1918 01 2 1918 02 2
1918 01 3 1918 02 3
=====================

1904 52 6 1904 52 6
1905 01 0 1904 53 7
 ^^
1906 52 0 1906 52 7
1906 52 1 1907 53 1
 ^^^^
strftime() on Android incorrectly formats %V or %G for the last or the first incomplete week in a year.

Patch attached.

Entered new issue https://code.google.com/p/android/issues/detail?id=227388 on the AOSP issue tracker.

New patch following Serhiy comments.

exclude_ymd_3.patch LGTM.

Thanks Serhiy for your help with this issue.
I will push this patch with the other Android patches after 3.6 is released.

New changeset 3c6e5f83d235 by Xavier de Gaye in branch '3.6':
Issue #26929: Skip some test_strptime tests failing on Android that
https://hg.python.org/cpython/rev/3c6e5f83d235
New changeset 91e0cf7f8e30 by Xavier de Gaye in branch 'default':
Issue #26929: Merge 3.6
https://hg.python.org/cpython/rev/91e0cf7f8e30