This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2016年04月26日 13:49 by xdegaye, last changed 2022年04月11日 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| posixmodule.patch | xdegaye, 2016年04月26日 13:49 | review | ||
| posixmodule.patch | xdegaye, 2016年04月27日 09:47 | with a test of the android api level at compile time | review | |
| posixmodule_3.patch | xdegaye, 2016年06月05日 12:23 | review | ||
| Messages (12) | |||
|---|---|---|---|
| msg264287 - (view) | Author: Xavier de Gaye (xdegaye) * (Python triager) | Date: 2016年04月26日 13:49 | |
Revert the changeset commited at issue #20307 as the compilation does not fail anymore on android API level 21. Patch attached. |
|||
| msg264305 - (view) | Author: Stefan Krah (skrah) * (Python committer) | Date: 2016年04月26日 15:12 | |
@shiz: Can we settle on API level 21 or is there any reason to leave this in? |
|||
| msg264331 - (view) | Author: Gregory P. Smith (gregory.p.smith) * (Python committer) | Date: 2016年04月26日 21:23 | |
I have no problem just removing the #ifdef as Android API 21 is now old enough (Lollipop / 5.0) that anyone building Python 3.6 for use on Android is probably fine with it. If there is a #define that can be used to test the android api level at compile time, adding that to the #if is another approach and would keep people who are trying to run something on an older version happy. |
|||
| msg264366 - (view) | Author: Xavier de Gaye (xdegaye) * (Python triager) | Date: 2016年04月27日 09:47 | |
New patch taking into account Gregory's comments. API level 19 is the last to have a sys/linux-syscalls.h header. All levels have a android/api-level.h header that define __ANDROID_API__. There is no API level 20, and SYS_getdents64 is defined at API level 21. |
|||
| msg267414 - (view) | Author: Xavier de Gaye (xdegaye) * (Python triager) | Date: 2016年06月05日 12:23 | |
The patch is simpler since android/api-level.h is now included in pyport.h by changeset 09af54099973. |
|||
| msg268378 - (view) | Author: Stefan Krah (skrah) * (Python committer) | Date: 2016年06月12日 13:32 | |
posixmodule_3.patch looks good to me. Gregory has already approved the approach, so I think you can go ahead and commit this. |
|||
| msg268550 - (view) | Author: STINNER Victor (vstinner) * (Python committer) | Date: 2016年06月14日 11:40 | |
Stefan Krah: "posixmodule_3.patch looks good to me. Gregory has already approved the approach, so I think you can go ahead and commit this" I concur with Stefan: LGTM. |
|||
| msg268615 - (view) | Author: Roundup Robot (python-dev) (Python triager) | Date: 2016年06月15日 10:02 | |
New changeset 4ef3a93e1be2 by Xavier de Gaye in branch 'default': Issue #26862: SYS_getdents64 does not need to be defined on android API 21. https://hg.python.org/cpython/rev/4ef3a93e1be2 |
|||
| msg279604 - (view) | Author: Christopher Schramm (cschramm) | Date: 2016年10月28日 13:06 | |
Any plans to fix this in 3.5 as well? |
|||
| msg279606 - (view) | Author: (yan12125) * | Date: 2016年10月28日 14:26 | |
cschramm: AFAIK only Python 3.6+ has experimental Android support. 3.5 or below are not supported. |
|||
| msg279608 - (view) | Author: Xavier de Gaye (xdegaye) * (Python triager) | Date: 2016年10月28日 14:33 | |
Sorry, AFAIK there is no plan to retrofit the Android changes to 3.5. Note that Python 3.6 is expected to be released in few weeks, by next mid-december. |
|||
| msg279610 - (view) | Author: Christopher Schramm (cschramm) | Date: 2016年10月28日 15:54 | |
Well, the 3.5 code checks __ANDROID__ as well and works pretty fine on Android, but if it's not supposed to be supported, we'll have to upgrade to 3.6 then. Thanks for your work! :) |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:58:30 | admin | set | github: 71049 |
| 2016年10月28日 15:54:17 | cschramm | set | messages: + msg279610 |
| 2016年10月28日 14:33:51 | xdegaye | set | messages: + msg279608 |
| 2016年10月28日 14:26:29 | yan12125 | set | nosy:
+ yan12125 messages: + msg279606 |
| 2016年10月28日 13:06:47 | cschramm | set | nosy:
+ cschramm messages: + msg279604 |
| 2016年06月15日 10:04:53 | xdegaye | set | status: open -> closed resolution: fixed stage: commit review -> resolved |
| 2016年06月15日 10:02:36 | python-dev | set | nosy:
+ python-dev messages: + msg268615 |
| 2016年06月14日 11:40:59 | vstinner | set | nosy:
+ vstinner messages: + msg268550 |
| 2016年06月14日 10:16:54 | xdegaye | set | assignee: xdegaye stage: commit review |
| 2016年06月12日 13:32:03 | skrah | set | messages: + msg268378 |
| 2016年06月05日 12:23:34 | xdegaye | set | files:
+ posixmodule_3.patch messages: + msg267414 |
| 2016年05月03日 07:20:17 | xdegaye | set | title: SYS_getdents64 does not need to be defined on android API 21 -> android: SYS_getdents64 does not need to be defined on android API 21 |
| 2016年04月27日 09:47:09 | xdegaye | set | files:
+ posixmodule.patch messages: + msg264366 |
| 2016年04月26日 21:23:58 | gregory.p.smith | set | messages: + msg264331 |
| 2016年04月26日 16:04:41 | zach.ware | link | issue26865 dependencies |
| 2016年04月26日 16:02:57 | Roman.Evstifeev | set | nosy:
+ Roman.Evstifeev |
| 2016年04月26日 15:12:02 | skrah | set | nosy:
+ skrah messages: + msg264305 |
| 2016年04月26日 14:05:20 | berker.peksag | set | nosy:
+ gregory.p.smith |
| 2016年04月26日 13:49:48 | xdegaye | create | |