This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2015年09月19日 21:29 by serhiy.storchaka, last changed 2022年04月11日 14:58 by admin. This issue is now closed.
| Messages (7) | |||
|---|---|---|---|
| msg251119 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) | Date: 2015年09月19日 21:29 | |
venv writes pyvenv.cfg with utf-8 encoding, but site reads it with locale encoding. |
|||
| msg251141 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) | Date: 2015年09月20日 05:26 | |
Example: $ LC_ALL=ru_RU.cp1251 ./python -m venv ../vp×ばつ $ LC_ALL=ru_RU.cp1251 ./python -m venv ../vpyØ Error: 'charmap' codec can't encode character '\udc98' in position 617: character maps to <undefined> The first command is successful, the latter command is failed. 'Ø'.encode('utf-8') == b'\xc3\x98', and 0x98 is invalid code in CP1251. |
|||
| msg251292 - (view) | Author: Vinay Sajip (vinay.sajip) * (Python committer) | Date: 2015年09月22日 08:21 | |
Seems like the right fix would be to change site.py to read it using UTF-8. |
|||
| msg251776 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) | Date: 2015年09月28日 17:07 | |
I suspect that this can break backward compatibility. |
|||
| msg251781 - (view) | Author: Vinay Sajip (vinay.sajip) * (Python committer) | Date: 2015年09月28日 17:57 | |
> I suspect that this can break backward compatibility. But since venv writes it out as UTF-8 already, it should be read in UTF-8, and if it isn't, isn't that the cause of the error which led to this bug we're talking about? If we now write it with locale encoding, anything that previously assumed we were writing it in UTF-8 might break. While I'm not aware of any specific software which reads pyvenv.cfg other than the site.py code, there could well be third party code which does so. |
|||
| msg251783 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) | Date: 2015年09月28日 18:26 | |
I thought that pyvenv.cfg was used by venv's predecessor virtualenv. Now I see that I was wrong and your idea is right. |
|||
| msg252016 - (view) | Author: Roundup Robot (python-dev) (Python triager) | Date: 2015年10月01日 10:28 | |
New changeset d927c6cae05f by Vinay Sajip in branch '3.4': Closes #25185: Use UTF-8 encoding when reading pyvenv.cfg. https://hg.python.org/cpython/rev/d927c6cae05f New changeset eaf9220bdee3 by Vinay Sajip in branch '3.5': Closes #25185: merged fix from 3.4. https://hg.python.org/cpython/rev/eaf9220bdee3 New changeset 69dd42cef190 by Vinay Sajip in branch 'default': Closes #25185: merged fix from 3.5. https://hg.python.org/cpython/rev/69dd42cef190 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:58:21 | admin | set | github: 69372 |
| 2015年11月03日 09:09:20 | serhiy.storchaka | link | issue25540 superseder |
| 2015年10月01日 10:28:53 | python-dev | set | status: open -> closed nosy: + python-dev messages: + msg252016 resolution: fixed stage: needs patch -> resolved |
| 2015年09月28日 18:26:48 | serhiy.storchaka | set | messages:
+ msg251783 stage: needs patch |
| 2015年09月28日 17:57:10 | vinay.sajip | set | messages: + msg251781 |
| 2015年09月28日 17:07:09 | serhiy.storchaka | set | messages: + msg251776 |
| 2015年09月22日 08:21:49 | vinay.sajip | set | messages: + msg251292 |
| 2015年09月21日 12:04:55 | Arfrever | set | nosy:
+ Arfrever |
| 2015年09月20日 05:26:39 | serhiy.storchaka | set | messages: + msg251141 |
| 2015年09月19日 21:29:54 | serhiy.storchaka | set | nosy:
+ vinay.sajip |
| 2015年09月19日 21:29:19 | serhiy.storchaka | create | |