Issue 23234: refactor subprocess: use new OSError exceptions, factorize stdin.write() code

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/67423

classification

Title:	refactor subprocess: use new OSError exceptions, factorize stdin.write() code
Type:	enhancement	Stage:	resolved
Components:	Library (Lib)	Versions:	Python 3.4, Python 3.5

process

Dependencies:	Superseder:
Status:	closed	Resolution:	fixed
Assigned To:	Nosy List:	gregory.p.smith, martin.panter, python-dev, serhiy.storchaka, vstinner
Priority:	normal	Keywords:	patch

Created on 2015年01月13日 23:41 by vstinner, last changed 2022年04月11日 14:58 by admin. This issue is now closed.

Files
File name	Uploaded	Description	Edit
subprocess.patch	vstinner, 2015年01月13日 23:41	review

Messages (4)
msg233974 - (view)	Author: STINNER Victor (vstinner) * (Python committer)	Date: 2015年01月13日 23:41
Attached patch refactors subprocess code: - use new OSError exceptions - factorize stdin.write() code
msg234032 - (view)	Author: STINNER Victor (vstinner) * (Python committer)	Date: 2015年01月14日 16:10
I commited my change to Python 3.5. Thanks for the review Serhiy & vadmium.
msg234033 - (view)	Author: Roundup Robot (python-dev) (Python triager)	Date: 2015年01月14日 16:15
New changeset 0c5ae257966f by Victor Stinner in branch 'default': Closes #23234: Refactor subprocess https://hg.python.org/cpython/rev/0c5ae257966f
msg234109 - (view)	Author: Gregory P. Smith (gregory.p.smith) * (Python committer)	Date: 2015年01月16日 02:25
thanks for the cleanup refactoring!

History
Date	User	Action	Args
2022年04月11日 14:58:11	admin	set	github: 67423
2015年01月23日 10:56:04	serhiy.storchaka	link	issue16648 dependencies
2015年01月16日 02:25:09	gregory.p.smith	set	messages: + msg234109
2015年01月14日 16:15:19	python-dev	set	nosy: + python-dev messages: + msg234033 stage: patch review -> resolved
2015年01月14日 16:10:10	vstinner	set	messages: + msg234032
2015年01月14日 16:09:35	vstinner	set	status: open -> closed resolution: fixed
2015年01月14日 03:35:59	berker.peksag	set	nosy: + gregory.p.smith components: + Library (Lib), - Extension Modules stage: patch review
2015年01月14日 02:01:43	martin.panter	set	nosy: + martin.panter
2015年01月13日 23:41:01	vstinner	create

homepage