homepage

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Backport ensurepip Windows installer changes to 2.7
Type: enhancement Stage: resolved
Components: Windows Versions: Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: steve.dower Nosy List: benjamin.peterson, brian.curtin, dstufft, loewis, ncoghlan, python-dev, steve.dower, tim.golden, zach.ware
Priority: normal Keywords: patch

Created on 2014年11月12日 04:30 by steve.dower, last changed 2022年04月11日 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
ensurepipmsi.diff steve.dower, 2014年11月12日 04:30 review
Messages (10)
msg231059 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2014年11月12日 04:30
I've merged the changes from when ensurepip was added to Python 3 into msi.py (and also fixed up the new externals dir location), but I'm no expert on this script, so at least a second set of eyes would be appreciated. It seems to build and work okay.
msg231060 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2014年11月12日 04:31
Issue #22827 was the ensurepip backport.
msg231061 - (view) Author: Donald Stufft (dstufft) * (Python committer) Date: 2014年11月12日 04:40
I don't know anything about msi or this script so I can't offer any help there, but thanks!
msg231064 - (view) Author: Alyssa Coghlan (ncoghlan) * (Python committer) Date: 2014年11月12日 06:53
This looks to match the relevant pieces of the Python 3 version to me.
However, it occurs to me that Python 2 will still be missing other Windows usability enhancements that make pip easier to use:
- bundling the py launcher
- providing the installer option to enable PATH modifications that add the Scripts directory to the path
I forgot about those when writing PEP 477.
msg231074 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2014年11月12日 12:54
I'm not working on Python 2.7 anymore, so I can't offer help.
msg231078 - (view) Author: Alyssa Coghlan (ncoghlan) * (Python committer) Date: 2014年11月12日 13:58
After digging a little further, I see Brian backported the PATH modification support from issue #3561 in https://hg.python.org/cpython/rev/a9d34685ec47
This should probably be noted in the What's New document - while it's not technically part of PEP 477, that's still a good home for it in the What's New doc.
The lack of the Python launcher in Python 2 likely isn't a problem - at this point in history, switching between Python 2 and 3 is the most likely scenario, and in that situation, the launcher would have been installed together with the Python 3 installation.
msg231094 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2014年11月12日 21:09
Yes, I'll add Scripts into the PATH when that option is enabled too. I ignored that from the changeset I merged from, forgetting that that's where pip.exe will end up.
I'd rather not bundle the launcher with Python 2 right now (if ever). With the 3.5 installer it's going to be a much smoother ride as far as upgrades go (or having a standalone installer, which is basically what it is), and the more versions that try to fight with that one the harder people will find things.
Hopefully I have time to finish this off tonight, otherwise it may not be done until next week, as I'm very busy the next few days.
(Thanks Brian for the feedback on the review.)
msg231097 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014年11月13日 03:03
New changeset c248a6bdc1d7 by Steve Dower in branch '2.7':
Issue #22850: Backport ensurepip Windows installer changes to 2.7
https://hg.python.org/cpython/rev/c248a6bdc1d7 
msg231430 - (view) Author: Donald Stufft (dstufft) * (Python committer) Date: 2014年11月20日 13:33
Is this ticket able to be closed now or is there more to do?
msg231441 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2014年11月20日 17:00
It's done.
History
Date User Action Args
2022年04月11日 14:58:10adminsetgithub: 67039
2014年11月20日 17:00:57steve.dowersetstatus: open -> closed
resolution: fixed
messages: + msg231441

stage: patch review -> resolved
2014年11月20日 13:33:57dstufftsetmessages: + msg231430
2014年11月13日 03:03:06python-devsetnosy: + python-dev
messages: + msg231097
2014年11月12日 21:09:24steve.dowersetmessages: + msg231094
2014年11月12日 13:58:25ncoghlansetmessages: + msg231078
2014年11月12日 12:54:43loewissetmessages: + msg231074
2014年11月12日 06:53:10ncoghlansetnosy: + brian.curtin
messages: + msg231064
2014年11月12日 04:40:29dstufftsetmessages: + msg231061
2014年11月12日 04:31:42steve.dowersetmessages: + msg231060
2014年11月12日 04:30:33steve.dowercreate

AltStyle によって変換されたページ (->オリジナル) /