This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2014年11月04日 17:04 by Joshua.Chin, last changed 2022年04月11日 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| urlopen_doc.patch | Joshua.Chin, 2014年11月04日 17:04 | review | ||
| urlopen_doc.patch | Joshua.Chin, 2014年11月04日 20:43 | Documents when ValueError is raised | review | |
| urlopen_doc.patch | alex_thebear, 2016年06月03日 00:18 | Note that only protocol errors raise UrlError | review | |
| Messages (9) | |||
|---|---|---|---|
| msg230640 - (view) | Author: Joshua Chin (Joshua.Chin) * | Date: 2014年11月04日 17:04 | |
The documentation for urlopen states that it "Raises URLError on errors." However, urlopen can raise a ValueError. In fact, test_urllib. urlopen_FileTests.test_relativelocalfile specifically checks if urlopen raises a ValueError. I suggest removing the guarantee from the documentation. |
|||
| msg230641 - (view) | Author: R. David Murray (r.david.murray) * (Python committer) | Date: 2014年11月04日 17:12 | |
This is a general principle in Python. A module may raise specific errors, but there are always other errors that may be raised. The wording could be clarified, but it should not be removed. |
|||
| msg230657 - (view) | Author: R. David Murray (r.david.murray) * (Python committer) | Date: 2014年11月04日 22:25 | |
(Looking at your new patch...thanks for giving it a try even though I wasn't clear). There are lots of other errors it can raise, too. I was thinking more along the lines of "raises URLError on http protocol errors". The problem is that's not completely accurate, either, but I don't remember exactly when it is that HTTPError can leak through. Just for reference, in my code that calls urlopen and needs to keep running it if can't access the URL no matter what the (network-derived) reason, I catch ConnectionError, HTTPError, URLError, and IncompleteRead. We do not document all possible exceptions. We document those that are specific to the module in question (which is URLError in this case) or that are part of the documented API (such as mentioning TimeoutError as what happens if the timeout specified by a timeout keyword is exceeded). ValueErrors are a general class of errors that, when encountered, usually mean you need to fix your code (or, in the case of the SSL one you mention, check for SSL support at startup, assuming I understood correctly), rather than something you would catch around the urlopen call in a typical program. There are, of course, occasions when you *do* catch ValueErrors in specific bits of code, but there is no practical way we can document all of the reasons ValueError might get raised, so we don't try. All of that said, it would be lovely to have a reference somewhere (maybe a tutorial?) that went over all the possible exceptions one might get while using various network libraries, and why they might arise. It is an issue that comes from the fact that the libraries are built on top of each other and the general python technique is that lower level errors are allowed to bubble up. It would be a beast to keep up to date, though, which is probably one reason we don't have one. But even that kind of guide wouldn't include ValueErrors. |
|||
| msg267000 - (view) | Author: Alexander Liu (alex_thebear) * | Date: 2016年06月03日 00:18 | |
Fixed the docs to specifically note that only protocol related errors raise the UrlError exception. |
|||
| msg267115 - (view) | Author: Roundup Robot (python-dev) (Python triager) | Date: 2016年06月03日 17:33 | |
New changeset aed4b9981fca by R David Murray in branch '3.5': #22797: clarify when URLErrors are raised by urlopen. https://hg.python.org/cpython/rev/aed4b9981fca New changeset d085b4f779af by R David Murray in branch '3.5': Merge: #22797: clarify when URLErrors are raised by urlopen. https://hg.python.org/cpython/rev/d085b4f779af |
|||
| msg267151 - (view) | Author: Roundup Robot (python-dev) (Python triager) | Date: 2016年06月03日 19:51 | |
New changeset 8b6b6add8e47 by R David Murray in branch 'default': psuedo merge: #22797: clarify when URLErrors are raised by urlopen. https://hg.python.org/cpython/rev/8b6b6add8e47 |
|||
| msg267195 - (view) | Author: Roundup Robot (python-dev) (Python triager) | Date: 2016年06月04日 00:18 | |
New changeset b4df20312b78 by R David Murray in branch 'default': Clean up urlopen doc string. https://hg.python.org/cpython/rev/b4df20312b78 |
|||
| msg267196 - (view) | Author: R. David Murray (r.david.murray) * (Python committer) | Date: 2016年06月04日 00:19 | |
Thanks, Alexander. |
|||
| msg267235 - (view) | Author: Roundup Robot (python-dev) (Python triager) | Date: 2016年06月04日 05:31 | |
New changeset 2d69d0419879 by Martin Panter in branch 'default': Issue #22797: Synchronize urlopen() doc string with RST documentation https://hg.python.org/cpython/rev/2d69d0419879 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:58:09 | admin | set | github: 66986 |
| 2016年06月04日 05:31:34 | python-dev | set | messages: + msg267235 |
| 2016年06月04日 00:19:22 | r.david.murray | set | status: open -> closed versions: + Python 3.5 messages: + msg267196 resolution: fixed stage: resolved |
| 2016年06月04日 00:18:28 | python-dev | set | messages: + msg267195 |
| 2016年06月03日 19:51:00 | python-dev | set | messages: + msg267151 |
| 2016年06月03日 17:33:22 | python-dev | set | nosy:
+ python-dev messages: + msg267115 |
| 2016年06月03日 00:18:14 | alex_thebear | set | files:
+ urlopen_doc.patch versions: + Python 3.6, - Python 3.4 nosy: + alex_thebear messages: + msg267000 |
| 2014年11月04日 22:25:18 | r.david.murray | set | messages: + msg230657 |
| 2014年11月04日 20:43:36 | Joshua.Chin | set | files: + urlopen_doc.patch |
| 2014年11月04日 17:12:37 | r.david.murray | set | nosy:
+ r.david.murray messages: + msg230641 |
| 2014年11月04日 17:04:57 | Joshua.Chin | create | |