This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2014年07月04日 18:48 by serhiy.storchaka, last changed 2022年04月11日 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| test_tools.diff | zach.ware, 2014年07月08日 19:53 | Patch against default | review | |
| test_tools.diff--git | zach.ware, 2014年07月08日 19:54 | Patch against default, --git format | ||
| test_tools.v2.diff--git | zach.ware, 2014年07月15日 18:41 | |||
| Messages (9) | |||
|---|---|---|---|
| msg222305 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) | Date: 2014年07月04日 18:48 | |
Lib/test/test_tools.py becomes too large. It includes tests of unrelated command-lines tools and scripts. It would be good to convert it to directory containing separate test files for different tools. |
|||
| msg222579 - (view) | Author: Zachary Ware (zach.ware) * (Python committer) | Date: 2014年07月08日 19:53 | |
How about this? |
|||
| msg222580 - (view) | Author: Zachary Ware (zach.ware) * (Python committer) | Date: 2014年07月08日 19:54 | |
Here's the same patch in --git format, which should make the actual changes clearer (though probably not in Rietveld). |
|||
| msg223136 - (view) | Author: Zachary Ware (zach.ware) * (Python committer) | Date: 2014年07月15日 18:41 | |
Here's a new version of the patch in response to review comments. Patch is in --git format, which means no Rietveld link for this one. Changes from the first patch: - Remove Tools/parser/test_unparse.py entirely (moved to Lib/test/test_tools/) - Remove tearDownClass from the pdeps test - Fix (remove) test_main from test_unparse - Add test_md5sum (new since first patch) |
|||
| msg223143 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) | Date: 2014年07月15日 20:03 | |
About load_tests() -- look at Lib/test/test_email/__init__.py. Otherwise LGTM. |
|||
| msg223258 - (view) | Author: Roundup Robot (python-dev) (Python triager) | Date: 2014年07月16日 19:33 | |
New changeset e69f037332a6 by Zachary Ware in branch '3.4': Issue #21918: Convert test_tools.py to a sub-package of test. http://hg.python.org/cpython/rev/e69f037332a6 New changeset 1d0ca204c36f by Zachary Ware in branch 'default': Issue #21918: Convert test_tools.py to a sub-package of test. http://hg.python.org/cpython/rev/1d0ca204c36f |
|||
| msg223259 - (view) | Author: Zachary Ware (zach.ware) * (Python committer) | Date: 2014年07月16日 19:37 | |
Committed, thanks for the reviews! I had modeled load_tests after test_json's load_tests. The idiom used in test_email causes a warning from regrtest about sys.path being modified, so I modified the idiom slightly and used that. I have declined to backport the patch to 2.7; it's more trouble than it's worth to me. |
|||
| msg223277 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) | Date: 2014年07月16日 21:15 | |
Thanks for your patch. Do you want to correct test_json's and others load_tests? |
|||
| msg223279 - (view) | Author: Zachary Ware (zach.ware) * (Python committer) | Date: 2014年07月16日 21:17 | |
Sure, I'll work on that some time this week. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:58:05 | admin | set | github: 66117 |
| 2014年07月16日 21:17:33 | zach.ware | set | messages: + msg223279 |
| 2014年07月16日 21:15:36 | serhiy.storchaka | set | messages: + msg223277 |
| 2014年07月16日 19:37:02 | zach.ware | set | status: open -> closed resolution: fixed messages: + msg223259 stage: patch review -> resolved |
| 2014年07月16日 19:33:58 | python-dev | set | nosy:
+ python-dev messages: + msg223258 |
| 2014年07月15日 20:03:24 | serhiy.storchaka | set | messages: + msg223143 |
| 2014年07月15日 18:41:16 | zach.ware | set | files:
+ test_tools.v2.diff--git messages: + msg223136 versions: - Python 2.7 |
| 2014年07月08日 19:58:41 | berker.peksag | set | assignee: zach.ware stage: needs patch -> patch review |
| 2014年07月08日 19:54:20 | zach.ware | set | files:
+ test_tools.diff--git messages: + msg222580 |
| 2014年07月08日 19:53:19 | zach.ware | set | files:
+ test_tools.diff keywords: + patch messages: + msg222579 |
| 2014年07月04日 18:48:13 | serhiy.storchaka | create | |