homepage

Non-gui tests for turtle that Lita and I wrote.

Patch reviewed. Looks good.
This patch includes some amendments for readablity and new tests.

I made some review comments on ways to use test.support and test.subTest to simplify the code and make it even clearer. Also, I suggest not using Mock unless necessary (see review comments).

Thanks David for your review!
I have added a new patch in response.
Note the file has a new name

Tests failed on Windows probably because of NamedTemporaryFile

Thanks Tim for testing on Windows and suggesting the change.

@RDM I'm sitting with Greg at a London Python session and we've run through these tests on 3.4/3.5. I know you were reviewing this code at PyCon. Are you happy for me to commit from here?

I'm making a review.

Yes, I don't need to be involved further (unless you need help from me on something :)

Serhiy's offered a review and we can take it from here. :)

Added comments on Rietveld.
It looks the patch includes changes for non-relevant files.

This patch removes the unrelated XML changes and addresses most of the code review comments.

Added few minor comments on Rietveld. Please use more complex example for invalid config. Add valid lines before and after an invalid line.

Thanks for your comments. Added a patch addressing your comments.

Nice. LGTM.

New changeset f0b94cfcea45 by Serhiy Storchaka in branch '2.7':
Issue #21916: Added tests for the turtle module.
https://hg.python.org/cpython/rev/f0b94cfcea45
New changeset 3b9e96440a70 by Serhiy Storchaka in branch '3.5':
Issue #21916: Added tests for the turtle module.
https://hg.python.org/cpython/rev/3b9e96440a70
New changeset 3d1a23984a6e by Serhiy Storchaka in branch 'default':
Issue #21916: Added tests for the turtle module.
https://hg.python.org/cpython/rev/3d1a23984a6e 

Jelle, do you want to add tests the constructor, repr and pickling of Vec2D?

Thanks for merging it in. I'll add the additional tests.

Patch tests constructor, repr, equality checks, and pickling on Vec2D.

Thank you Jelle. Added minor comments on Rietveld.

Thanks, this patch addresses your comments.

New changeset 5c1befa401ca by Serhiy Storchaka in branch '3.5':
Issue #21916: Added more tests for the turtle module.
https://hg.python.org/cpython/rev/5c1befa401ca
New changeset 41fa38ea46ba by Serhiy Storchaka in branch '2.7':
Issue #21916: Added more tests for the turtle module.
https://hg.python.org/cpython/rev/41fa38ea46ba
New changeset 356f411e8c5c by Serhiy Storchaka in branch 'default':
Issue #21916: Added more tests for the turtle module.
https://hg.python.org/cpython/rev/356f411e8c5c 

Thank you for your patches Jelle.