This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2014年01月24日 04:53 by nikratio, last changed 2022年04月11日 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| xml.etree_r1.patch | nikratio, 2014年01月24日 04:53 | review | ||
| etree-testcases.patch | nikratio, 2014年01月26日 01:33 | review | ||
| issue20375.diff | nikratio, 2014年03月26日 00:32 | review | ||
| issue20375.diff | nikratio, 2014年03月31日 16:37 | review | ||
| issue20375.diff | nikratio, 2014年04月03日 01:46 | review | ||
| issue20375.diff | nikratio, 2014年04月03日 01:58 | review | ||
| Messages (13) | |||
|---|---|---|---|
| msg209036 - (view) | Author: Nikolaus Rath (nikratio) * | Date: 2014年01月24日 04:53 | |
(This issue was branched of from #9521). When parsing XML, etree currently skips over all processing instructions and comments. However, both can be represented in the tree and are also written out when generating XML. The attached patch documents this (IMO surprising) behavior. |
|||
| msg209265 - (view) | Author: Nikolaus Rath (nikratio) * | Date: 2014年01月26日 01:33 | |
I've also attached a testcase to confirm that the docpatch reflects current behavior, and to make sure that anticipated enhancements in Python 3.5 behave in a backwards compatible way. |
|||
| msg214076 - (view) | Author: PCManticore (Claudiu.Popa) * (Python triager) | Date: 2014年03月19日 11:03 | |
Hello. I left a couple of comments on Rietveld. |
|||
| msg214803 - (view) | Author: Stefan Behnel (scoder) * (Python committer) | Date: 2014年03月25日 10:33 | |
I think you attached the wrong file. |
|||
| msg214873 - (view) | Author: Nikolaus Rath (nikratio) * | Date: 2014年03月26日 00:32 | |
Indeed I did, here's the correct patch. Thanks! |
|||
| msg215235 - (view) | Author: Eli Bendersky (eli.bendersky) * (Python committer) | Date: 2014年03月31日 13:25 | |
The patch appears to contain code (tests) along with the documentation. Is this intended? This issue is not tagged properly if it is. I'd suggest to split them to separate patches. |
|||
| msg215250 - (view) | Author: Nikolaus Rath (nikratio) * | Date: 2014年03月31日 16:37 | |
Yes, the new testcases were deliberately included. I submitted the patch prior to the 3.4 release, am I right that at that point this wouldn't have been a problem? I have attached a new patch containing just the doc changes. I hope that's still acceptable for inclusion in 3.4 (and maybe 3.3? not sure if there'll be another bugfix release). |
|||
| msg215381 - (view) | Author: Eli Bendersky (eli.bendersky) * (Python committer) | Date: 2014年04月02日 13:27 | |
I left some comments in Rietveld. There shouldn't be a problem getting these into 3.4 too - doc changes are usually excempt from most restrictions. |
|||
| msg215415 - (view) | Author: Nikolaus Rath (nikratio) * | Date: 2014年04月03日 01:46 | |
Thanks for your feedback! I've attached an updated patch. |
|||
| msg215445 - (view) | Author: Roundup Robot (python-dev) (Python triager) | Date: 2014年04月03日 13:15 | |
New changeset 871278b87c62 by Eli Bendersky in branch '3.4': Issue #20375: Clarify ET's parsing of comments and processing instructions. http://hg.python.org/cpython/rev/871278b87c62 New changeset 5c3166ec80e1 by Eli Bendersky in branch 'default': Issue #20375: Clarify ET's parsing of comments and processing instructions. http://hg.python.org/cpython/rev/5c3166ec80e1 |
|||
| msg215446 - (view) | Author: Eli Bendersky (eli.bendersky) * (Python committer) | Date: 2014年04月03日 13:16 | |
Thanks. Doc patch committed with some slight rewording. Would you like to prepare a separate patch for the tests, default branch only this time? |
|||
| msg215465 - (view) | Author: Nikolaus Rath (nikratio) * | Date: 2014年04月03日 20:19 | |
Thanks for the commit! My intention is to fix the behavior itself for 3.5 (see issue 9521), so I think adding testcases for the old behavior in the meantime isn't necessary. |
|||
| msg215471 - (view) | Author: Eli Bendersky (eli.bendersky) * (Python committer) | Date: 2014年04月03日 21:39 | |
On Thu, Apr 3, 2014 at 1:19 PM, Nikolaus Rath <report@bugs.python.org>wrote: > > Nikolaus Rath added the comment: > > Thanks for the commit! > > My intention is to fix the behavior itself for 3.5 (see issue 9521), so I > think adding testcases for the old behavior in the meantime isn't necessary. > Fair enough. So you can close this issue, then. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:57:57 | admin | set | github: 64574 |
| 2014年04月04日 07:01:28 | berker.peksag | set | resolution: fixed stage: resolved |
| 2014年04月04日 00:05:10 | nikratio | set | status: open -> closed |
| 2014年04月03日 21:39:15 | eli.bendersky | set | messages: + msg215471 |
| 2014年04月03日 20:19:02 | nikratio | set | messages: + msg215465 |
| 2014年04月03日 13:16:19 | eli.bendersky | set | messages:
+ msg215446 versions: - Python 3.4 |
| 2014年04月03日 13:15:29 | python-dev | set | nosy:
+ python-dev messages: + msg215445 |
| 2014年04月03日 01:58:58 | nikratio | set | files: + issue20375.diff |
| 2014年04月03日 01:46:35 | nikratio | set | files:
+ issue20375.diff messages: + msg215415 |
| 2014年04月02日 13:27:23 | eli.bendersky | set | messages: + msg215381 |
| 2014年03月31日 16:37:57 | nikratio | set | files:
+ issue20375.diff messages: + msg215250 versions: + Python 3.4 |
| 2014年03月31日 13:25:21 | eli.bendersky | set | messages:
+ msg215235 versions: + Python 3.5, - Python 2.7, Python 3.3, Python 3.4 |
| 2014年03月26日 00:32:12 | nikratio | set | files:
+ issue20375.diff messages: + msg214873 |
| 2014年03月25日 21:06:28 | nikratio | set | files: - issue20951.diff |
| 2014年03月25日 10:33:37 | scoder | set | messages: + msg214803 |
| 2014年03月20日 02:44:58 | nikratio | set | files: + issue20951.diff |
| 2014年03月19日 11:03:04 | Claudiu.Popa | set | nosy:
+ Claudiu.Popa messages: + msg214076 |
| 2014年01月26日 01:33:09 | nikratio | set | files:
+ etree-testcases.patch messages: + msg209265 |
| 2014年01月24日 04:53:36 | nikratio | create | |