homepage

(Nosy list copied from #18702)
Grepping for "^\s+return$" and "^\s+pass$" in Lib/test turned up several more tests that are silently skipped (along with many legitimate uses of each). The attached patch turns each into a skip in a few various ways, including splitting a test into two tests in a couple of cases.
I'll make a few comments on Rietveld myself to point out places where I would really like some extra scrutiny.

See also issue19492 and issue19493.

Starting a review of #19492, I realized my original regexs didn't take comments into account. Grepping "^\s+return\s*(#.*)?$" instead turned up a couple more skips, including some in test_tempfile that said "return # ugh, can't use SkipTest", relics of the days before unittest.SkipTest.

I added some comments on Rietveld to the first patch. In general it LGTM. I will made a review for additional skips tomorrow.
I suggest extract importlib related changes in separated issue. Bratt Cannon should review them.

> I will made a review for additional skips tomorrow.
Additional skips LGTM.

Here's a new patch to address the reviews from Serhiy and Ezio (thanks to you both!).

I get a failure on Linux with test_posix:
$ ./python -m test test_posix
[1/1] test_posix
test test_posix failed -- Traceback (most recent call last):
 File "/home/wolf/dev/py/py3k/Lib/test/test_posix.py", line 713, in test_getcwd_long_pathnames
 _create_and_do_getcwd(dirname)
 File "/home/wolf/dev/py/py3k/Lib/test/test_posix.py", line 708, in _create_and_do_getcwd
 _create_and_do_getcwd(dirname, current_path_length + len(dirname) + 1)
 File "/home/wolf/dev/py/py3k/Lib/test/test_posix.py", line 708, in _create_and_do_getcwd
 _create_and_do_getcwd(dirname, current_path_length + len(dirname) + 1)
 File "/home/wolf/dev/py/py3k/Lib/test/test_posix.py", line 708, in _create_and_do_getcwd
 _create_and_do_getcwd(dirname, current_path_length + len(dirname) + 1)
 File "/home/wolf/dev/py/py3k/Lib/test/test_posix.py", line 708, in _create_and_do_getcwd
 _create_and_do_getcwd(dirname, current_path_length + len(dirname) + 1)
 File "/home/wolf/dev/py/py3k/Lib/test/test_posix.py", line 708, in _create_and_do_getcwd
 _create_and_do_getcwd(dirname, current_path_length + len(dirname) + 1)
 File "/home/wolf/dev/py/py3k/Lib/test/test_posix.py", line 708, in _create_and_do_getcwd
 _create_and_do_getcwd(dirname, current_path_length + len(dirname) + 1)
 File "/home/wolf/dev/py/py3k/Lib/test/test_posix.py", line 708, in _create_and_do_getcwd
 _create_and_do_getcwd(dirname, current_path_length + len(dirname) + 1)
 File "/home/wolf/dev/py/py3k/Lib/test/test_posix.py", line 708, in _create_and_do_getcwd
 _create_and_do_getcwd(dirname, current_path_length + len(dirname) + 1)
 File "/home/wolf/dev/py/py3k/Lib/test/test_posix.py", line 708, in _create_and_do_getcwd
 _create_and_do_getcwd(dirname, current_path_length + len(dirname) + 1)
 File "/home/wolf/dev/py/py3k/Lib/test/test_posix.py", line 708, in _create_and_do_getcwd
 _create_and_do_getcwd(dirname, current_path_length + len(dirname) + 1)
 File "/home/wolf/dev/py/py3k/Lib/test/test_posix.py", line 708, in _create_and_do_getcwd
 _create_and_do_getcwd(dirname, current_path_length + len(dirname) + 1)
 File "/home/wolf/dev/py/py3k/Lib/test/test_posix.py", line 708, in _create_and_do_getcwd
 _create_and_do_getcwd(dirname, current_path_length + len(dirname) + 1)
 File "/home/wolf/dev/py/py3k/Lib/test/test_posix.py", line 708, in _create_and_do_getcwd
 _create_and_do_getcwd(dirname, current_path_length + len(dirname) + 1)
 File "/home/wolf/dev/py/py3k/Lib/test/test_posix.py", line 708, in _create_and_do_getcwd
 _create_and_do_getcwd(dirname, current_path_length + len(dirname) + 1)
 File "/home/wolf/dev/py/py3k/Lib/test/test_posix.py", line 708, in _create_and_do_getcwd
 _create_and_do_getcwd(dirname, current_path_length + len(dirname) + 1)
 File "/home/wolf/dev/py/py3k/Lib/test/test_posix.py", line 708, in _create_and_do_getcwd
 _create_and_do_getcwd(dirname, current_path_length + len(dirname) + 1)
 File "/home/wolf/dev/py/py3k/Lib/test/test_posix.py", line 706, in _create_and_do_getcwd
 os.getcwd()
OSError: [Errno 34] Numerical result out of range
1 test failed:
 test_posix

Except pickletester and test_posix third patch LGTM. test_posix is worth separate issue. test_reduce and test_getinitargs in pickletester are always empty and can be just removed (if you don't want implement them).

I'll open new issues for test_posix and pickletester and commit the rest of the patch as soon as I can get it backported. Thanks for the reviews!

pickletester issue opened at #19648. The test_posix issue already has an open issue at #9246.

skiptest_not_return_or_pass.v4-3.3.diff LGTM.

The 2.7 patch has a lot of extra changes in it, extra review is probably in order for it.

New changeset 3283fb24106d by Zachary Ware in branch '3.3':
Issue 19572: More silently skipped tests explicitly skipped.
http://hg.python.org/cpython/rev/3283fb24106d
New changeset 03afd2d7d395 by Zachary Ware in branch 'default':
Issue 19572: More silently skipped tests explicitly skipped.
http://hg.python.org/cpython/rev/03afd2d7d395 

Committed on 3.3 and default; I'd still like some extra eyes on the 2.7 patch before I commit it.

I have added few comments on Rietveld.

Here's a new 2.7 patch. It addresses Serhiy's review comments and doesn't change test_xpickle, which I will be opening a new issue for.

I missed the comments on test_bsddb; I'll either post a new patch here or open a new issue depending on how big that diff becomes.

This patch includes Serhiy's suggestions. Oops!

$ ./python -3 -m test.regrtest test_builtin
test_builtin
test test_builtin crashed -- <type 'exceptions.AssertionError'>: filter ('.+ is renamed to imp.reload', DeprecationWarning) did not catch any warning
1 test failed:
 test_builtin
Rest of the skiptest_not_return_or_pass.v6-2.7.diff patch LGTM.

New changeset 423e09aedf79 by Zachary Ware in branch '2.7':
Issue #19572: More silently skipped tests explicitly skipped.
http://hg.python.org/cpython/rev/423e09aedf79 

Fixed that last comment in the commit. Thank you for all the reviews, Serhiy!

New changeset ca9bca7aecda by Zachary Ware in branch '2.7':
Issue #19572: Replace a return that shouldn't have been removed from test_os.
http://hg.python.org/cpython/rev/ca9bca7aecda 

New changeset 1ad2ff119356 by Zachary Ware in branch '3.3':
Avoid UnicodeEncodeError by only printing ASCII.
http://hg.python.org/cpython/rev/1ad2ff119356